feat(commands): a write that leaves the repo says so before you approve it (M-BUG-41)
The chain observed configuration across repos but presented every write it then proposed as though it landed where the session stands. STATE named two arms; measuring found five, and two of them are worse than the two already known: - implement — the approval prompt named NO path at all, only a count, so a plan editing ~/.claude/CLAUDE.md and one editing ./CLAUDE.md produced byte-identical prompts. - rollback — the file list rendered `.claude/settings.json`, a repo-relative FORM, while the restore writes to the absolute original. The other arms were silent; this one pointed the wrong way. - fix — paths were visible but unclassified, and --global mixed machine-wide and project rows into one unmarked table. The gate's strength comes from the target's scope class, never from the command asking: five command-owned policies would drift apart the way five copies of the lever table did. SCOPE_CLASSES is one source for class, gate, wording and predicate; templates render `disclosures[]` from the CLI instead of restating what a class means. Two orderings in that table are load-bearing, and both were measured: - plugin-managed before user-scope. Both ~/.claude/config-audit/ and the legacy ~/.config-audit/ are live, and every command writes session state there. The other order fires the gate on every write ever made and gets it switched off, which is worse than no gate. - user-scope before cross-repo. ~/.claude/.git EXISTS, so a plain .git-upward walk answers "another repo" for ~/.claude/CLAUDE.md and silently downgrades the strongest gate on the subtraction axis's primary target to disclosure. disclose is not require-ok: campaign export is cross-repo by design, so the gate there says so rather than refusing. Distinct from require-target-dir.mjs, which asks whether a scan ROOT is readable (exit 3) — a different invariant, left unmerged along with its four inline copies. Also structural, both found while building this: the hand-maintained GUARDED list in the unknown-flag sweep now derives its completeness from the directory (measured complete at 14 of 14 first, so nothing was hiding — but the 15th CLI would have been swept by nothing); and prose shape-guards use whitespace- tolerant patterns, after one went red against a command file that did say the right thing, line-wrapped. Gated: implement, fix, rollback, plan, campaign export. Suite 1596 -> 1625/0, frozen v5.0.0 and default-output baselines 0 changed files. No new GAP dimension, no lever, no finding code — utilization denominators untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013941cEohSD5Aw56FVAtBgZ
This commit is contained in:
parent
49bae2657f
commit
1543830c52
12 changed files with 821 additions and 9 deletions
|
|
@ -60,8 +60,38 @@ const GUARDED = [
|
|||
{ cli: 'token-hotspots-cli.mjs', argv: [], valueFlag: '--output-file' },
|
||||
{ cli: 'whats-active.mjs', argv: [], valueFlag: '--output-file' },
|
||||
{ cli: 'self-audit.mjs', argv: [], valueFlag: null }, // no value-taking flag
|
||||
{ cli: 'write-scope-cli.mjs', argv: ['--target', 'x'], valueFlag: '--output-file' },
|
||||
];
|
||||
|
||||
/**
|
||||
* GUARDED was hand-maintained, and a hand-maintained list of what to sweep is a
|
||||
* premise rather than a measurement — the shape that made `KNOWN_OPEN` wrong
|
||||
* about its own breadth (#57). Measured when this guard was added: the list was
|
||||
* complete at 14 of 14, so nothing was hiding. It is the NEXT CLI that is at
|
||||
* risk, so the coverage is derived from the directory instead of asserted about
|
||||
* a literal.
|
||||
*/
|
||||
test('every argv-reading CLI in scanners/ appears in GUARDED', async () => {
|
||||
const entries = await readdir(SCANNERS_DIR);
|
||||
const clis = [];
|
||||
for (const name of entries) {
|
||||
if (!name.endsWith('.mjs')) continue;
|
||||
const src = await readFile(resolve(SCANNERS_DIR, name), 'utf-8');
|
||||
if (src.includes('process.argv')) clis.push(name);
|
||||
}
|
||||
|
||||
const guarded = new Set(GUARDED.map((g) => g.cli));
|
||||
const missing = clis.filter((c) => !guarded.has(c)).sort();
|
||||
|
||||
assert.deepEqual(
|
||||
missing,
|
||||
[],
|
||||
'A CLI that reads process.argv but is absent from GUARDED is swept by nothing: it can\n' +
|
||||
'accept an unknown flag, or write a file named after one, and both arms of this test\n' +
|
||||
'would still be green. Add it to GUARDED rather than relaxing this check.',
|
||||
);
|
||||
});
|
||||
|
||||
function run(cli, argv, cwd = resolve(__dirname, '..', '..')) {
|
||||
return new Promise((res) => {
|
||||
const child = spawn(process.execPath, [resolve(SCANNERS_DIR, cli), ...argv], { cwd });
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue