open/config-audit
1
0
Fork 0
Code Issues Releases 1 Activity

fix(scanners): retire the autoMode GAP dimension, a /doctor duplicate (D1)

Browse source 
CC 2.1.226's /doctor Check 8 covers auto mode with usage-weighted judgement.
The binding positioning forbids carrying a feature whose whole value is
duplicating a /doctor check, so the "adopt this feature" nudge goes. The
deterministic side stays: SET still validates autoMode structure and still
flags it as dead config in shared project settings. GAP dimensions 25 -> 24.

The title lived in FOUR tables, not the two the removal was scoped against:
the dimension list, scoring TITLE_TO_ID, the humanizer's static translations,
and the scoring denominators (TIER_COUNTS t3 8->7, TOTAL_DIMENSIONS 25->24,
MAX_WEIGHTED 42->41) -- the one that moves a user-visible number. findGapId
falls back to 'unknown' silently, so a partial removal would have degraded
without failing. A blanket sync invariant now asserts all four against
GAP_CHECKS instead of comparing occurrences pairwise; each arm was verified
red against its own defect (denominator drift, orphaned humanizer entry,
resurrected dimension).

Frozen tests/snapshots/v5.0.0/ stays untouched. strip-retired-gap.mjs is the
removal twin of strip-added-scanner.mjs: it strips the retired dimension from
whichever side still carries it and re-derives GAP IDs, since retiring a
dimension from mid-list shifts every later ID by one. Derived utilization
figures are dropped from comparison rather than recomputed -- recomputing them
in a test helper would assert the new arithmetic against itself, and
scoring.test.mjs already pins them exactly. Re-seeding was rejected: it would
silently bake in any other drift across every scanner those four files cover.

risk_score, risk_band, verdict, overallGrade, maturity and segment are
byte-identical across the change (severity info carries zero risk weight; GAP
is excluded from the overall grade). Utilization shifts 43 -> 44 on the fixture.

D2 (CA-SKL-002) is NOT removed. Verified against the primary source first: the
CC changelog carries exactly one budget-fraction statement (L3786, 2.1.32) and
nothing supersedes it, so our 2% is current and 002 is not a duplicate with a
stale figure. /doctor's ~1% could not be reconciled from the changelog and it
discloses its own numbers as disk estimates, so it is recorded, not adopted.
Left explicitly unverified in a code note: L3786 says "character budget" while
we express tokens -- a 4x difference nobody can settle from the wording.

Suite 1531 -> 1535, all green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RsfPGxgwbR3MY54wDC6hat
This commit is contained in:
Kjell Tore Guttormsen 2026-08-09 22:43:04 +02:00
commit 4027cdcf54
17 changed files with 368 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/scanners/cli-humanizer.test.mjs
View file

@ -7,6 +7,7 @@ import { promisify } from 'node:util';
import { readFile, writeFile, unlink, mkdir, access } from 'node:fs/promises';
import { hermeticEnv, HERMETIC_HOME } from '../helpers/hermetic-home.mjs';
import { stripHotspotLoadPattern } from '../helpers/strip-hotspot-load-pattern.mjs';
import { stripRetiredGap } from '../helpers/strip-retired-gap.mjs';
const exec = promisify(execFile);
const __dirname = dirname(fileURLToPath(import.meta.url));
@ -43,7 +44,7 @@ async function runCli(cliPath, args, env = {}) {
function normalizeTokenHotspotsPayload(p) {
const out = JSON.parse(JSON.stringify(p));
out.duration_ms = 0;
return stripHotspotLoadPattern(out);
return stripRetiredGap(stripHotspotLoadPattern(out));
}
function normalizeManifestOutput(o) {
@ -76,7 +77,7 @@ function normalizePluginHealthOutput(o) {
function normalizeDriftOutput(o) {
// Drift result has no time fields; just round-trip through JSON.
return JSON.parse(JSON.stringify(o));
return stripRetiredGap(JSON.parse(JSON.stringify(o)));
}
// ============================================================================
@ -318,14 +319,14 @@ describe('fix-cli humanizer (Step 7)', () => {
const { stdout } = await runCli(CLI, [FIXTURE, '--json']);
const actual = JSON.parse(stdout);
const expected = JSON.parse(await readFile(SNAPSHOT, 'utf-8'));
assert.deepStrictEqual(actual, expected);
assert.deepStrictEqual(stripRetiredGap(actual), stripRetiredGap(expected));
});
it('--raw: stdout JSON byte-equal v5.0.0 snapshot', async () => {
const { stdout } = await runCli(CLI, [FIXTURE, '--raw']);
const actual = JSON.parse(stdout);
const expected = JSON.parse(await readFile(SNAPSHOT, 'utf-8'));
assert.deepStrictEqual(actual, expected);
assert.deepStrictEqual(stripRetiredGap(actual), stripRetiredGap(expected));
});
it('default mode stderr differs from --raw stderr when findings have humanizer translations', async () => {