open/config-audit
1
0
Fork 0
Code Issues Releases 1 Activity

fix(settings-validator): accept CC 2.1.114–181 keys + xhigh effort

Browse source 
Clears a cluster of active false positives where valid, documented
Claude Code config was flagged as unknown/invalid (gap matrix, Batch 1).

KNOWN_KEYS +11 (CC 2.1.133–181): allowAllClaudeAiMcps, disableBundledSkills,
enforceAvailableModels, fallbackModel, footerLinksRegexes, parentSettingsBehavior,
pluginSuggestionMarketplaces, requiredMaximumVersion, requiredMinimumVersion,
sandbox, wheelScrollAccelerationEnabled.

VALID_EFFORT_LEVELS += 'xhigh' (CC 2.1.154 Opus-4.8 top tier).
TYPE_CHECKS += disableBundledSkills/wheelScrollAccelerationEnabled (boolean).
fallbackModel intentionally NOT type-checked (string | array<=3).

Tests: hermetic runtime temp-fixture (path-guard blocks committing
settings.json); 29/29 SET green, full hermetic suite unaffected.

Ref: docs/cc-2.1.x-gap-matrix.md

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ter3E2JSi1Khgmuf2kady8
This commit is contained in:
Kjell Tore Guttormsen 2026-06-18 11:58:42 +02:00
commit 73099354c7
2 changed files with 98 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

76
tests/scanners/settings-validator.test.mjs
View file

@ -1,7 +1,9 @@
import { describe, it, beforeEach } from 'node:test';
import { describe, it, beforeEach, afterEach } from 'node:test';
import assert from 'node:assert/strict';
import { resolve } from 'node:path';
import { resolve, join } from 'node:path';
import { fileURLToPath } from 'node:url';
import { mkdtemp, mkdir, writeFile, rm } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { resetCounter } from '../../scanners/lib/output.mjs';
import { discoverConfigFiles } from '../../scanners/lib/file-discovery.mjs';
import { scan } from '../../scanners/settings-validator.mjs';
@ -119,6 +121,76 @@ describe('SET scanner — additionalDirectories (v5 M6)', () => {
});
});
describe('SET scanner — CC 2.1.114→181 valid keys (Batch 1 false-positive fix)', () => {
// The pre-write path-guard blocks the agent from committing settings.json
// fixtures, so this suite materializes a hermetic temp fixture at runtime.
let tmpRoot;
let result;
const NEW_KEYS = [
'sandbox', 'fallbackModel', 'enforceAvailableModels', 'disableBundledSkills',
'pluginSuggestionMarketplaces', 'requiredMinimumVersion', 'requiredMaximumVersion',
'allowAllClaudeAiMcps', 'footerLinksRegexes', 'wheelScrollAccelerationEnabled',
'parentSettingsBehavior',
];
beforeEach(async () => {
resetCounter();
tmpRoot = await mkdtemp(join(tmpdir(), 'ca-set-2181-'));
await mkdir(join(tmpRoot, '.claude'), { recursive: true });
const settings = {
$schema: 'https://json.schemastore.org/claude-code-settings.json',
effortLevel: 'xhigh', // CC 2.1.154
sandbox: { allowAppleEvents: false }, // CC 2.1.181
fallbackModel: ['claude-opus-4-8', 'claude-sonnet-4-6'], // CC 2.1.166 (string|array)
enforceAvailableModels: true, // CC 2.1.175
disableBundledSkills: true, // CC 2.1.169
pluginSuggestionMarketplaces: ['acme'], // CC 2.1.152
requiredMinimumVersion: '2.1.114', // CC 2.1.163
requiredMaximumVersion: '2.2.0', // CC 2.1.163
allowAllClaudeAiMcps: false, // CC 2.1.149
footerLinksRegexes: ['^https://internal\\.'], // CC 2.1.181
wheelScrollAccelerationEnabled: true, // CC 2.1.174
parentSettingsBehavior: 'merge', // CC 2.1.133
permissions: { deny: ['Read(./.env)'], allow: ['Bash(npm run *)'] },
};
await writeFile(
join(tmpRoot, '.claude', 'settings.json'),
JSON.stringify(settings, null, 2) + '\n',
'utf8',
);
const discovery = await discoverConfigFiles(tmpRoot);
result = await scan(tmpRoot, discovery);
});
afterEach(async () => {
if (tmpRoot) await rm(tmpRoot, { recursive: true, force: true });
});
it('accepts effortLevel "xhigh" (CC 2.1.154)', () => {
const bad = result.findings.find(f => /xhigh/.test(f.evidence || ''));
assert.equal(bad, undefined, 'xhigh must be a valid effortLevel');
});
for (const key of NEW_KEYS) {
it(`does NOT flag "${key}" as an unknown key`, () => {
const unknown = result.findings.find(f =>
f.title === 'Unknown settings key' && f.evidence === key);
assert.equal(unknown, undefined, `${key} should be in KNOWN_KEYS`);
});
}
it('treats fallbackModel array value without a single-type mismatch', () => {
const f = result.findings.find(x => /fallbackModel/.test(x.evidence || ''));
assert.equal(f, undefined, 'fallbackModel (string|array) must not be type-checked');
});
it('produces zero findings for an all-valid CC 2.1.181 settings file', () => {
assert.equal(result.findings.length, 0,
`expected clean scan; got: ${result.findings.map(f => `${f.title}:${f.evidence || ''}`).join(' | ')}`);
});
});
describe('SET scanner — empty project', () => {
let result;
beforeEach(async () => {