open/config-audit
1
0
Fork 0
Code Issues Pull requests Releases Activity

fix(commands): close the promises the command templates could not keep

Browse source 
DEL B chunk `interview` (+ discover/status/cleanup/help). Fasit written before
the run predicted 8 defects and refuted 4 candidates; all 8 confirmed, all 4
refutations held, and three predictions turned out too narrow.

- M-BUG-36: `drift --list` reached the command as 0 bytes. drift-cli accepted
  --output-file but list mode ignored it, and the listing goes to stderr, which
  the command discards per ux-rules rule 2. Fixing the caller alone would not
  have helped.
- M-BUG-37: feature-gap's "Create backup" step ran fix-cli without --apply.
  Dry-run is the default, so no backup existed (backupId: null) while the
  command went on to edit config believing it could roll back.
- M-BUG-38: fix-cli told users to recover with scanners/rollback-cli.mjs, which
  does not exist. Dead reference in the one message read after a bad fix.
- M-BUG-21 fourth arm: five templates carried literal [--global]/[--full-machine]
  inside executable bash blocks. A bracketed placeholder does not start with a
  dash, so every scanner's arg loop takes it as the scan target.
- interview and analyze never said which session they act on; interview could
  rewind a finished session; cleanup interpolated an unvalidated id into rm -rf
  (an empty id deletes every session); status advertised a `resume` command that
  does not exist and documented an `all` argument it never parsed.

TDD: 9 red tests first, including a machine sweep for dead /config-audit
references and for bracketed flags in bash blocks. Suite 1432 -> 1441/0.
Frozen v5.0.0 snapshots untouched; --raw/--json contracts unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UGvA1uUQn2hPBPMaCKK6x3
This commit is contained in:
Kjell Tore Guttormsen 2026-07-31 21:27:07 +02:00
commit b85919f2ec
17 changed files with 318 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/scanners/drift-cli.test.mjs
View file

@ -46,6 +46,21 @@ describe('drift-cli --list', () => {
const found = output.baselines.find(b => b.name === TEST_BASELINE);
assert.ok(found, 'Should find test baseline in list');
});
// commands/drift.md runs `--list` with `2>/dev/null` (ux-rules rule 2), so a
// stderr-only listing reaches the command as 0 bytes and it can show nothing.
// --output-file was accepted by the arg parser but ignored by list mode.
it('writes the listing to --output-file so the command can read it', () => {
execFileSync('node', [DRIFT_CLI, HEALTHY, '--save', '--name', TEST_BASELINE], RUN);
const outFile = join(mkdtempSync(join(tmpdir(), 'drift-list-')), 'list.json');
execFileSync('node', [DRIFT_CLI, '--list', '--output-file', outFile], RUN);
assert.ok(existsSync(outFile), '--list must honour --output-file');
const payload = JSON.parse(readFileSync(outFile, 'utf-8'));
assert.ok(Array.isArray(payload.baselines));
assert.ok(payload.baselines.find(b => b.name === TEST_BASELINE));
});
});
describe('drift-cli compare', () => {