The COL collision-scanner and the CLAUDE.md cascade resolve ~/.claude from process.env.HOME (active-config-reader). Snapshot/byte CLIs were spawned with the developer's real HOME, so they picked up installed plugins/skills and the user CLAUDE.md — making the v5.0.0 + default-output snapshots machine- and time-dependent. They were seeded 2026-05-01 with COL=1 (a real ~/.claude skill collision) and drifted to COL=0 after the polyrepo split: 26 pre-existing failures unrelated to Batch 1. Fix (test-only, no production change): - tests/helpers/hermetic-home.mjs — empty temp HOME, mirroring the pattern collision.test.mjs already uses for the COL unit test. - 7 harnesses spawn CLIs (or call lint()) under the hermetic HOME, so output depends only on committed fixtures. Determinism verified across runs. - Re-seeded all snapshots under hermetic HOME via SEED_SNAPSHOT/UPDATE_SNAPSHOT (added a SEED guard to the frozen v5.0.0 byte tests). Snapshots now reflect the fixture alone (COL=0, fixture-only activeConfig counts). - Also re-seeded the unused env-aware snapshots (manifest/whats-active/ plugin-health), which had baked dozens of real ~/.claude skill/plugin names into the committed repo — privacy cleanup. Full suite: 812/812 green, stable across 3 runs.
173 lines
5.6 KiB
JavaScript
173 lines
5.6 KiB
JavaScript
/**
|
|
* SC-5 — default-output snapshot test (Wave 4 Step 12).
|
|
*
|
|
* Captures the humanized stdout of three representative CLIs running in
|
|
* default mode against tests/fixtures/marketplace-medium and asserts
|
|
* byte-equal output against tests/snapshots/default-output/<cli>.json.
|
|
*
|
|
* Set UPDATE_SNAPSHOT=1 to seed or refresh a snapshot. Subsequent runs
|
|
* assert byte-equal — any drift fails the test, so humanizer prose
|
|
* changes must be intentional and re-approved by re-running with
|
|
* UPDATE_SNAPSHOT=1.
|
|
*
|
|
* Time-varying fields are normalized before comparison (timestamp,
|
|
* target path, duration_ms). Humanizer-added prose fields
|
|
* (titleHumanized / descriptionHumanized / recommendationHumanized,
|
|
* userImpactCategory, userActionLanguage, relevanceContext) are kept —
|
|
* they are the contract being snapshotted.
|
|
*/
|
|
import { describe, it } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { resolve, dirname } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { execFile } from 'node:child_process';
|
|
import { promisify } from 'node:util';
|
|
import { readFile, writeFile } from 'node:fs/promises';
|
|
import { hermeticEnv } from './helpers/hermetic-home.mjs';
|
|
|
|
const exec = promisify(execFile);
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
const REPO = resolve(__dirname, '..');
|
|
const FIXTURE = resolve(REPO, 'tests/fixtures/marketplace-medium');
|
|
const SNAPSHOT_DIR = resolve(REPO, 'tests/snapshots/default-output');
|
|
|
|
const UPDATE = process.env.UPDATE_SNAPSHOT === '1';
|
|
|
|
async function runCli(scriptPath, args) {
|
|
try {
|
|
const { stdout, stderr } = await exec('node', [scriptPath, ...args], {
|
|
timeout: 60000,
|
|
cwd: REPO,
|
|
maxBuffer: 10 * 1024 * 1024,
|
|
env: hermeticEnv(),
|
|
});
|
|
return { stdout: stdout || '', stderr: stderr || '' };
|
|
} catch (err) {
|
|
return { stdout: err.stdout || '', stderr: err.stderr || '' };
|
|
}
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Normalizers — same shape per CLI as json-backcompat / cli-humanizer tests.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
function normalizeScanOrchestrator(env) {
|
|
const out = JSON.parse(JSON.stringify(env));
|
|
if (out.meta) {
|
|
out.meta.target = '<TARGET>';
|
|
out.meta.timestamp = '<TIMESTAMP>';
|
|
}
|
|
if (Array.isArray(out.scanners)) {
|
|
for (const s of out.scanners) {
|
|
s.duration_ms = 0;
|
|
// claudeMdEstimatedTokens reflects walkClaudeMdCascade walking up from
|
|
// the fixture into this plugin's own CLAUDE.md; any docs edit ripples
|
|
// into it independently of scanner internals. Strip to keep the
|
|
// default-output snapshot focused on humanizer prose stability.
|
|
if (s.activeConfig && 'claudeMdEstimatedTokens' in s.activeConfig) {
|
|
s.activeConfig.claudeMdEstimatedTokens = '<ANCESTOR_DERIVED>';
|
|
}
|
|
}
|
|
}
|
|
return out;
|
|
}
|
|
|
|
function normalizeTokenHotspots(p) {
|
|
const out = JSON.parse(JSON.stringify(p));
|
|
out.duration_ms = 0;
|
|
return out;
|
|
}
|
|
|
|
const CLIS = [
|
|
{
|
|
name: 'scan-orchestrator',
|
|
script: 'scanners/scan-orchestrator.mjs',
|
|
snapshotName: 'scan-orchestrator.json',
|
|
normalize: normalizeScanOrchestrator,
|
|
captureStream: 'stdout',
|
|
},
|
|
{
|
|
name: 'token-hotspots',
|
|
script: 'scanners/token-hotspots-cli.mjs',
|
|
snapshotName: 'token-hotspots.json',
|
|
normalize: normalizeTokenHotspots,
|
|
captureStream: 'stdout',
|
|
},
|
|
{
|
|
name: 'posture',
|
|
script: 'scanners/posture.mjs',
|
|
snapshotName: 'posture.json',
|
|
// Posture default mode emits the humanized scorecard to stderr; stdout is
|
|
// empty unless --json/--raw. Snapshot the scorecard text.
|
|
normalize: (s) => s.replace(/\(\d+ms\)/g, '(0ms)'),
|
|
captureStream: 'stderr-text',
|
|
},
|
|
];
|
|
|
|
async function captureForCli(cli) {
|
|
const script = resolve(REPO, cli.script);
|
|
const { stdout, stderr } = await runCli(script, [FIXTURE]);
|
|
|
|
if (cli.captureStream === 'stdout') {
|
|
const parsed = JSON.parse(stdout);
|
|
return {
|
|
kind: 'json',
|
|
payload: cli.normalize(parsed),
|
|
};
|
|
}
|
|
|
|
if (cli.captureStream === 'stderr-text') {
|
|
return {
|
|
kind: 'text',
|
|
payload: cli.normalize(stderr.trim()),
|
|
};
|
|
}
|
|
|
|
throw new Error(`unknown captureStream: ${cli.captureStream}`);
|
|
}
|
|
|
|
async function loadSnapshot(snapshotPath) {
|
|
const raw = await readFile(snapshotPath, 'utf8');
|
|
// Snapshot files are stored as JSON envelopes — text snapshots are wrapped
|
|
// as { kind: 'text', payload: '...' } so all snapshots look uniform on disk.
|
|
return JSON.parse(raw);
|
|
}
|
|
|
|
async function writeSnapshot(snapshotPath, captured) {
|
|
const serialized = JSON.stringify(captured, null, 2) + '\n';
|
|
await writeFile(snapshotPath, serialized, 'utf8');
|
|
}
|
|
|
|
describe('SC-5 default-output snapshot test', () => {
|
|
for (const cli of CLIS) {
|
|
it(`${cli.name} default mode matches tests/snapshots/default-output/${cli.snapshotName}`, async () => {
|
|
const captured = await captureForCli(cli);
|
|
const snapshotPath = resolve(SNAPSHOT_DIR, cli.snapshotName);
|
|
|
|
if (UPDATE) {
|
|
await writeSnapshot(snapshotPath, captured);
|
|
return;
|
|
}
|
|
|
|
let expected;
|
|
try {
|
|
expected = await loadSnapshot(snapshotPath);
|
|
} catch (err) {
|
|
if (err.code === 'ENOENT') {
|
|
assert.fail(
|
|
`Snapshot missing: ${snapshotPath}. ` +
|
|
`Re-run with UPDATE_SNAPSHOT=1 to seed it.`,
|
|
);
|
|
}
|
|
throw err;
|
|
}
|
|
|
|
assert.deepStrictEqual(
|
|
captured,
|
|
expected,
|
|
`${cli.name}: default-output drift detected. ` +
|
|
`If intentional, re-run with UPDATE_SNAPSHOT=1.`,
|
|
);
|
|
});
|
|
}
|
|
});
|