`optimize --subtract` has only ever proposed. `--apply` executes the blocks the operator picks, behind a backup whose coverage is verified and a scope gate the engine enforces rather than describes. The open design decision from plan §C6 was settled by two measurements, not by taste. It is NOT a fix-engine action: the subtraction axis appears nowhere in scan-orchestrator or optimization-lens-scanner, so verifyFixes' re-scan would mark every removal `verified` whether or not it happened -- a success-shaped no-op, the same shape that made restoreBackup silently do nothing. It is NOT a plan/implement step either: that pipeline needs a finding code, and OPT declares exactly one, for the deterministic check. The approval artifact is written by main context, not by the lens agent. That is where the operator's decision actually happens, and it keeps the feature off the still-unmeasured agent write surface (M-BUG-18 lists optimize as open). Three properties are load-bearing, and each was seen red against its own defect: removals validate against the ORIGINAL content and apply in descending line order; the range check is not redundant with the text check (`line: 0` makes `slice(-1, 0)` empty, so an empty text MATCHES and `splice(-1, 1)` deletes the file's last line); and createBackup skips a nonexistent path while still returning an id, so manifest coverage is asserted before a byte changes. Two guards were green on their own defect and were fixed after measuring: `/\b80\s*%\b/` never matches "80% of the file" -- `%` is a non-word character, so the trailing `\b` demands a word character next. And the caller-arm sweep passed vacuously against HEAD, iterating an empty list; only the added non-emptiness assertion caught it. The floor is repeated, not moved: floor-exclusion still vetoes before anything is proposed, and the engine refuses a load-bearing block again so a hand-built approval cannot route around it. `mv` to `_archive/` is a file-level rule and does not apply to a block excision -- the timestamped backup is the recovery artifact, and a second copy with no restorer would be worse than none. strongestGate moves into write-scope.mjs so the gate ordering has one owner. Dogfooded DRY-RUN against the real ~/.claude/CLAUDE.md: 29 candidates, gate refused all 29 with exit 0 until the scope was approved, then 29/29 spans validated with nothing written. ~789 tokens, ~18% of the file -- corroborating the #40 fasit's ~850, and well short of what a deletion feature is tempted to promise. Suite 1625 -> 1659/0. Frozen v5.0.0 and default-output baselines untouched. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017A6vrtPKsVuM4DJ27p7jzw
97 lines
3.3 KiB
JavaScript
97 lines
3.3 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
/**
|
|
* write-scope CLI — classify the write targets a command is about to touch,
|
|
* relative to the repo the session stands in (M-BUG-41).
|
|
*
|
|
* Exists so the gate has ONE implementation. Five command templates need the
|
|
* same answer before their approval surface; five prose paraphrases of the
|
|
* class table would be five policies drifting apart — the shape that put the
|
|
* lever table in five copies (#61). The templates call this and render what
|
|
* comes back.
|
|
*
|
|
* Usage:
|
|
* node write-scope-cli.mjs --target <path> [--target <path> ...]
|
|
* [--repo <session-repo-root>]
|
|
* [--output-file <path>] [--json]
|
|
*
|
|
* Exit codes: 0 = classified, 3 = argument or tool error.
|
|
*
|
|
* A gated target is NOT an error exit. The exit-code contract reserves 3 for
|
|
* "the scanner could not do its job"; "this write leaves the repo" is a verdict
|
|
* about a write, and it rides in the payload — a command cannot act on
|
|
* something that only ever reached stderr (F3's class).
|
|
*
|
|
* Zero external dependencies.
|
|
*/
|
|
|
|
import { resolve } from 'node:path';
|
|
import { writeOutputFile } from './lib/write-output.mjs';
|
|
import { requireValidArgs } from './lib/cli-args.mjs';
|
|
import { SCOPE_CLASSES, classifyWriteTarget, strongestGate } from './lib/write-scope.mjs';
|
|
|
|
/** Flag surface. Anything else is exit 3. */
|
|
const ARG_SPEC = { boolean: ['--json'], value: ['--target', '--repo', '--output-file'] };
|
|
|
|
async function main() {
|
|
const args = process.argv.slice(2);
|
|
if (!requireValidArgs(args, ARG_SPEC)) return;
|
|
|
|
const targets = [];
|
|
let repo = process.cwd();
|
|
let outputFile = null;
|
|
let jsonMode = false;
|
|
|
|
for (let i = 0; i < args.length; i++) {
|
|
if (args[i] === '--json') jsonMode = true;
|
|
else if (args[i] === '--target') targets.push(args[++i]);
|
|
else if (args[i] === '--repo') repo = args[++i];
|
|
else if (args[i] === '--output-file') outputFile = args[++i];
|
|
}
|
|
|
|
if (targets.length === 0) {
|
|
process.stderr.write('Error: at least one --target is required\n');
|
|
process.exitCode = 3;
|
|
return;
|
|
}
|
|
|
|
const classified = targets.map((t) => classifyWriteTarget(t, repo));
|
|
const gate = strongestGate(classified);
|
|
|
|
const payload = {
|
|
meta: {
|
|
repo: resolve(repo),
|
|
targetCount: classified.length,
|
|
// The class table travels with the answer so a template never has to
|
|
// restate what a class means.
|
|
classes: Object.fromEntries(
|
|
Object.entries(SCOPE_CLASSES).map(([name, spec]) => [name, { gate: spec.gate }]),
|
|
),
|
|
},
|
|
gate,
|
|
requiresApproval: gate === 'require-ok',
|
|
// Distinct disclosure lines, in class order, ready to render verbatim.
|
|
disclosures: [...new Set(classified.map((t) => t.disclosure).filter(Boolean))],
|
|
targets: classified,
|
|
};
|
|
|
|
const json = `${JSON.stringify(payload, null, 2)}\n`;
|
|
if (outputFile) {
|
|
await writeOutputFile(outputFile, json);
|
|
// Nothing on stdout when writing to a file: a command that also renders
|
|
// this would otherwise show the user the raw payload (ux-rules rule 1).
|
|
} else if (jsonMode) {
|
|
process.stdout.write(json);
|
|
} else {
|
|
for (const t of payload.targets) {
|
|
process.stdout.write(`${t.scopeClass}\t${t.gate}\t${t.target}\n`);
|
|
}
|
|
}
|
|
}
|
|
|
|
try {
|
|
await main();
|
|
} catch (err) {
|
|
process.stderr.write(`Error: ${err.message}\n`);
|
|
process.exitCode = 3;
|
|
}
|