config-audit/tests/snapshots/v5.0.0/fix-cli.json
Kjell Tore Guttormsen 8216fb4175 test(snapshots): make byte/snapshot tests hermetic + re-seed baseline
The COL collision-scanner and the CLAUDE.md cascade resolve ~/.claude from
process.env.HOME (active-config-reader). Snapshot/byte CLIs were spawned with
the developer's real HOME, so they picked up installed plugins/skills and the
user CLAUDE.md — making the v5.0.0 + default-output snapshots machine- and
time-dependent. They were seeded 2026-05-01 with COL=1 (a real ~/.claude skill
collision) and drifted to COL=0 after the polyrepo split: 26 pre-existing
failures unrelated to Batch 1.

Fix (test-only, no production change):
- tests/helpers/hermetic-home.mjs — empty temp HOME, mirroring the pattern
  collision.test.mjs already uses for the COL unit test.
- 7 harnesses spawn CLIs (or call lint()) under the hermetic HOME, so output
  depends only on committed fixtures. Determinism verified across runs.
- Re-seeded all snapshots under hermetic HOME via SEED_SNAPSHOT/UPDATE_SNAPSHOT
  (added a SEED guard to the frozen v5.0.0 byte tests). Snapshots now reflect
  the fixture alone (COL=0, fixture-only activeConfig counts).
- Also re-seeded the unused env-aware snapshots (manifest/whats-active/
  plugin-health), which had baked dozens of real ~/.claude skill/plugin names
  into the committed repo — privacy cleanup.

Full suite: 812/812 green, stable across 3 runs.
2026-06-18 12:26:00 +02:00

130 lines
5 KiB
JSON

{
"planned": [],
"applied": [],
"failed": [],
"verified": [],
"regressions": [],
"manual": [
{
"findingId": "CA-CML-001",
"title": "Missing recommended sections",
"file": "/Users/ktg/repos/ktg-plugin-marketplace/config-audit/tests/fixtures/marketplace-medium/CLAUDE.md",
"recommendation": "Add sections for: Project overview, Architecture"
},
{
"findingId": "CA-GAP-001",
"title": "No custom skills or commands",
"file": null,
"recommendation": "Create project-specific skills in .claude/skills/ or commands in .claude/commands/ to automate repetitive workflows."
},
{
"findingId": "CA-GAP-002",
"title": "Settings only at one scope",
"file": null,
"recommendation": "Use all 3 settings scopes: ~/.claude/settings.json (user), .claude/settings.json (project), .claude/settings.local.json (local/personal)."
},
{
"findingId": "CA-GAP-003",
"title": "No path-scoped rules",
"file": null,
"recommendation": "Create .claude/rules/*.md with paths: frontmatter to apply rules only to matching files."
},
{
"findingId": "CA-GAP-004",
"title": "Low hook diversity",
"file": null,
"recommendation": "Use hooks across 3+ events (e.g., SessionStart, PreToolUse, Stop) for comprehensive automation."
},
{
"findingId": "CA-GAP-005",
"title": "No custom subagents",
"file": null,
"recommendation": "Create custom agents in .claude/agents/ or ~/.claude/agents/ with specialized tools and model selection."
},
{
"findingId": "CA-GAP-006",
"title": "No model configuration",
"file": null,
"recommendation": "Set model preferences in settings.json (model, modelOverrides) for cost/quality optimization."
},
{
"findingId": "CA-GAP-007",
"title": "No status line configured",
"file": null,
"recommendation": "Configure statusLine in settings.json to show context window usage, cost, and model info."
},
{
"findingId": "CA-GAP-008",
"title": "No custom keybindings",
"file": null,
"recommendation": "Create ~/.claude/keybindings.json to customize keyboard shortcuts (e.g., bind chat:newline to Shift+Enter)."
},
{
"findingId": "CA-GAP-009",
"title": "Using default output style",
"file": null,
"recommendation": "Try \"Explanatory\" or \"Learning\" output styles, or create custom styles in .claude/output-styles/."
},
{
"findingId": "CA-GAP-010",
"title": "No worktree workflow",
"file": null,
"recommendation": "Use --worktree for parallel feature development. Configure worktree.symlinkDirectories for node_modules."
},
{
"findingId": "CA-GAP-011",
"title": "No advanced skill frontmatter",
"file": null,
"recommendation": "Use disable-model-invocation, context:fork, or argument-hint in skill frontmatter for better control."
},
{
"findingId": "CA-GAP-012",
"title": "No subagent isolation",
"file": null,
"recommendation": "Use isolation: worktree in agent frontmatter for safe parallel development."
},
{
"findingId": "CA-GAP-013",
"title": "No dynamic skill context",
"file": null,
"recommendation": "Use !`command` syntax in skills to inject dynamic context (e.g., !`git branch --show-current`)."
},
{
"findingId": "CA-GAP-014",
"title": "No autoMode classifier",
"file": null,
"recommendation": "Configure autoMode in user/local settings with environment context and allow/deny rules."
},
{
"findingId": "CA-GAP-015",
"title": "No custom plugin",
"file": null,
"recommendation": "Package reusable skills, agents, and hooks as a Claude Code plugin with .claude-plugin/plugin.json."
},
{
"findingId": "CA-GAP-016",
"title": "No managed settings",
"file": null,
"recommendation": "Use managed-settings.json for organization-wide policy enforcement."
},
{
"findingId": "CA-GAP-017",
"title": "No LSP plugins",
"file": null,
"recommendation": "Add .lsp.json for real-time code intelligence from language servers."
},
{
"findingId": "CA-TOK-001",
"title": "High MCP tool-schema budget on server \"memory\"",
"file": ".mcp.json",
"recommendation": "Install the package locally (so detect-mcp-tool-count can read its manifest), or run the server once and cache its tools/list response under ~/.claude/config-audit/mcp-cache/<name>.json. See knowledge/cache-telemetry-recipe.md."
},
{
"findingId": "CA-DIS-001",
"title": "Tool listed in both permissions.deny and permissions.allow",
"file": "/Users/ktg/repos/ktg-plugin-marketplace/config-audit/tests/fixtures/marketplace-medium/.claude/settings.json",
"recommendation": "Remove the redundant allow entries. If you actually want this tool enabled, remove it from the deny list instead. Settings should express intent clearly."
}
],
"backupId": null
}