Kjell Tore Guttormsen
bec3f45329
The DIS scanner collapsed Tool(param) rules to the bare tool name, so Agent(model:opus) deny + Agent(model:sonnet) allow (and the same for WebFetch(domain:...)) were flagged as dead config — a false positive now that CC 2.1.178 matches Tool(param:value) and 2.1.172 adds domain rules. The conflict-detector shared the blind spot from the other side: a wildcard deny like WebFetch(domain:*) did not cover a WebFetch(domain:good.com) allow, so a genuine cross-scope conflict was missed (false negative). New shared scanners/lib/permission-rules.mjs: - parseRule / paramMatches (glob) - dominates(deny, allow) -> DIS dead-allow (deny fully covers allow) - rulesIntersect(a, b) -> CNF cross-scope conflict (match sets intersect) DIS now delegates to dominates; conflict-detector :156 delegates to rulesIntersect. A bare deny still covers all params, so true positives are preserved (Bash deny + Bash(npm:*) allow still flagged). Re-seeded the marketplace-medium snapshots: the false-positive CA-DIS finding (Read(src/**) allow + Read(./.env) deny) is correctly gone. This changes snapshot CONTENT only — envelope schema is unchanged, so --json and --raw stay byte-stable. Full suite: 837/837 green (+25). self-audit PASS, A(100)/A(97).
394 lines
12 KiB
JSON
394 lines
12 KiB
JSON
{
|
|
"newFindings": [],
|
|
"resolvedFindings": [],
|
|
"unchangedFindings": [
|
|
{
|
|
"id": "CA-CML-001",
|
|
"scanner": "CML",
|
|
"severity": "low",
|
|
"title": "Missing recommended sections",
|
|
"description": "CLAUDE.md is missing: Project overview, Architecture",
|
|
"file": "/Users/ktg/repos/ktg-plugin-marketplace/config-audit/tests/fixtures/marketplace-medium/CLAUDE.md",
|
|
"line": null,
|
|
"evidence": "Present sections: Marketplace Medium, Plugins, Commands, Conventions",
|
|
"category": null,
|
|
"recommendation": "Add sections for: Project overview, Architecture",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-001",
|
|
"scanner": "GAP",
|
|
"severity": "medium",
|
|
"title": "No custom skills or commands",
|
|
"description": "Feature gap: No custom skills or commands. Create project-specific skills in .claude/skills/ or commands in .claude/commands/ to automate repetitive workflows.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t1",
|
|
"recommendation": "Create project-specific skills in .claude/skills/ or commands in .claude/commands/ to automate repetitive workflows.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-002",
|
|
"scanner": "GAP",
|
|
"severity": "low",
|
|
"title": "Settings only at one scope",
|
|
"description": "Feature gap: Settings only at one scope. Use all 3 settings scopes: ~/.claude/settings.json (user), .claude/settings.json (project), .claude/settings.local.json (local/personal).",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t2",
|
|
"recommendation": "Use all 3 settings scopes: ~/.claude/settings.json (user), .claude/settings.json (project), .claude/settings.local.json (local/personal).",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-003",
|
|
"scanner": "GAP",
|
|
"severity": "low",
|
|
"title": "No path-scoped rules",
|
|
"description": "Feature gap: No path-scoped rules. Create .claude/rules/*.md with paths: frontmatter to apply rules only to matching files.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t2",
|
|
"recommendation": "Create .claude/rules/*.md with paths: frontmatter to apply rules only to matching files.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-004",
|
|
"scanner": "GAP",
|
|
"severity": "low",
|
|
"title": "Low hook diversity",
|
|
"description": "Feature gap: Low hook diversity. Use hooks across 3+ events (e.g., SessionStart, PreToolUse, Stop) for comprehensive automation.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t2",
|
|
"recommendation": "Use hooks across 3+ events (e.g., SessionStart, PreToolUse, Stop) for comprehensive automation.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-005",
|
|
"scanner": "GAP",
|
|
"severity": "low",
|
|
"title": "No custom subagents",
|
|
"description": "Feature gap: No custom subagents. Create custom agents in .claude/agents/ or ~/.claude/agents/ with specialized tools and model selection.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t2",
|
|
"recommendation": "Create custom agents in .claude/agents/ or ~/.claude/agents/ with specialized tools and model selection.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-006",
|
|
"scanner": "GAP",
|
|
"severity": "low",
|
|
"title": "No model configuration",
|
|
"description": "Feature gap: No model configuration. Set model preferences in settings.json (model, modelOverrides) for cost/quality optimization.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t2",
|
|
"recommendation": "Set model preferences in settings.json (model, modelOverrides) for cost/quality optimization.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-007",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No status line configured",
|
|
"description": "Feature gap: No status line configured. Configure statusLine in settings.json to show context window usage, cost, and model info.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Configure statusLine in settings.json to show context window usage, cost, and model info.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-008",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No custom keybindings",
|
|
"description": "Feature gap: No custom keybindings. Create ~/.claude/keybindings.json to customize keyboard shortcuts (e.g., bind chat:newline to Shift+Enter).",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Create ~/.claude/keybindings.json to customize keyboard shortcuts (e.g., bind chat:newline to Shift+Enter).",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-009",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "Using default output style",
|
|
"description": "Feature gap: Using default output style. Try \"Explanatory\" or \"Learning\" output styles, or create custom styles in .claude/output-styles/.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Try \"Explanatory\" or \"Learning\" output styles, or create custom styles in .claude/output-styles/.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-010",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No worktree workflow",
|
|
"description": "Feature gap: No worktree workflow. Use --worktree for parallel feature development. Configure worktree.symlinkDirectories for node_modules.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Use --worktree for parallel feature development. Configure worktree.symlinkDirectories for node_modules.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-011",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No advanced skill frontmatter",
|
|
"description": "Feature gap: No advanced skill frontmatter. Use disable-model-invocation, context:fork, or argument-hint in skill frontmatter for better control.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Use disable-model-invocation, context:fork, or argument-hint in skill frontmatter for better control.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-012",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No subagent isolation",
|
|
"description": "Feature gap: No subagent isolation. Use isolation: worktree in agent frontmatter for safe parallel development.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Use isolation: worktree in agent frontmatter for safe parallel development.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-013",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No dynamic skill context",
|
|
"description": "Feature gap: No dynamic skill context. Use !`command` syntax in skills to inject dynamic context (e.g., !`git branch --show-current`).",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Use !`command` syntax in skills to inject dynamic context (e.g., !`git branch --show-current`).",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-014",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No autoMode classifier",
|
|
"description": "Feature gap: No autoMode classifier. Configure autoMode in user/local settings with environment context and allow/deny rules.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t3",
|
|
"recommendation": "Configure autoMode in user/local settings with environment context and allow/deny rules.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-015",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No custom plugin",
|
|
"description": "Feature gap: No custom plugin. Package reusable skills, agents, and hooks as a Claude Code plugin with .claude-plugin/plugin.json.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t4",
|
|
"recommendation": "Package reusable skills, agents, and hooks as a Claude Code plugin with .claude-plugin/plugin.json.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-016",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No managed settings",
|
|
"description": "Feature gap: No managed settings. Use managed-settings.json for organization-wide policy enforcement.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t4",
|
|
"recommendation": "Use managed-settings.json for organization-wide policy enforcement.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-GAP-017",
|
|
"scanner": "GAP",
|
|
"severity": "info",
|
|
"title": "No LSP plugins",
|
|
"description": "Feature gap: No LSP plugins. Add .lsp.json for real-time code intelligence from language servers.",
|
|
"file": null,
|
|
"line": null,
|
|
"evidence": null,
|
|
"category": "t4",
|
|
"recommendation": "Add .lsp.json for real-time code intelligence from language servers.",
|
|
"autoFixable": false
|
|
},
|
|
{
|
|
"id": "CA-TOK-001",
|
|
"scanner": "TOK",
|
|
"severity": "low",
|
|
"title": "High MCP tool-schema budget on server \"memory\"",
|
|
"description": "MCP server \"memory (.mcp.json)\" has tool count unknown — could not parse manifest or cached tools/list. Tool schemas load on every turn; an unverified server may be inflating the per-turn payload silently.",
|
|
"file": ".mcp.json",
|
|
"line": null,
|
|
"evidence": "tool_count=unknown; server=\"memory\"; source=\".mcp.json\" — severity reflects estimated tokens/turn based on structural heuristic; not measured against runtime telemetry",
|
|
"category": "token-efficiency",
|
|
"recommendation": "Install the package locally (so detect-mcp-tool-count can read its manifest), or run the server once and cache its tools/list response under ~/.claude/config-audit/mcp-cache/<name>.json. See knowledge/cache-telemetry-recipe.md.",
|
|
"autoFixable": false
|
|
}
|
|
],
|
|
"movedFindings": [],
|
|
"scoreChange": {
|
|
"before": {
|
|
"score": 92,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 92,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
"areaChanges": [
|
|
{
|
|
"name": "CLAUDE.md",
|
|
"before": {
|
|
"score": 90,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 90,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Settings",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Hooks",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Rules",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "MCP",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Imports",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Conflicts",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Feature Coverage",
|
|
"before": {
|
|
"score": 43,
|
|
"grade": "D"
|
|
},
|
|
"after": {
|
|
"score": 43,
|
|
"grade": "D"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Token Efficiency",
|
|
"before": {
|
|
"score": 90,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 90,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
},
|
|
{
|
|
"name": "Plugin Hygiene",
|
|
"before": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"after": {
|
|
"score": 100,
|
|
"grade": "A"
|
|
},
|
|
"delta": 0
|
|
}
|
|
],
|
|
"summary": {
|
|
"totalBefore": 19,
|
|
"totalAfter": 19,
|
|
"newCount": 0,
|
|
"resolvedCount": 0,
|
|
"trend": "stable"
|
|
}
|
|
}
|