test(voyage): extend plan-determinism.test.mjs — SC #10 forward-compat block

Step 19 of v4.1 — extend-in-place per brief Preferences. Three new test
blocks asserting forward-compat:

  1. Legacy fixtures (plan-run-A.md, plan-run-B.md) — without profile_used
     in frontmatter — still parse cleanly after manifest-yaml.mjs added
     OPTIONAL_STRING_KEYS.
  2. New fixtures (profile-plan-run-{economy,premium}-*.md) — with
     profile_used in frontmatter — parse cleanly with correct profile
     value extracted.
  3. Real v4.1 plan (.claude/projects/2026-05-08-voyage-v4.1-modellprofiler/plan.md)
     validates strict, emits no PLAN_VERSION_MISMATCH warning.

Tests: 475 pass + 2 skipped (Docker not installed).
This commit is contained in:
Kjell Tore Guttormsen 2026-05-09 10:00:08 +02:00
commit 93c6b82f62

View file

@ -61,3 +61,65 @@ test('plan determinism — no duplicate step titles within run', () => {
);
}
});
// --- v4.1 forward-compat block (SC #10) ---
//
// Adding the optional frontmatter key `profile_used` (Step 3 OPTIONAL_STRING_KEYS)
// must not break parsing of EITHER:
// - Existing plans WITHOUT profile_used (plan-run-A.md, plan-run-B.md)
// - New plans WITH profile_used (profile-plan-run-{economy,premium}-*.md)
//
// This is the forward-compat assertion required by Step 19. Extend-in-place
// keeps the determinism + forward-compat checks colocated.
test('plan determinism — forward-compat: legacy fixtures (no profile_used) parse cleanly', () => {
for (const rel of ['tests/synthetic/plan-run-A.md', 'tests/synthetic/plan-run-B.md']) {
const text = readFileSync(join(ROOT, rel), 'utf-8');
const doc = parseDocument(text);
assert.ok(doc.valid, `${rel}: frontmatter parse failed: ${(doc.errors || []).map((e) => e.message).join(', ')}`);
assert.equal(
doc.parsed.frontmatter.profile_used,
undefined,
`${rel}: legacy fixture must NOT have profile_used set`,
);
assert.ok(
Array.isArray(doc.parsed.frontmatter.steps),
`${rel}: steps array still loads after parser extension`,
);
}
});
test('plan determinism — forward-compat: new fixtures with profile_used parse cleanly', () => {
const cases = [
{ rel: 'tests/synthetic/profile-plan-run-economy-1.md', profile: 'economy' },
{ rel: 'tests/synthetic/profile-plan-run-economy-2.md', profile: 'economy' },
{ rel: 'tests/synthetic/profile-plan-run-premium-1.md', profile: 'premium' },
{ rel: 'tests/synthetic/profile-plan-run-premium-2.md', profile: 'premium' },
];
for (const { rel, profile } of cases) {
const text = readFileSync(join(ROOT, rel), 'utf-8');
const doc = parseDocument(text);
assert.ok(doc.valid, `${rel}: frontmatter parse failed: ${(doc.errors || []).map((e) => e.message).join(', ')}`);
assert.equal(
doc.parsed.frontmatter.profile_used,
profile,
`${rel}: profile_used must be ${profile}`,
);
assert.ok(
Array.isArray(doc.parsed.frontmatter.steps) && doc.parsed.frontmatter.steps.length >= 10,
`${rel}: steps array must be non-empty`,
);
}
});
test('plan determinism — forward-compat: real v4.1 plan validates with --strict (no PLAN_VERSION_MISMATCH)', async () => {
// Sanity check that adding profile_used to manifest-yaml schema doesn't
// regress full plan-validator strict-mode behaviour on a real plan that
// ships profile_used in step manifests.
const realPlan = '.claude/projects/2026-05-08-voyage-v4.1-modellprofiler/plan.md';
const { validatePlan } = await import('../../lib/validators/plan-validator.mjs');
const result = await validatePlan(join(ROOT, realPlan), { strict: true });
assert.equal(result.valid, true, `real plan must validate strict: ${JSON.stringify(result.errors)}`);
const versionMismatch = (result.warnings || []).find((w) => w.code === 'PLAN_VERSION_MISMATCH');
assert.equal(versionMismatch, undefined, 'real plan must NOT emit PLAN_VERSION_MISMATCH warning');
});