feat(voyage): add phase_signals validation + sequencing gate to brief-validator (v5.1)

plugins/voyage/tests/validators/brief-validator.test.mjs

@@ -152,3 +152,69 @@ test('validateBrief — wrong-type error message includes accepted set', () => {
   assert.ok(/trekbrief/.test(wrongType.message));
   assert.ok(/trekreview/.test(wrongType.message));
 });
+
+// --- v5.1 — phase_signals additive field + sequencing gate ---
+
+const SIGNALS_BLOCK = `phase_signals:
+  - phase: research
+    effort: standard
+  - phase: plan
+    effort: high
+    model: opus
+  - phase: execute
+    effort: low
+    model: sonnet
+  - phase: review
+    effort: standard
+`;
+
+test('validateBrief — v5.1 well-formed phase_signals accepted', () => {
+  const t = GOOD_BRIEF
+    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
+    .replace('source: interview\n', `source: interview\n${SIGNALS_BLOCK}`);
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, true, JSON.stringify(r.errors));
+});
+
+test('validateBrief — pre-v5.1 brief without phase_signals accepted (backward-compat)', () => {
+  const r = validateBriefContent(GOOD_BRIEF, { strict: true });
+  assert.equal(r.valid, true, JSON.stringify(r.errors));
+  assert.ok(!r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
+});
+
+test('validateBrief — v5.1+ brief missing phase_signals + partial emits BRIEF_V51_MISSING_SIGNALS', () => {
+  const t = GOOD_BRIEF.replace('brief_version: "2.0"', 'brief_version: "2.1"');
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, false);
+  assert.ok(r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
+});
+
+test('validateBrief — v5.1+ brief with phase_signals_partial: true accepted', () => {
+  const t = GOOD_BRIEF
+    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
+    .replace('source: interview\n', 'source: interview\nphase_signals_partial: true\n');
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, true, JSON.stringify(r.errors));
+});
+
+test('validateBrief — phase_signals + phase_signals_partial both set rejected (mutually exclusive)', () => {
+  const t = GOOD_BRIEF
+    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
+    .replace('source: interview\n', `source: interview\nphase_signals_partial: true\n${SIGNALS_BLOCK}`);
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, false);
+  assert.ok(r.errors.find(e => e.code === 'BRIEF_SIGNALS_MUTUALLY_EXCLUSIVE'));
+});
+
+test('validateBrief — phase_signals with unknown phase rejected', () => {
+  const BAD_SIGNALS = `phase_signals:
+  - phase: nonsense
+    effort: standard
+`;
+  const t = GOOD_BRIEF
+    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
+    .replace('source: interview\n', `source: interview\n${BAD_SIGNALS}`);
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, false);
+  assert.ok(r.errors.find(e => e.code === 'BRIEF_INVALID_PHASE_SIGNAL_PHASE'));
+});