open/ktg-plugin-marketplace
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity Actions

test(voyage): add annotation roundtrip + rollback + source_annotations integration — v4.2 Step 7

Browse source 
Implements SC2/SC3/SC5b/SC7 + additive-field invariant for the v4.2
annotation pipeline:

Fixtures (tests/fixtures/annotation/):
  - annotation-brief.md           — brief-validator-clean fixture
  - annotation-plan.md            — plan-validator-clean (2 steps)
  - annotation-review.md          — review-validator-clean
  - annotation-plan-large.md      — 51 steps (SC3 scale fixture)

Integration tests:
  - tests/integration/annotation-roundtrip.test.mjs — 7 cases:
    SC2 byte-identical empty round-trip across brief/plan/review,
    SC3 scale (51 steps + 100 anchors) round-trip,
    SC7 parseAnchors(stripAnchors(addAnchors(...))) === [] per target.
  - tests/integration/schema-rollback.test.mjs — 4 cases:
    SC5b validator-FAIL -> revisionGuard rolls back byte-identical
    (sha256 invariant) for brief/plan/review + cross-target sweep.
    .local.bak deleted on rollback path (validator-PASS path tested
    in lib/util/revision-guard tests).
  - tests/lib/source-annotations.test.mjs — 6 cases mirroring
    tests/lib/source-findings.test.mjs additive-field pattern: each
    validator (brief/plan/review) accepts source_annotations as
    additive-optional, parser extracts as array of dicts, entries
    conform to documented shape, baseline forward-compat (artifacts
    without source_annotations still validate).

Verify: node --test tests/integration/annotation-roundtrip.test.mjs
       tests/integration/schema-rollback.test.mjs
       tests/lib/source-annotations.test.mjs -> 17 pass / 0 fail.
Full npm test: 577 pass / 0 fail / 2 skipped (Docker).

Refs plan.md Step 7 + plan-critic M4 + plan-critic B4.
This commit is contained in:
Kjell Tore Guttormsen 2026-05-09 15:13:27 +02:00
commit c412f72605
7 changed files with 1732 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

32
plugins/voyage/tests/fixtures/annotation/annotation-review.md vendored Normal file
View file

@ -0,0 +1,32 @@
---
type: trekreview
review_version: "1.0"
task: Demo review for annotation round-trip
slug: annotation-review-demo
project_dir: .claude/projects/2026-05-09-annotation-demo
brief_path: .claude/projects/2026-05-09-annotation-demo/brief.md
scope_sha_end: 0000000000000000000000000000000000000000
reviewed_files_count: 0
findings: []
---
# Demo review for annotation round-trip
This fixture is used by `tests/integration/annotation-roundtrip.test.mjs`
to verify SC2 (byte-identical empty-anchor round-trip) and SC7 (per-target
isolation against `validateReview`).
## Executive Summary
Verdict: ALLOW. No findings. This is a synthetic fixture used to exercise
the round-trip mechanics; it does not represent a real review.
## Coverage
| File | Treatment |
|------|-----------|
| _none_ | _no diff_ |
## Remediation Summary
No remediation needed. ALLOW.