feat(ultraplan-local): add lib/review/rule-catalogue.mjs (12 rule keys)

plugins/ultraplan-local/tests/lib/rule-catalogue.test.mjs

@@ -0,0 +1,54 @@
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import {
+  RULE_CATALOGUE,
+  RULE_KEYS,
+  SEVERITY_VALUES,
+  CATEGORY_VALUES,
+  getRule,
+} from '../../lib/review/rule-catalogue.mjs';
+
+test('RULE_CATALOGUE — every entry has all 4 required fields', () => {
+  for (const entry of RULE_CATALOGUE) {
+    assert.ok(typeof entry.rule_key === 'string' && entry.rule_key.length > 0, `bad rule_key: ${entry.rule_key}`);
+    assert.ok(typeof entry.severity === 'string' && entry.severity.length > 0, `bad severity: ${entry.severity}`);
+    assert.ok(typeof entry.category === 'string' && entry.category.length > 0, `bad category: ${entry.category}`);
+    assert.ok(typeof entry.description === 'string' && entry.description.length > 0, `bad description for ${entry.rule_key}`);
+  }
+});
+
+test('RULE_CATALOGUE — no duplicate rule_key', () => {
+  const seen = new Set();
+  for (const entry of RULE_CATALOGUE) {
+    assert.ok(!seen.has(entry.rule_key), `duplicate rule_key: ${entry.rule_key}`);
+    seen.add(entry.rule_key);
+  }
+  assert.equal(seen.size, RULE_CATALOGUE.length);
+});
+
+test('RULE_CATALOGUE — all severity values within enum', () => {
+  for (const entry of RULE_CATALOGUE) {
+    assert.ok(SEVERITY_VALUES.includes(entry.severity), `${entry.rule_key} has invalid severity: ${entry.severity}`);
+  }
+});
+
+test('RULE_CATALOGUE — all category values within enum', () => {
+  for (const entry of RULE_CATALOGUE) {
+    assert.ok(CATEGORY_VALUES.includes(entry.category), `${entry.rule_key} has invalid category: ${entry.category}`);
+  }
+});
+
+test('RULE_KEYS.size === RULE_CATALOGUE.length (== 12) — pinned by doc-consistency', () => {
+  assert.equal(RULE_KEYS.size, RULE_CATALOGUE.length);
+  assert.equal(RULE_CATALOGUE.length, 12);
+});
+
+test('getRule — returns frozen entry on hit, null on miss, null on bad input', () => {
+  const hit = getRule('UNIMPLEMENTED_CRITERION');
+  assert.ok(hit !== null);
+  assert.equal(hit.severity, 'BLOCKER');
+  assert.throws(() => { hit.severity = 'MINOR'; }); // frozen
+  assert.equal(getRule('NOPE'), null);
+  assert.equal(getRule(undefined), null);
+  assert.equal(getRule(123), null);
+});