From f924d329b5b43d09f5cbff20ebf65213a71a8303 Mon Sep 17 00:00:00 2001 From: Kjell Tore Guttormsen Date: Tue, 5 May 2026 14:35:01 +0200 Subject: [PATCH] feat(voyage)!: FLAG_SCHEMA keys trek* + arg-parser test cases [skip-docs] - Rename FLAG_SCHEMA keys ultrabrief|ultraresearch|ultraplan|ultraexecute|ultrareview|ultracontinue -> trek* equivalents - Update 26 literal key references in tests/lib/arg-parser.test.mjs - Update parseArgs($ARGUMENTS, 'ultracontinue') -> 'trekcontinue' in commands/trekcontinue.md - trekendsession.md audited: no parseArgs invocation, no FLAG_SCHEMA entry needed Atomic per session-spec: schema + tests + consuming commands committed together to avoid vacuous-pass risk. Part of voyage-rebrand session 2 (W3.2 / Step 4). Co-Authored-By: Claude Opus 4.7 --- .../ultraplan-local/commands/trekcontinue.md | 2 +- .../lib/parsers/arg-parser.mjs | 12 ++--- .../tests/lib/arg-parser.test.mjs | 52 +++++++++---------- 3 files changed, 33 insertions(+), 33 deletions(-) diff --git a/plugins/ultraplan-local/commands/trekcontinue.md b/plugins/ultraplan-local/commands/trekcontinue.md index 9135cff..da4be56 100644 --- a/plugins/ultraplan-local/commands/trekcontinue.md +++ b/plugins/ultraplan-local/commands/trekcontinue.md @@ -30,7 +30,7 @@ See **Handover 7** in `docs/HANDOVER-CONTRACTS.md` for the full schema. ## Phase 0 — `--help` handling -Parse `$ARGUMENTS` with `parseArgs($ARGUMENTS, 'ultracontinue')` from +Parse `$ARGUMENTS` with `parseArgs($ARGUMENTS, 'trekcontinue')` from `lib/parsers/arg-parser.mjs`. Dispatch the usage block ONLY when one of these two conditions equals exactly true (no substring search, no "contains" check): diff --git a/plugins/ultraplan-local/lib/parsers/arg-parser.mjs b/plugins/ultraplan-local/lib/parsers/arg-parser.mjs index 550a43a..9913c3d 100644 --- a/plugins/ultraplan-local/lib/parsers/arg-parser.mjs +++ b/plugins/ultraplan-local/lib/parsers/arg-parser.mjs @@ -5,33 +5,33 @@ // produces an `unknown_flags` array but does not error — the caller decides. const FLAG_SCHEMA = { - ultrabrief: { + trekbrief: { boolean: ['--quick', '--fg'], valued: [], aliases: {}, }, - ultraresearch: { + trekresearch: { boolean: ['--quick', '--local', '--external', '--fg'], valued: ['--project'], aliases: {}, }, - ultraplan: { + trekplan: { boolean: ['--quick', '--fg'], valued: ['--project', '--brief', '--export', '--decompose'], multi: ['--research'], aliases: {}, }, - ultraexecute: { + trekexecute: { boolean: ['--resume', '--dry-run', '--validate', '--fg'], valued: ['--project', '--step', '--session'], aliases: {}, }, - ultrareview: { + trekreview: { boolean: ['--quick', '--fg', '--dry-run', '--validate'], valued: ['--project', '--since'], aliases: {}, }, - ultracontinue: { + trekcontinue: { boolean: ['--help', '--cleanup', '--confirm', '--dry-run'], valued: [], aliases: {}, diff --git a/plugins/ultraplan-local/tests/lib/arg-parser.test.mjs b/plugins/ultraplan-local/tests/lib/arg-parser.test.mjs index 6425252..4f3df97 100644 --- a/plugins/ultraplan-local/tests/lib/arg-parser.test.mjs +++ b/plugins/ultraplan-local/tests/lib/arg-parser.test.mjs @@ -3,71 +3,71 @@ import { strict as assert } from 'node:assert'; import { parseArgs } from '../../lib/parsers/arg-parser.mjs'; test('ultrabrief — empty args', () => { - const r = parseArgs('', 'ultrabrief'); - assert.equal(r.command, 'ultrabrief'); + const r = parseArgs('', 'trekbrief'); + assert.equal(r.command, 'trekbrief'); assert.deepEqual(r.flags, {}); }); test('ultrabrief — --quick boolean', () => { - const r = parseArgs('--quick', 'ultrabrief'); + const r = parseArgs('--quick', 'trekbrief'); assert.equal(r.flags['--quick'], true); }); test('ultraresearch — --project value capture', () => { - const r = parseArgs('--project .claude/projects/2026-04-30-foo', 'ultraresearch'); + const r = parseArgs('--project .claude/projects/2026-04-30-foo', 'trekresearch'); assert.equal(r.flags['--project'], '.claude/projects/2026-04-30-foo'); }); test('ultraresearch — --quick --local combined', () => { - const r = parseArgs('--quick --local', 'ultraresearch'); + const r = parseArgs('--quick --local', 'trekresearch'); assert.equal(r.flags['--quick'], true); assert.equal(r.flags['--local'], true); }); test('ultraplan — --research multi-value', () => { - const r = parseArgs('--research a.md b.md c.md', 'ultraplan'); + const r = parseArgs('--research a.md b.md c.md', 'trekplan'); assert.deepEqual(r.flags['--research'], ['a.md', 'b.md', 'c.md']); }); test('ultraplan — --research multi stops at next flag', () => { - const r = parseArgs('--research a.md b.md --project /x', 'ultraplan'); + const r = parseArgs('--research a.md b.md --project /x', 'trekplan'); assert.deepEqual(r.flags['--research'], ['a.md', 'b.md']); assert.equal(r.flags['--project'], '/x'); }); test('ultraplan — --brief required-value flag', () => { - const r = parseArgs('--brief brief.md', 'ultraplan'); + const r = parseArgs('--brief brief.md', 'trekplan'); assert.equal(r.flags['--brief'], 'brief.md'); }); test('ultraplan — missing value for --brief produces error', () => { - const r = parseArgs('--brief --quick', 'ultraplan'); + const r = parseArgs('--brief --quick', 'trekplan'); assert.ok(r.errors.find(e => e.code === 'ARG_MISSING_VALUE')); }); test('ultraplan — --decompose value flag', () => { - const r = parseArgs('--decompose plan.md', 'ultraplan'); + const r = parseArgs('--decompose plan.md', 'trekplan'); assert.equal(r.flags['--decompose'], 'plan.md'); }); test('ultraexecute — --resume + --project', () => { - const r = parseArgs('--resume --project /tmp/p', 'ultraexecute'); + const r = parseArgs('--resume --project /tmp/p', 'trekexecute'); assert.equal(r.flags['--resume'], true); assert.equal(r.flags['--project'], '/tmp/p'); }); test('ultraexecute — --step N value', () => { - const r = parseArgs('--step 3', 'ultraexecute'); + const r = parseArgs('--step 3', 'trekexecute'); assert.equal(r.flags['--step'], '3'); }); test('ultraexecute — unknown flag goes to unknown[]', () => { - const r = parseArgs('--mystery foo', 'ultraexecute'); + const r = parseArgs('--mystery foo', 'trekexecute'); assert.ok(r.unknown.includes('--mystery')); }); test('quoted positional with spaces preserved', () => { - const r = parseArgs('"hello world" simple', 'ultrabrief'); + const r = parseArgs('"hello world" simple', 'trekbrief'); assert.deepEqual(r.positional, ['hello world', 'simple']); }); @@ -77,64 +77,64 @@ test('unknown command reported as error', () => { }); test('ultrareview — --project value capture', () => { - const r = parseArgs('--project .claude/projects/2026-05-01-foo', 'ultrareview'); + const r = parseArgs('--project .claude/projects/2026-05-01-foo', 'trekreview'); assert.equal(r.flags['--project'], '.claude/projects/2026-05-01-foo'); }); test('ultrareview — --since value', () => { - const r = parseArgs('--since HEAD~5', 'ultrareview'); + const r = parseArgs('--since HEAD~5', 'trekreview'); assert.equal(r.flags['--since'], 'HEAD~5'); }); test('ultrareview — --quick + --validate combined', () => { - const r = parseArgs('--quick --validate', 'ultrareview'); + const r = parseArgs('--quick --validate', 'trekreview'); assert.equal(r.flags['--quick'], true); assert.equal(r.flags['--validate'], true); }); test('ultrareview — unknown flag goes to unknown[]', () => { - const r = parseArgs('--mystery foo', 'ultrareview'); + const r = parseArgs('--mystery foo', 'trekreview'); assert.ok(r.unknown.includes('--mystery')); }); test('ultracontinue — empty args produce no flags and no positional', () => { - const r = parseArgs('', 'ultracontinue'); - assert.equal(r.command, 'ultracontinue'); + const r = parseArgs('', 'trekcontinue'); + assert.equal(r.command, 'trekcontinue'); assert.deepEqual(r.flags, {}); assert.deepEqual(r.positional, []); assert.deepEqual(r.errors, []); }); test('ultracontinue — --help boolean flag', () => { - const r = parseArgs('--help', 'ultracontinue'); + const r = parseArgs('--help', 'trekcontinue'); assert.equal(r.flags['--help'], true); }); test('ultracontinue — -h treated as positional (no alias resolution)', () => { - const r = parseArgs('-h', 'ultracontinue'); + const r = parseArgs('-h', 'trekcontinue'); assert.deepEqual(r.positional, ['-h']); assert.deepEqual(r.errors, []); assert.equal(r.flags['--help'], undefined); }); test('ultracontinue — --cleanup boolean flag', () => { - const r = parseArgs('--cleanup', 'ultracontinue'); + const r = parseArgs('--cleanup', 'trekcontinue'); assert.equal(r.flags['--cleanup'], true); }); test('ultracontinue — --cleanup --confirm both flags', () => { - const r = parseArgs('--cleanup --confirm', 'ultracontinue'); + const r = parseArgs('--cleanup --confirm', 'trekcontinue'); assert.equal(r.flags['--cleanup'], true); assert.equal(r.flags['--confirm'], true); }); test('ultracontinue — positional project dir captured', () => { - const r = parseArgs('.claude/projects/2026-05-04-foo', 'ultracontinue'); + const r = parseArgs('.claude/projects/2026-05-04-foo', 'trekcontinue'); assert.deepEqual(r.positional, ['.claude/projects/2026-05-04-foo']); }); test('ultracontinue — .md positional accepted by parser (rejection is command-level)', () => { - const r = parseArgs('NEXT-SESSION-PROMPT.local.md', 'ultracontinue'); + const r = parseArgs('NEXT-SESSION-PROMPT.local.md', 'trekcontinue'); assert.deepEqual(r.positional, ['NEXT-SESSION-PROMPT.local.md']); assert.deepEqual(r.errors, []); });