Kjell Tore Guttormsen
7a90d348ad
Session 5 of voyage-rebrand (V6). Operator-authorized cross-plugin scope. - git mv plugins/ultraplan-local plugins/voyage (rename detected, history preserved) - .claude-plugin/marketplace.json: voyage entry replaces ultraplan-local - CLAUDE.md: voyage row in plugin list, voyage in design-system consumer list - README.md: bulk rename ultra*-local commands -> trek* commands; ultraplan-local refs -> voyage; type discriminators (type: trekbrief/trekreview); session-title pattern (voyage:<command>:<slug>); v4.0.0 release-note paragraph - plugins/voyage/.claude-plugin/plugin.json: homepage/repository URLs point to monorepo voyage path - plugins/voyage/verify.sh: drop URL whitelist exception (no longer needed) Closes voyage-rebrand. bash plugins/voyage/verify.sh PASS 7/7. npm test 361/361.
59 lines
2.6 KiB
JavaScript
59 lines
2.6 KiB
JavaScript
import { test } from 'node:test';
|
|
import { strict as assert } from 'node:assert';
|
|
import { computeFindingId, parseFindingId } from '../../lib/parsers/finding-id.mjs';
|
|
|
|
test('computeFindingId — deterministic on same inputs', () => {
|
|
const a = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
const b = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
assert.equal(a, b);
|
|
});
|
|
|
|
test('computeFindingId — different file → different ID', () => {
|
|
const a = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
const b = computeFindingId('lib/bar.mjs', 42, 'MISSING_TEST');
|
|
assert.notEqual(a, b);
|
|
});
|
|
|
|
test('computeFindingId — different line → different ID', () => {
|
|
const a = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
const b = computeFindingId('lib/foo.mjs', 43, 'MISSING_TEST');
|
|
assert.notEqual(a, b);
|
|
});
|
|
|
|
test('computeFindingId — different rule_key → different ID', () => {
|
|
const a = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
const b = computeFindingId('lib/foo.mjs', 42, 'MISSING_BRIEF_REF');
|
|
assert.notEqual(a, b);
|
|
});
|
|
|
|
test('computeFindingId — output is 40-char lowercase hex', () => {
|
|
const id = computeFindingId('lib/foo.mjs', 42, 'MISSING_TEST');
|
|
assert.match(id, /^[0-9a-f]{40}$/);
|
|
});
|
|
|
|
test('computeFindingId — throws TypeError on null/undefined/empty inputs', () => {
|
|
assert.throws(() => computeFindingId(null, 1, 'X'), TypeError);
|
|
assert.throws(() => computeFindingId('', 1, 'X'), TypeError);
|
|
assert.throws(() => computeFindingId('a', null, 'X'), TypeError);
|
|
assert.throws(() => computeFindingId('a', undefined, 'X'), TypeError);
|
|
assert.throws(() => computeFindingId('a', '', 'X'), TypeError);
|
|
assert.throws(() => computeFindingId('a', 1, ''), TypeError);
|
|
assert.throws(() => computeFindingId('a', 1, null), TypeError);
|
|
assert.throws(() => computeFindingId('a', NaN, 'X'), TypeError);
|
|
});
|
|
|
|
test('parseFindingId — valid 40-char hex returns valid:true', () => {
|
|
const id = computeFindingId('a', 1, 'X');
|
|
assert.equal(parseFindingId(id).valid, true);
|
|
});
|
|
|
|
test('parseFindingId — bad input returns valid:false (no throw)', () => {
|
|
assert.equal(parseFindingId('').valid, false);
|
|
assert.equal(parseFindingId('xyz').valid, false);
|
|
assert.equal(parseFindingId('A'.repeat(40)).valid, false); // uppercase rejected
|
|
assert.equal(parseFindingId('0'.repeat(39)).valid, false); // too short
|
|
assert.equal(parseFindingId('0'.repeat(41)).valid, false); // too long
|
|
assert.equal(parseFindingId(null).valid, false);
|
|
assert.equal(parseFindingId(undefined).valid, false);
|
|
assert.equal(parseFindingId(42).valid, false);
|
|
});
|