New policy-loader.mjs reads .llm-security/policy.json with deep-merge against defaults that exactly match existing hardcoded values. Integrated into all 7 hooks: - pre-prompt-inject-scan: injection.mode (env var still takes precedence) - post-session-guard: trifecta.mode, window_size, long_horizon_window - pre-edit-secrets: secrets.additional_patterns - pre-bash-destructive: destructive.additional_blocked - pre-write-pathguard: pathguard.additional_protected - pre-install-supply-chain: supply_chain.additional_blocked_packages - post-mcp-verify: mcp.volume_threshold_bytes, mcp.trusted_servers Backward compatible: no policy file = identical behavior to v5.1.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
103 lines
3.8 KiB
JavaScript
103 lines
3.8 KiB
JavaScript
// policy-loader.test.mjs — Tests for policy-as-code loader
|
|
|
|
import { describe, it, beforeEach, afterEach } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { writeFileSync, mkdirSync, rmSync, existsSync } from 'node:fs';
|
|
import { join } from 'node:path';
|
|
import { tmpdir } from 'node:os';
|
|
import { loadPolicy, getPolicyValue, getDefaultPolicy, _resetCacheForTest } from '../../scanners/lib/policy-loader.mjs';
|
|
|
|
const TEST_ROOT = join(tmpdir(), `llm-security-policy-test-${Date.now()}`);
|
|
const POLICY_DIR = join(TEST_ROOT, '.llm-security');
|
|
const POLICY_FILE = join(POLICY_DIR, 'policy.json');
|
|
|
|
describe('policy-loader', () => {
|
|
beforeEach(() => {
|
|
_resetCacheForTest();
|
|
mkdirSync(POLICY_DIR, { recursive: true });
|
|
});
|
|
|
|
afterEach(() => {
|
|
_resetCacheForTest();
|
|
try { rmSync(TEST_ROOT, { recursive: true }); } catch {}
|
|
});
|
|
|
|
it('returns defaults when no policy file exists', () => {
|
|
rmSync(POLICY_FILE, { force: true });
|
|
const policy = loadPolicy(TEST_ROOT);
|
|
assert.equal(policy.version, '1.0');
|
|
assert.equal(policy.injection.mode, 'block');
|
|
assert.equal(policy.trifecta.mode, 'warn');
|
|
assert.equal(policy.trifecta.window_size, 20);
|
|
});
|
|
|
|
it('reads and merges valid policy file', () => {
|
|
writeFileSync(POLICY_FILE, JSON.stringify({
|
|
version: '1.0',
|
|
trifecta: { mode: 'off' },
|
|
}));
|
|
const policy = loadPolicy(TEST_ROOT);
|
|
assert.equal(policy.trifecta.mode, 'off');
|
|
// Other defaults preserved
|
|
assert.equal(policy.trifecta.window_size, 20);
|
|
assert.equal(policy.injection.mode, 'block');
|
|
});
|
|
|
|
it('handles partial policy (deep merge preserves defaults)', () => {
|
|
writeFileSync(POLICY_FILE, JSON.stringify({
|
|
secrets: { additional_patterns: ['CUSTOM_SECRET=\\w+'] },
|
|
}));
|
|
const policy = loadPolicy(TEST_ROOT);
|
|
assert.deepEqual(policy.secrets.additional_patterns, ['CUSTOM_SECRET=\\w+']);
|
|
assert.deepEqual(policy.secrets.allowed_paths, []); // default preserved
|
|
});
|
|
|
|
it('caches policy per root', () => {
|
|
writeFileSync(POLICY_FILE, JSON.stringify({ trifecta: { mode: 'block' } }));
|
|
const p1 = loadPolicy(TEST_ROOT);
|
|
// Modify file — should still return cached
|
|
writeFileSync(POLICY_FILE, JSON.stringify({ trifecta: { mode: 'off' } }));
|
|
const p2 = loadPolicy(TEST_ROOT);
|
|
assert.equal(p1, p2); // same reference (cached)
|
|
assert.equal(p2.trifecta.mode, 'block'); // original value
|
|
});
|
|
|
|
it('getPolicyValue returns correct values', () => {
|
|
writeFileSync(POLICY_FILE, JSON.stringify({
|
|
mcp: { volume_threshold_bytes: 500_000 },
|
|
}));
|
|
const val = getPolicyValue('mcp', 'volume_threshold_bytes', 100_000, TEST_ROOT);
|
|
assert.equal(val, 500_000);
|
|
});
|
|
|
|
it('getPolicyValue returns default when key not in policy', () => {
|
|
writeFileSync(POLICY_FILE, JSON.stringify({ version: '1.0' }));
|
|
const val = getPolicyValue('mcp', 'nonexistent_key', 42, TEST_ROOT);
|
|
assert.equal(val, 42);
|
|
});
|
|
|
|
it('handles invalid JSON gracefully', () => {
|
|
writeFileSync(POLICY_FILE, 'not valid json!!!');
|
|
const policy = loadPolicy(TEST_ROOT);
|
|
// Should return defaults without crashing
|
|
assert.equal(policy.version, '1.0');
|
|
assert.equal(policy.injection.mode, 'block');
|
|
});
|
|
|
|
it('getDefaultPolicy returns a copy', () => {
|
|
const d1 = getDefaultPolicy();
|
|
const d2 = getDefaultPolicy();
|
|
assert.deepEqual(d1, d2);
|
|
assert.notEqual(d1, d2); // different references
|
|
});
|
|
|
|
it('default policy matches existing hardcoded values', () => {
|
|
const defaults = getDefaultPolicy();
|
|
// These must match the hardcoded values in hooks
|
|
assert.equal(defaults.injection.mode, 'block');
|
|
assert.equal(defaults.trifecta.mode, 'warn');
|
|
assert.equal(defaults.trifecta.window_size, 20);
|
|
assert.equal(defaults.trifecta.long_horizon_window, 100);
|
|
assert.equal(defaults.mcp.volume_threshold_bytes, 100_000);
|
|
});
|
|
});
|