Lift okr's reference okf-check.mjs into the catalog as the single cross-plugin acceptance gate for the OKF-compatible second-brain form (spec §3): - scripts/okf-check.mjs (+ vendored okf-frontmatter.mjs): verdict logic byte-identical to okr's reference impl, English output, zero deps, self-contained. - scripts/okf-check.test.mjs: 5 self-contained tests (temp-dir bundles). - spec §7 + §14: the shared checker now lives here; only TS/mjs reconciliation remains Stage-3, not required for the gate. log.md protocol §6: conformance is verified by the gate, not asserted — a plugin moves to 🟢 only after passing it. Verified: 33/33 catalog tests green (canonical glob form); verdict parity with okr's checker on okr fixtures (positive + negative missing-type); a scaffolded linkedin-studio brain/ validates clean (exit 0). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012GqEHp4uDiivfrAUjw4BdE
104 lines
3.8 KiB
JavaScript
104 lines
3.8 KiB
JavaScript
// Tests for the shared OKF conformance checker (the cross-plugin acceptance gate).
|
|
// Self-contained: builds tiny bundles in a temp dir, so the test has no dependency
|
|
// on any sibling repo's fixtures. okf-check is run as a subprocess to capture the
|
|
// exit code (the contract). Zero npm deps. Style mirrors check-versions.test.mjs.
|
|
import { test } from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { execFileSync } from 'node:child_process';
|
|
import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join, dirname } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { checkBundle } from './okf-check.mjs';
|
|
|
|
const HERE = dirname(fileURLToPath(import.meta.url));
|
|
const CHECK = join(HERE, 'okf-check.mjs');
|
|
|
|
function tmpRoot() {
|
|
return mkdtempSync(join(tmpdir(), 'okf-catalog-'));
|
|
}
|
|
|
|
// Run okf-check as a subprocess; capture non-zero exit (execFileSync throws then).
|
|
function runCheck(root) {
|
|
try {
|
|
const stdout = execFileSync('node', [CHECK, root], { encoding: 'utf8' });
|
|
return { status: 0, stdout };
|
|
} catch (e) {
|
|
return { status: e.status ?? 1, stdout: `${e.stdout || ''}${e.stderr || ''}` };
|
|
}
|
|
}
|
|
|
|
// A minimal conforming bundle: root index.md with okf_version + one fully-typed concept.
|
|
function writeValidBundle(dir) {
|
|
writeFileSync(join(dir, 'index.md'), 'okf_version: 0.1\n\n# Bundle\n');
|
|
writeFileSync(
|
|
join(dir, 'profile.md'),
|
|
'---\ntype: Profile\ntitle: User profile\ndescription: The user.\nresource: about\ntimestamp: 2026-06-29\n---\n# Profile\n',
|
|
);
|
|
}
|
|
|
|
test('valid bundle (every concept has type:) -> exit 0, "0 files without type:"', () => {
|
|
const dir = tmpRoot();
|
|
try {
|
|
writeValidBundle(dir);
|
|
const { status, stdout } = runCheck(dir);
|
|
assert.equal(status, 0, 'a valid bundle should exit 0');
|
|
assert.match(stdout, /0 files without type:/);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('concept file without type: -> exit != 0 + count > 0 + names the file', () => {
|
|
const dir = tmpRoot();
|
|
try {
|
|
writeValidBundle(dir);
|
|
writeFileSync(
|
|
join(dir, 'no-type.md'),
|
|
'---\ntitle: Untyped\ndescription: A concept file missing the required type.\n---\n# Untyped\n',
|
|
);
|
|
const { status, stdout } = runCheck(dir);
|
|
assert.notEqual(status, 0, 'a type-less file should exit != 0');
|
|
assert.match(stdout, /[1-9]\d* files without type:/);
|
|
assert.match(stdout, /no-type\.md/);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('echoes okf_version from the root index.md', () => {
|
|
const dir = tmpRoot();
|
|
try {
|
|
writeValidBundle(dir);
|
|
const { stdout } = runCheck(dir);
|
|
assert.match(stdout, /okf_version:\s*0\.1/);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('index.md is exempt from the type requirement (sub-levels included)', () => {
|
|
const dir = tmpRoot();
|
|
try {
|
|
writeValidBundle(dir);
|
|
mkdirSync(join(dir, 'journal'));
|
|
writeFileSync(join(dir, 'journal', 'index.md'), '# Journal\n'); // no frontmatter, must not fail
|
|
const { status } = runCheck(dir);
|
|
assert.equal(status, 0, 'index.md must not be treated as a concept file');
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
test('checkBundle(): recommended-field gaps are warnings, not failures', () => {
|
|
const dir = tmpRoot();
|
|
try {
|
|
writeFileSync(join(dir, 'index.md'), 'okf_version: 0.1\n');
|
|
writeFileSync(join(dir, 'bare.md'), '---\ntype: Note\n---\n# Bare\n'); // type only
|
|
const r = checkBundle(dir);
|
|
assert.equal(r.missingType.length, 0, 'type present -> not a failure');
|
|
assert.ok(r.warnings.length >= 1, 'missing recommended fields -> warnings');
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|