feat(linkedin-studio): RE-R2a — item→store capture bridge + publishedAt persistence (schema v1→v2, lossless migrate) [skip-docs]
Closes the research-engine capture loop RE-R1 deferred:
- itemToInput(item, capturedAt): pure envelope→TrendInput bridge in item.ts —
injects capturedAt, carries publishedAt verbatim; no id, no re-validate
- publishedAt persisted: TrendRecord/TrendInput gain it; addTrend conditional-spread,
first-sight kept on re-capture (no back-fill). SCHEMA_VERSION 1→2 with a lossless
forward migrate-on-load: Math.max(onDisk, current) + numeric-typeof coercion
(string/NaN/absent → current; non-array trends coercion preserved verbatim)
- `capture` CLI: stdin raw item|batch → normalize → bridge → addTrend → saveStore once;
tally {added,duplicates,merged,errors} from AddResult; content-invalid → errors[],
exit 2 only on bad stdin; --json summary
- wiring: trend-spotter.md Step 4.5 N×`add` → one normalizing `capture` batch; README
add/capture framing corrected; test-runner Section 16h (capture wiring, unconditional)
+ floors bumped (trends 62→79, ASSERT 87→90)
TDD: 17 new tests (12 genuinely-RED logic-RED + 5 regression guards), tsc clean,
gate 105/0/0. No version bump (additive, v0.5.2 dev).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VmHCQjJHUyWwxGAVVjNLgp
This commit is contained in:
parent
b4e500fad4
commit
7a158030b6
10 changed files with 465 additions and 31 deletions
|
|
@ -40,8 +40,10 @@
|
|||
# reconcileRecentPosts by literal name, with a non-vacuity self-test) in Section 16f;
|
||||
# the trends-scorer wiring guard (RE-R1: scripts/trends/src/score.ts encodes both mode
|
||||
# weight-sets AND agents/trend-spotter.md references the scorer CLI 'src/cli.ts score',
|
||||
# with a non-vacuity self-test) in Section 16g; the assertion-count anti-erosion floor
|
||||
# (SC6) in Section 18. All are live below (Sections 8–18).
|
||||
# with a non-vacuity self-test) in Section 16g; the trends-capture wiring guard (RE-R2a:
|
||||
# scripts/trends/src/cli.ts dispatches `capture` AND agents/trend-spotter.md references the
|
||||
# capture CLI 'src/cli.ts capture', with a non-vacuity self-test) in Section 16h; the
|
||||
# assertion-count anti-erosion floor (SC6) in Section 18. All are live below (Sections 8–18).
|
||||
#
|
||||
# Usage: bash scripts/test-runner.sh
|
||||
# bash 3.2-safe: plain arrays only, no `declare -A`, no `mapfile`/`readarray`.
|
||||
|
|
@ -692,7 +694,7 @@ if [ -x "$TR_DIR/node_modules/.bin/tsx" ]; then
|
|||
TR_OUT=$( set +e; (cd "$TR_DIR" && npm test) 2>&1; echo "TR_EXIT:$?" )
|
||||
TR_EXIT=$(echo "$TR_OUT" | grep -oE 'TR_EXIT:[0-9]+' | grep -oE '[0-9]+' | head -1)
|
||||
TR_TESTS=$(echo "$TR_OUT" | grep -oE 'tests [0-9]+' | grep -oE '[0-9]+' | tail -1)
|
||||
TRENDS_TESTS_FLOOR=62 # store 24 + RE-R1: item 18 + score 16 + cli 4 (item-schema + triage-scorer)
|
||||
TRENDS_TESTS_FLOOR=79 # store 24 + RE-R1: item 18 + score 16 + cli 4 + RE-R2a: store +9 + item +4 + cli +4 (capture bridge + publishedAt)
|
||||
if [ "$TR_EXIT" = "0" ] && [ -n "$TR_TESTS" ] && [ "$TR_TESTS" -ge "$TRENDS_TESTS_FLOOR" ]; then
|
||||
pass "trends-store suite green: $TR_TESTS tests pass (floor $TRENDS_TESTS_FLOOR)"
|
||||
else
|
||||
|
|
@ -1069,6 +1071,50 @@ fi
|
|||
|
||||
echo ""
|
||||
|
||||
# --- Section 16h: Trends Capture Wiring (research-engine RE-R2a) ---
|
||||
echo "--- Trends Capture Wiring ---"
|
||||
|
||||
# RE-R2a closes the capture loop: the item->store bridge (itemToInput) + a `capture` CLI that
|
||||
# normalizes a raw batch from stdin and folds it into the store (persisting publishedAt). Two
|
||||
# literals must hold, grepped EXACT (grep -F), deps-absent-safe (pure grep, no tsx):
|
||||
# (1) cli.ts dispatches the `capture` subcommand (the handler exists), by the literal
|
||||
# 'command === "capture"' (the capture path is real, not merely documented);
|
||||
# (2) agents/trend-spotter.md re-points Step 4.5 to the capture CLI by the literal
|
||||
# 'src/cli.ts capture' (one normalizing batch call, replacing the N x `add` block).
|
||||
# Non-vacuity self-test mirrors Sections 16c-16g: the wiring predicate must accept a probe
|
||||
# carrying the capture-pointer literal and reject one without it. Labelled 16h but placed after
|
||||
# Section 17 / before Section 18 (anti-erosion must run last so it sees every prior check).
|
||||
# UNCONDITIONAL (no tsx) -> counts toward ASSERT_BASELINE_FLOOR.
|
||||
CAPTURE_HANDLER_LIT='command === "capture"'
|
||||
CAPTURE_WIRE_LIT='src/cli.ts capture'
|
||||
|
||||
H16_SELFTEST_OK=1
|
||||
if ! echo 'pipe the raw batch to src/cli.ts capture for the store fold' | grep -qF "$CAPTURE_WIRE_LIT"; then
|
||||
H16_SELFTEST_OK=0; echo " non-vacuity FAIL: a wired capture-pointer probe was not detected"
|
||||
fi
|
||||
if echo 'the agent folds each trend into the store itself' | grep -qF "$CAPTURE_WIRE_LIT"; then
|
||||
H16_SELFTEST_OK=0; echo " false-positive FAIL: an unwired probe matched the capture pointer"
|
||||
fi
|
||||
if [ "$H16_SELFTEST_OK" -eq 1 ]; then
|
||||
pass "trends-capture self-test: capture-pointer predicate detects wiring, rejects the under-wired form"
|
||||
else
|
||||
fail "trends-capture self-test failed — the capture-wiring lint is vacuous or over-eager"
|
||||
fi
|
||||
|
||||
if grep -qF "$CAPTURE_HANDLER_LIT" scripts/trends/src/cli.ts; then
|
||||
pass "cli.ts dispatches the capture subcommand ('$CAPTURE_HANDLER_LIT')"
|
||||
else
|
||||
fail "cli.ts has no capture handler — add a '$CAPTURE_HANDLER_LIT' branch (RE-R2a capture loop)"
|
||||
fi
|
||||
|
||||
if grep -qF "$CAPTURE_WIRE_LIT" agents/trend-spotter.md; then
|
||||
pass "trend-spotter.md references the capture CLI ('$CAPTURE_WIRE_LIT') as the Step 4.5 store-fold owner"
|
||||
else
|
||||
fail "trend-spotter.md does not reference the capture CLI — re-point Step 4.5 to a '$CAPTURE_WIRE_LIT' batch call (RE-R2a wiring)"
|
||||
fi
|
||||
|
||||
echo ""
|
||||
|
||||
# --- Section 18: Assertion-Count Anti-Erosion (SC6) ---
|
||||
# The lint self-modifies its own checks, so a green run could mask a silently dropped
|
||||
# assertion. Pin the total pass()+fail() invocations as a monotonic floor; the count
|
||||
|
|
@ -1080,12 +1126,14 @@ echo ""
|
|||
# checks (ops-reader self-test + strategy-advisor ops-wiring grep) = 82; +2 for SB-S3e's
|
||||
# two UNCONDITIONAL Section-16f checks (reconcile self-test + brain-CLI reconcile grep) = 84;
|
||||
# +3 for RE-R1's three UNCONDITIONAL Section-16g checks (trends-scorer self-test + score.ts
|
||||
# both-modes weight-set grep + trend-spotter scorer-pointer grep) = 87.
|
||||
# both-modes weight-set grep + trend-spotter scorer-pointer grep) = 87; +3 for RE-R2a's three
|
||||
# UNCONDITIONAL Section-16h checks (trends-capture self-test + cli.ts capture-handler grep +
|
||||
# trend-spotter capture-pointer grep) = 90.
|
||||
# NB: the floor tracks the deps-absent MINIMUM (conditional TS suites warn-skip and drop
|
||||
# the count), so it is bumped only by UNCONDITIONAL new checks — NOT pinned to the
|
||||
# deps-present TOTAL_CHECKS (that would zero the warn-skip margin and false-fail a fresh
|
||||
# clone). Runs last so TOTAL_CHECKS sees every prior check.
|
||||
ASSERT_BASELINE_FLOOR=87
|
||||
ASSERT_BASELINE_FLOOR=90
|
||||
TOTAL_CHECKS=$((PASS + FAIL))
|
||||
if [ "$TOTAL_CHECKS" -ge "$ASSERT_BASELINE_FLOOR" ]; then
|
||||
pass "assertion-count anti-erosion: $TOTAL_CHECKS checks >= baseline floor $ASSERT_BASELINE_FLOOR"
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue