open/linkedin-studio
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity Actions

docs(linkedin-studio): OKF trinn D-review — korriger avkreftede R5-påstander

Browse source 
Trinn D-review besvart i _okf-interim (postkasse, ikke tracked her).
Verifisering mot egen kode avkreftet to påstander i plan §4 R5:

- Ingen stabile err.code i noen av de fire CLI-ene (fritekst-Error +
  numerisk process.exit). err.code er et krav TIL biblioteket, ikke en
  disiplin vi speiler.
- "Nøyaktig én avsluttende newline" er ikke vår invariant;
  serializePublishedRecord utelater den bevisst for byte-eksakt
  round-trip (SC2). Delt fixture-korpus må bære et verbatim,
  ikke-normalisert tilfelle.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019uzhvLjCm39mNQXVFwG7w2
This commit is contained in:
Kjell Tore Guttormsen 2026-07-20 09:31:57 +02:00
commit fa5c8cf35a
1 changed files with 16 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

20
docs/okf-ingestion/plan.md
View file

@ -121,10 +121,22 @@ specifics-bank) all independently converged on `sha256(...)[:12]`; the pattern i
**R5 (phase 4, Node half) — contract parity details.** Stable string error codes on the error object
(the Python half's `exc.code` discipline, mirrored so Node consumers assert on `err.code`, never on message
text); zero runtime dependencies; ESM with `node:` prefixes; LF-only output with exactly one trailing
newline; and the golden-fixture set shared across both halves so byte-identity is the test, not the
promise. Our packages already meet the zero-dep/ESM/LF conventions (sole exception: `scripts/analytics`
depends on `csv-parse`), so parity is cheap on our side.
text); zero runtime dependencies; ESM with `node:` prefixes; and the golden-fixture set shared across both
halves so byte-identity is the test, not the promise.
> **Correction, 2026-07-20 (trinn D-review).** An earlier revision of this section claimed we "already meet
> the zero-dep/ESM/LF conventions". Verified against the code, two parts of that were false:
>
> - **We have no stable error codes.** None of the four CLIs set a machine-readable code; every failure is a
> free-text `Error` plus a numeric `process.exit` (`scripts/brain/src/ingest.ts:99,:113`,
> `scripts/trends/src/cli.ts:125,:255`). `err.code` is an ask *of* the library, not a discipline we mirror.
> - **"Exactly one trailing newline" is not our invariant, and must not become the library's.** Nothing
> asserts it here, and `serializePublishedRecord` deliberately omits it (`scripts/brain/src/ingest.ts:71`)
> because the record must end on the verbatim body or the byte-exact round-trip (SC2, §5) breaks. A shared
> fixture corpus therefore has to carry a *verbatim, non-normalized* case; a corpus where every valid
> output ends in one newline encodes normalization as contract and tests byte-identity away.
>
> Zero-dep/ESM does hold (sole exception: `scripts/analytics` depends on `csv-parse`).
## 5. What must never move here