open/llm-ingestion-okf
1
0
Fork 0
Code Issues Releases 4 Activity

test(golden): a clean extract is not a checkout, and says so

Browse source 
`test_the_four_existing_goldens_are_untouched` ran `git status` with
`check=True` in a `git archive` extract and raised `CalledProcessError`.
Measured 2026-09-19 it was the single failure of the whole suite run from
a clean extract -- twice reported as a round's one failure, twice by a
round that had not touched the file.

Both arms measure the CHECKOUT with `git`, so an extract has nothing to
ask. It skips with the reason stated, never silently: a checkout still
has to answer. Reproduced before and after on a non-repository copy --
`CalledProcessError` -> `SKIPPED [1] ... not a git checkout`.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-09-19 19:19:34 +02:00
commit 6d7dc7a660
Signed by: ktg
SSH key fingerprint: SHA256:JakMjO6FTBBzN0Bhfj9saOoEjaFxlSdYuZQQpM/lF9Q
1 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
tests/test_segmented_golden.py
View file

@ -22,6 +22,8 @@ import json
import subprocess
from pathlib import Path
import pytest
from llm_ingestion_okf.inbox import GateDecision, process_inbox
from llm_ingestion_okf.profiles import SEGMENTED_V1
from llm_ingestion_okf.segmentation import parse_segmentation_plan
@ -89,6 +91,14 @@ def test_the_four_existing_goldens_are_untouched() -> None:
# Measured against the baseline commit, not asserted. `git status` covers
# an uncommitted edit; `git diff` against the baseline covers a committed
# one -- and this voyage makes commits, so the second is the one that bites.
if not (Path(__file__).resolve().parents[1] / ".git").exists():
# A `git archive` extract is not a repository, so BOTH arms below have
# nothing to ask: each measures the CHECKOUT with `git`, and there is
# none. Measured 2026-09-19, this was the single failure of the whole
# suite run from a clean extract, and it read as a defect in whichever
# round happened to be under review. Stated rather than silent -- an
# extract cannot answer the question, and a checkout still must.
pytest.skip("not a git checkout: the goldens can only be compared inside one")
baseline = (
Path(__file__).resolve().parents[1]
/ ".claude/projects/2026-08-30-door-b-concept-granularity/baseline/sha"