feat(cli,consume): the first span, and the fusion that punished fine-graining
Round 6 left two things behind: a measured coverage hole with the repair built
but not the number to move it, and a retrieval regression that kept two
spreadsheet rules off the default. Both are measured; four defaults move.
THE HOLE IS BIGGER THAN THE RULE BUILT FOR IT. Measured over the 39-document
corpus, the pre-move default left 207 435 characters -- 11.92 % -- in no
segment: 163 804 above the first entry, 26 041 between entries, 17 590 after
the last. `--first-span-from-zero` closes the first part entirely, 79 % of the
whole, leaving 43 631 (2.51 %) over 8 of 32 documents. It adds no boundary and
the K2 concept count is identical with and without it (425 = 425); hit@8 holds
[1,1,1,1,1,-] under both tie-breaks and the 12-position reference does not move
one cell.
THE RANKER WAS PUNISHING FINE-GRAINING FOR BEING FINE-GRAINED. Round 6 held
`--sheet-section-rows --keep-table-heading` back because on a bundle built with
them row 1 fell rank 1 -> 2, and ruled out the document prior because its rank
over 39 DOCUMENTS was 1 on both bundles. RRF reads a rank over CONCEPTS:
splitting the gold document 1 -> 12 puts its own twelve concepts in that
signal's whole top tie group, so the one leading the body signal takes position
11, contributing 1/71 where the undivided concept contributed 1/61. A signal
that scored them all EQUALLY still emitted twelve ranks, ordered by concept_id,
and the fusion read alphabetical order as a measurement.
AND THE REPAIR WAS ALREADY IN THE TREE, OFF FOR A COST THAT HAD BEEN REMOVED.
`--tie-shared-rank` shipped off 2026-09-08 because hit@8 fell 5 of 6 to 4 of 6.
Swept over 2 prior exponents x 3 bundles x 6 rows: that fall exists only at
DOCUMENT_PRIOR_EXPONENT 1.0. Round 6 moved the exponent to 0.5 for an unrelated
reason and correctly reported it moved no hit@8 row -- nobody measured the
pair. A flag's "off by measurement" is a measurement of a CONFIGURATION, not a
property of the flag.
Shipped, each with an explicit opt-out and both directions measured rather than
asserted: --no-first-span-from-zero --no-sheet-section-rows
--no-keep-table-heading reproduces the previous bundle byte for byte (diff -rq,
0 differences), and the no-flag build equals the explicit-flag build.
--no-tie-shared-rank reproduces the previous excerpt order -- the one change
here that alters a payload with no bundle changing.
K2 default: 436 concepts / 832 files, digest 8dff8a8e6c15d2f7..., hit@8 5 of 6
ranks [1,1,1,1,1,-]. The pin now holds its own known-negative on those bytes:
read with --no-tie-shared-rank the same bundle gives [2,1,1,1,1,-], so the
green assertion names its cause. Consumer cost is a re-run: 425/810 -> 436/832
on the reference corpus, 15/30 -> 26/52 on a five-document folder.
pptx and md measured end to end for the first time, on two hand-built
documents: md recovers 3 of 4 declared headings, pptx segments per slide only
where the converter recognised a title placeholder. A converter attribute leaks
into titles ({#slide-N}, {#sheet-1}) on 2 of 810 K2 files and 1 of 30 on a
five-document folder -- not fixed, because a filename is reduced from its title
and the fix renames concept ids a consumer has cited.
Suite 1486 (1478 before), ruff and mypy --strict clean over 21 files.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
parent
38104b7df5
commit
a364ef4c7d
11 changed files with 768 additions and 99 deletions
|
|
@ -6,14 +6,17 @@ measured on a bundle nobody produces is a number that cannot regress, so the
|
|||
guarantee it looks like was never held by anything.
|
||||
|
||||
This file pins the CURRENT default: `--outline-run 3 --table-grid --unit-fold
|
||||
--drop-wrapped-outline --outline-gate`, the configuration round 6 moved the
|
||||
default to on 2026-09-09 after measuring hit@8 on exactly this bundle.
|
||||
--drop-wrapped-outline --outline-gate --first-span-from-zero
|
||||
--sheet-section-rows --keep-table-heading`, plus the reading side's
|
||||
`tie_shared_rank`. Round 6 moved the first five on 2026-09-09 and round 7 moved
|
||||
the last four on 2026-09-10, each after measuring hit@8 on exactly the bundle
|
||||
its own default produces.
|
||||
|
||||
The gold set is LOCAL-ONLY and stays that way: no question and no
|
||||
`gold_document` is reproduced here, and a row is named by its INDEX, the way
|
||||
`docs/2026-09-07-okf-konsumskill-maaling.md` already names them.
|
||||
|
||||
The bundle itself is a build artefact, not a fixture: it is 810 files of a
|
||||
The bundle itself is a build artefact, not a fixture: it is 832 files of a
|
||||
consumer's corpus and this repository is public. Absent, these tests SKIP with
|
||||
the command that rebuilds it -- "not measured", never zero.
|
||||
"""
|
||||
|
|
@ -34,10 +37,10 @@ import okf_consume_measure # noqa: E402
|
|||
|
||||
#: Built by:
|
||||
#: okf build <corpus>/K2/trinn1 \
|
||||
#: --bundle ~/corpora/okf-telling-20260829/K2-bundle-default-20260909 \
|
||||
#: --bundle ~/corpora/okf-telling-20260829/K2-bundle-default-20260910 \
|
||||
#: --bundle-id k2-trinn1-20260903 --okf-version 0.2
|
||||
#: with no arm flag at all -- the package default, which is the point.
|
||||
DEFAULT_BUNDLE = Path.home() / "corpora" / "okf-telling-20260829" / "K2-bundle-default-20260909"
|
||||
DEFAULT_BUNDLE = Path.home() / "corpora" / "okf-telling-20260829" / "K2-bundle-default-20260910"
|
||||
GOLD_SET = PROJECT_ROOT / ".claude/projects/2026-09-07-okf-consume-prepass/hit-at-k-questions.json"
|
||||
|
||||
requires_default_bundle = pytest.mark.skipif(
|
||||
|
|
@ -49,8 +52,11 @@ requires_default_bundle = pytest.mark.skipif(
|
|||
),
|
||||
)
|
||||
|
||||
#: Measured 2026-09-09 on the bundle above.
|
||||
EXPECTED_CONCEPTS = 425
|
||||
#: Measured 2026-09-10 on the bundle above. The count moved 425 -> 436 with
|
||||
#: `--sheet-section-rows --keep-table-heading`; `--first-span-from-zero` moved
|
||||
#: it by NOTHING, which is the point of that rule -- it adds no boundary and
|
||||
#: only moves one span's start.
|
||||
EXPECTED_CONCEPTS = 436
|
||||
EXPECTED_HITS = 5
|
||||
#: Rank per question INDEX, `None` for the row that misses on every bundle and
|
||||
#: every configuration measured so far. The identity is the index; the question
|
||||
|
|
@ -70,6 +76,10 @@ def test_hit_at_eight_holds_rank_one_on_every_row_it_held() -> None:
|
|||
Not the hit COUNT alone: the count survived a configuration that lost a
|
||||
row from rank 1 to rank 2, which is exactly how the previous round's
|
||||
regression hid. The rank per row is the pin.
|
||||
|
||||
On THIS bundle that is not a hypothetical -- see the test below, which
|
||||
reproduces the fall on these exact bytes by turning the reading-side
|
||||
default off.
|
||||
"""
|
||||
questions = json.loads(GOLD_SET.read_text(encoding="utf-8"))["questions"]
|
||||
assert len(questions) == len(EXPECTED_RANKS), "the gold set changed shape"
|
||||
|
|
@ -87,3 +97,31 @@ def test_hit_at_eight_holds_rank_one_on_every_row_it_held() -> None:
|
|||
def test_the_bundle_declares_the_identity_the_reader_needs() -> None:
|
||||
"""Whatever else moves, the bundle stays one the reading direction opens."""
|
||||
assert okf_consume.root_bundle_id_of(DEFAULT_BUNDLE) == "k2-trinn1-20260903"
|
||||
|
||||
|
||||
@requires_default_bundle
|
||||
def test_the_reading_default_is_what_holds_row_one_on_these_bytes() -> None:
|
||||
"""The known-negative, on the shipped bundle rather than a fixture.
|
||||
|
||||
Round 7 moved `--sheet-section-rows --keep-table-heading` into the build
|
||||
default, which splits row 1's gold document from 1 concept into 12. Round 6
|
||||
measured that exact split costing row 1 its rank, and held the two rules
|
||||
back for it. What removed the cost is `consume.DEFAULT_TIE_SHARED_RANK`,
|
||||
and this test is the proof that it is still what removes it: turn it off
|
||||
on these bytes and the fall comes back.
|
||||
|
||||
Without this, `EXPECTED_RANKS` above would be a green assertion with no
|
||||
stated cause, and a later change to the fusion could take the cause away
|
||||
while the pin stayed green on some other accident.
|
||||
"""
|
||||
questions = json.loads(GOLD_SET.read_text(encoding="utf-8"))["questions"]
|
||||
ranks = []
|
||||
for entry in questions:
|
||||
payload = okf_consume.build_payload(
|
||||
DEFAULT_BUNDLE, question=entry["question"], tie_shared_rank=False
|
||||
)
|
||||
excerpts = payload["excerpts"]
|
||||
assert isinstance(excerpts, list)
|
||||
ranks.append(okf_consume_measure.hit_rank(excerpts, entry["gold_document"]))
|
||||
assert ranks[0] == 2, "the known-negative stopped being negative"
|
||||
assert tuple(ranks[1:]) == EXPECTED_RANKS[1:]
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue