Vendoring commons v0.1.0 under scanners/commons/ falsified the premise of `degrades gracefully when commons has not been vendored yet`: it asserted the default DEFAULT_COMMONS_ROOT did not exist. It was the only red test after the subtree add (2072/2073). The graceful-empty contract it guarded is covered twice over by the missing-artifact and invalid-JSON cases, which drive the same code path through an explicit commonsRoot. So the replacement asserts the direction that is now uncovered and matters more: a non-zero record count through the real default root, no override. That is the positive load-assertion Phase 5 step 4 requires. Every other gate we have treats a commons load failure as indistinguishable from a legitimately empty table, so a total loss of the vendored corpus would leave the suite green. Proven red-capable by moving scanners/commons aside: the assertion fires by name, not as an incidental TypeError elsewhere. Suite 2073/2073. |
||
|---|---|---|
| .. | ||
| e2e | ||
| fixtures | ||
| golden | ||
| helpers | ||
| hooks | ||
| lib | ||
| scanners | ||