llm-security/scanners/signature-scanner.mjs
Kjell Tore Guttormsen bbada84e9f refactor(llm-security): build the SIG ruleset from vendored commons (malware-signatures 0.1.0)
Fifth and last consumer swap of v8 Phase 5 step 4. The seven known-bad-identity
signatures stop living in knowledge/signatures.json and are built from the
vendored commons artifact signatures/malware-signatures.json instead.

Measured before the swap over all seven positions -- id, family, severity,
pattern, description, provenance, key order, and recompilation identity under
the engine's unconditional `i` flag: zero divergences over 56 checks, in order.
The commons copy was extracted from this repository's own file at b0de0ca and
had not drifted.

knowledge/signatures.json is REMOVED rather than left in place. Keeping it would
have left two files spelling one table with nothing gating the drift, and its
golden `file:` pin would have gone on passing while pinning bytes no scanner
reads -- a gate reporting success without running. The pin is replaced by a
walked-module anchor over SIGNATURE_RULES, which is strictly stronger: the pin
covered the bytes on disk, the walk covers what `new RegExp` made of them.
Golden diff was exactly that and nothing else: 7 ADDED, 1 REMOVED, 0 CHANGED
(102/7/5 -> 109/7/4), each added source verified equal to the recompiled commons
pattern.

compileRules() moves into the new lib module and is exported, so the built-in
ruleset and the operator's sig.custom_rules_path path keep one implementation
rather than two copies of the defaulting logic.

Coverage by construction, not by memory: the probe table in the scanner test is
asserted against the LOADED ruleset, so a rule commons adds cannot arrive
without an end-to-end probe. Mutation of the vendored JSON fires in three
directions -- under-match (xmrig alternative dropped) reddens two scanner tests
plus golden; over-match (webshell rule widened to a bare `shell`) reddens the
clean-fixture false-positive probe plus golden; reorder reddens the declared-
order test plus golden.

Loud failure is contract: an unresolvable commons writes one line to stderr
rather than silently disabling known-malware detection, and never throws.

Suite 2247 / 2241 pass / 6 skipped / 0 fail. suite-counts.json untouched.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0151x4FVg9Mn55C2LvHLpHKo
2026-08-13 21:28:14 +02:00

125 lines
5.6 KiB
JavaScript

// signature-scanner.mjs — SIG: known-bad-identity signature engine
//
// Detects known-malware *identity* (webshells, reverse shells, cryptominers,
// hacktools) — complementary to the shape-based scanners (entropy/taint).
//
// Differentiator vs raw signature engines (e.g. YARA): every signature regex
// is tested not only against the raw file bytes but also against the project's
// decode pipeline (normalizeForScan -> base64/hex/url/entity/unicode decode,
// foldHomoglyphs, rot13). Obfuscated known-malware that a byte-matcher misses
// is therefore still caught.
//
// OWASP coverage: LLM03 (supply chain) primary; LLM02 (sensitive disclosure).
// Zero external dependencies — Node.js builtins only.
import { readFile } from 'node:fs/promises';
import { isAbsolute, resolve } from 'node:path';
import { finding, scannerResult } from './lib/output.mjs';
import { readTextFile } from './lib/file-discovery.mjs';
import { normalizeForScan, foldHomoglyphs, rot13 } from './lib/string-utils.mjs';
import { getPolicyValue } from './lib/policy-loader.mjs';
import { SIGNATURE_RULES, compileRules } from './lib/malware-signatures.mjs';
// Paths excluded from signature scanning when present under the scan root:
// test fixtures and docs legitimately contain patterns that would otherwise
// self-flag. `knowledge/` is kept even though the ruleset itself moved to the
// vendored commons in v8 Phase 5 — a scanned target's own knowledge/ directory
// is as likely to hold ruleset-shaped prose as ours was.
const EXCLUDED_PATH_RE = /(^|\/)(knowledge|tests|docs|node_modules)\//i;
const DEFAULT_FAMILIES = ['webshell', 'reverse_shell', 'cryptominer', 'hacktool'];
/**
* v7.8.3 (#36): load operator-supplied rules from the documented
* `sig.custom_rules_path` policy option. Relative paths resolve against the
* scan root (where .llm-security/policy.json lives). Never cached — policy is
* per-target. Fails gracefully (empty array) on a missing/invalid file.
* @param {string} targetPath
* @returns {Promise<Array<{id,family,severity,re,description,provenance}>>}
*/
async function loadCustomRules(targetPath) {
const customPath = getPolicyValue('sig', 'custom_rules_path', null, targetPath);
if (!customPath || typeof customPath !== 'string') return [];
const rulesetPath = isAbsolute(customPath) ? customPath : resolve(targetPath, customPath);
try {
const raw = await readFile(rulesetPath, 'utf8');
return compileRules(JSON.parse(raw));
} catch {
return []; // graceful: unreadable/invalid custom ruleset -> built-ins only
}
}
/** Build the decode-variant set for one file's content (de-duplicated). */
function variantsOf(content) {
const variants = [{ label: 'raw', text: content }];
const seen = new Set([content]);
const add = (label, text) => {
if (text && !seen.has(text)) { seen.add(text); variants.push({ label, text }); }
};
// Trimming before decode lets a base64/hex blob with surrounding whitespace
// (a trailing newline, indentation) still decode — common in real payloads.
add('decoded', normalizeForScan(content, { decodeEmbedded: true }));
add('decoded-trimmed', normalizeForScan(content.trim(), { decodeEmbedded: true }));
add('homoglyph-folded', foldHomoglyphs(content));
add('rot13', rot13(content));
return variants;
}
/**
* Scan all discovered files for known-bad signatures.
*
* @param {string} targetPath - Absolute root path being scanned
* @param {{ files: import('./lib/file-discovery.mjs').FileInfo[] }} discovery
* @returns {Promise<object>} - scannerResult envelope
*/
export async function scan(targetPath, discovery) {
const startMs = Date.now();
const findings = [];
let filesScanned = 0;
try {
const rules = [...SIGNATURE_RULES, ...await loadCustomRules(targetPath)];
const enabledFamilies = new Set(
(getPolicyValue('sig', 'enabled_families', DEFAULT_FAMILIES, targetPath) || []).map(f => String(f)),
);
const activeRules = rules.filter(r => enabledFamilies.has(r.family));
if (activeRules.length === 0) {
return scannerResult('signature-scanner', 'ok', findings, filesScanned, Date.now() - startMs);
}
for (const fileInfo of discovery.files) {
const relPath = String(fileInfo.relPath).replace(/\\/g, '/');
if (EXCLUDED_PATH_RE.test('/' + relPath)) continue;
const content = await readTextFile(fileInfo.absPath);
if (content === null) continue;
filesScanned++;
const variants = variantsOf(content);
const seen = new Set(); // de-dup per (file, rule)
for (const rule of activeRules) {
if (seen.has(rule.id)) continue;
const hit = variants.find(v => rule.re.test(v.text));
if (!hit) continue;
seen.add(rule.id);
const viaDecode = hit.label !== 'raw';
findings.push(finding({
scanner: 'SIG',
severity: rule.severity,
title: `Known-bad signature: ${rule.family} (${rule.id})`,
description: `${rule.description}${viaDecode ? ` — matched after decoding (${hit.label} variant), i.e. obfuscated.` : '.'}`,
file: fileInfo.relPath,
evidence: `${rule.id} [${rule.family}]${rule.provenance ? `${rule.provenance}` : ''}`,
owasp: 'LLM03',
recommendation: `Remove the ${rule.family} payload, or if this is an intentional security sample, exclude its path or disable the "${rule.family}" family in .llm-security/policy.json.`,
}));
}
}
return scannerResult('signature-scanner', 'ok', findings, filesScanned, Date.now() - startMs);
} catch (err) {
return scannerResult('signature-scanner', 'error', findings, filesScanned, Date.now() - startMs, err.message);
}
}