feat(ms-ai-architect): C2.3 onboarding skriver scheduled_detection cadence+enabled via gated CLI (TDD) [skip-docs]
K5 oppfylt: onboarding skriver scheduled_detection-blokka (enabled + os_scheduler_cadence) til bruker-eid config; parseScheduleConfig leser den tilbake til samme verdier (round-trip bevist deterministisk). - serializeScheduleConfig(config) i detection-schedule.mjs — invers av parseScheduleConfig, rett ved parseren (én formatsannhet). - write-schedule-config.mjs (NY, gated CLI, Claude-fri): merger på eksisterende config (override kun de to onboarding-eide nøklene; interval_days/ include_skill_lifecycle overlever). backupFile + atomicWriteSync — ingen rå fs-write. - backupFile(filePath, backupRoot) i lib/backup.mjs — presis enkeltfil-backup. - onboard.md (orkestrator): «Planlagt deteksjon»-seksjon + scheduler i --status. onboarding-agent.md: note om at scheduler er orkestratorens jobb (ingen Bash). - Avvik fra plan-tekst (dokumentert): scheduler-spørsmål i orkestrator, ikke agent. Verifisert: detection-schedule 33/33 (+10) · backup-restore 15/15 (+3) · kb-update 213 · kb-eval 100 · validate 239/0/0 · test-hooks 11/11 · kb-integrity 192/192 · discovery 13/13 · gitleaks 3 pre-eksisterende. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
parent
8ff73b7fe3
commit
afd75c4fed
8 changed files with 340 additions and 4 deletions
|
|
@ -17,6 +17,7 @@ import { tmpdir } from 'node:os';
|
|||
import { join } from 'node:path';
|
||||
import {
|
||||
backupDir,
|
||||
backupFile,
|
||||
detectStaleRollback,
|
||||
cleanupOldBackups,
|
||||
backupTimestamp,
|
||||
|
|
@ -97,6 +98,34 @@ test('backupDir — copies content faithfully (deep equal)', () => {
|
|||
});
|
||||
});
|
||||
|
||||
// --- backupFile: precise single-file backup (C2.3 config-write guard) ---
|
||||
|
||||
test('backupFile — copies one file into a timestamped subdir, preserving content', () => {
|
||||
withTmp((tmp) => {
|
||||
const file = join(tmp, 'ms-ai-architect.local.md');
|
||||
const root = join(tmp, '.backups');
|
||||
writeFileSync(file, 'PRIOR CONTENT', 'utf8');
|
||||
|
||||
const res = backupFile(file, root);
|
||||
assert.ok(res && res.backupPath, 'returns the backup path');
|
||||
assert.match(res.backupPath, /\.backups\/\d{4}-\d{2}-\d{2}T\d{2}-\d{2}-\d{2}\/ms-ai-architect\.local\.md$/);
|
||||
assert.equal(readFileSync(res.backupPath, 'utf8'), 'PRIOR CONTENT');
|
||||
});
|
||||
});
|
||||
|
||||
test('backupFile — no-op (returns null) when the source file is absent', () => {
|
||||
withTmp((tmp) => {
|
||||
const res = backupFile(join(tmp, 'does-not-exist.md'), join(tmp, '.backups'));
|
||||
assert.equal(res, null);
|
||||
assert.equal(existsSync(join(tmp, '.backups')), false, 'no backup dir created when nothing to back up');
|
||||
});
|
||||
});
|
||||
|
||||
test('backupFile — throws on missing args', () => {
|
||||
assert.throws(() => backupFile('', '/tmp/x'), /filePath/);
|
||||
assert.throws(() => backupFile('/tmp/x', ''), /backupRoot/);
|
||||
});
|
||||
|
||||
test('backupDir — writes .backup-meta.json sentinel inside backup', () => {
|
||||
withTmp((tmp) => {
|
||||
const src = join(tmp, 'skills');
|
||||
|
|
|
|||
|
|
@ -12,7 +12,7 @@
|
|||
|
||||
import { test } from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { mkdtempSync, rmSync, mkdirSync, writeFileSync, readFileSync } from 'node:fs';
|
||||
import { mkdtempSync, rmSync, mkdirSync, writeFileSync, readFileSync, existsSync, readdirSync } from 'node:fs';
|
||||
import { tmpdir } from 'node:os';
|
||||
import { join, dirname } from 'node:path';
|
||||
import { fileURLToPath } from 'node:url';
|
||||
|
|
@ -20,11 +20,13 @@ import {
|
|||
DEFAULT_SCHEDULE_CONFIG,
|
||||
DETECTION_STEPS,
|
||||
parseScheduleConfig,
|
||||
serializeScheduleConfig,
|
||||
loadScheduleConfig,
|
||||
shouldRunDetection,
|
||||
summarizeSkillLifecycle,
|
||||
daysSinceLastPoll,
|
||||
} from '../../scripts/kb-update/lib/detection-schedule.mjs';
|
||||
import { writeScheduleConfig } from '../../scripts/kb-update/write-schedule-config.mjs';
|
||||
import { resolveConfigPath, resolveUserDataDir } from '../../scripts/kb-update/lib/user-data.mjs';
|
||||
|
||||
const __dirname = dirname(fileURLToPath(import.meta.url));
|
||||
|
|
@ -92,6 +94,120 @@ test('parseScheduleConfig — unknown/garbage cadence falls back to daily', () =
|
|||
'unspecified cadence => daily default');
|
||||
});
|
||||
|
||||
// ===========================================================================
|
||||
// (A2) C2.3 — serializeScheduleConfig + writeScheduleConfig (onboarding writes
|
||||
// the opt-in config; parseScheduleConfig round-trips it — acceptance K5)
|
||||
// ===========================================================================
|
||||
|
||||
test('serializeScheduleConfig — produces a parseable scheduled_detection: block', () => {
|
||||
const text = serializeScheduleConfig({ enabled: true, os_scheduler_cadence: 'interval' });
|
||||
assert.match(text, /^---/, 'frontmatter-fenced config file');
|
||||
assert.match(text, /scheduled_detection:/);
|
||||
assert.match(text, /\n {2}enabled: true/);
|
||||
assert.match(text, /\n {2}os_scheduler_cadence: interval/);
|
||||
});
|
||||
|
||||
test('serializeScheduleConfig — round-trips through parseScheduleConfig (daily)', () => {
|
||||
const cfg = parseScheduleConfig(serializeScheduleConfig({ enabled: true, os_scheduler_cadence: 'daily' }));
|
||||
assert.equal(cfg.enabled, true);
|
||||
assert.equal(cfg.os_scheduler_cadence, 'daily');
|
||||
assert.equal(cfg.interval_days, 7, 'unspecified key serialized at its default');
|
||||
assert.equal(cfg.include_skill_lifecycle, true);
|
||||
});
|
||||
|
||||
test('serializeScheduleConfig — round-trips interval cadence + disabled', () => {
|
||||
const cfg = parseScheduleConfig(serializeScheduleConfig({ enabled: false, os_scheduler_cadence: 'interval' }));
|
||||
assert.equal(cfg.enabled, false);
|
||||
assert.equal(cfg.os_scheduler_cadence, 'interval');
|
||||
});
|
||||
|
||||
test('serializeScheduleConfig — preserves a non-default interval_days through the round-trip', () => {
|
||||
const cfg = parseScheduleConfig(serializeScheduleConfig({ enabled: true, interval_days: 14, os_scheduler_cadence: 'daily' }));
|
||||
assert.equal(cfg.interval_days, 14);
|
||||
});
|
||||
|
||||
test('serializeScheduleConfig — garbage cadence is normalized to daily', () => {
|
||||
const cfg = parseScheduleConfig(serializeScheduleConfig({ enabled: true, os_scheduler_cadence: 'weekly' }));
|
||||
assert.equal(cfg.os_scheduler_cadence, 'daily');
|
||||
});
|
||||
|
||||
test('writeScheduleConfig — writes user config that parseScheduleConfig reads back (K5)', () => {
|
||||
const home = mkdtempSync(join(tmpdir(), 'home-'));
|
||||
try {
|
||||
const { configPath } = writeScheduleConfig({ enabled: true, cadence: 'interval', home });
|
||||
assert.equal(configPath, resolveConfigPath(home), 'writes to the user-owned config path');
|
||||
const cfg = parseScheduleConfig(readFileSync(configPath, 'utf8'));
|
||||
assert.equal(cfg.enabled, true);
|
||||
assert.equal(cfg.os_scheduler_cadence, 'interval');
|
||||
} finally {
|
||||
rmSync(home, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test('writeScheduleConfig — coerces string flags (CLI args arrive as strings)', () => {
|
||||
const home = mkdtempSync(join(tmpdir(), 'home-'));
|
||||
try {
|
||||
writeScheduleConfig({ enabled: 'true', cadence: 'daily', home });
|
||||
const cfg = parseScheduleConfig(readFileSync(resolveConfigPath(home), 'utf8'));
|
||||
assert.equal(cfg.enabled, true, '"true" string => boolean true');
|
||||
assert.equal(cfg.os_scheduler_cadence, 'daily');
|
||||
} finally {
|
||||
rmSync(home, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test('writeScheduleConfig — merge preserves pre-existing keys (interval_days) it does not own', () => {
|
||||
const home = mkdtempSync(join(tmpdir(), 'home-'));
|
||||
try {
|
||||
mkdirSync(resolveUserDataDir(home), { recursive: true });
|
||||
writeFileSync(
|
||||
resolveConfigPath(home),
|
||||
'scheduled_detection:\n enabled: true\n interval_days: 21\n include_skill_lifecycle: false\n',
|
||||
);
|
||||
writeScheduleConfig({ enabled: false, cadence: 'interval', home });
|
||||
const cfg = parseScheduleConfig(readFileSync(resolveConfigPath(home), 'utf8'));
|
||||
assert.equal(cfg.enabled, false, 'onboarding-owned key updated');
|
||||
assert.equal(cfg.os_scheduler_cadence, 'interval', 'onboarding-owned key updated');
|
||||
assert.equal(cfg.interval_days, 21, 'non-owned key preserved across the rewrite');
|
||||
assert.equal(cfg.include_skill_lifecycle, false, 'non-owned key preserved across the rewrite');
|
||||
} finally {
|
||||
rmSync(home, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test('writeScheduleConfig — backs up an existing config before overwriting it', () => {
|
||||
const home = mkdtempSync(join(tmpdir(), 'home-'));
|
||||
try {
|
||||
writeScheduleConfig({ enabled: true, cadence: 'daily', home }); // first write: nothing to back up
|
||||
const backupRoot = join(resolveUserDataDir(home), '.backups');
|
||||
assert.equal(existsSync(backupRoot), false, 'no backup created on first write (no prior file)');
|
||||
writeScheduleConfig({ enabled: false, cadence: 'interval', home }); // second write: prior file exists
|
||||
assert.equal(existsSync(backupRoot), true, 'prior config backed up before the second write');
|
||||
const stamps = readdirSync(backupRoot);
|
||||
assert.equal(stamps.length, 1, 'exactly one backup generation');
|
||||
const backedUp = parseScheduleConfig(
|
||||
readFileSync(join(backupRoot, stamps[0], 'ms-ai-architect.local.md'), 'utf8'),
|
||||
);
|
||||
assert.equal(backedUp.enabled, true, 'backup holds the PRIOR (pre-overwrite) config');
|
||||
} finally {
|
||||
rmSync(home, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test('writeScheduleConfig — loadScheduleConfig picks up what onboarding wrote (end-to-end)', () => {
|
||||
const root = mkdtempSync(join(tmpdir(), 'sched-'));
|
||||
const home = mkdtempSync(join(tmpdir(), 'home-'));
|
||||
try {
|
||||
writeScheduleConfig({ enabled: true, cadence: 'interval', home });
|
||||
const cfg = loadScheduleConfig(root, home);
|
||||
assert.equal(cfg.enabled, true, 'the scheduler loads the onboarding-written user config');
|
||||
assert.equal(cfg.os_scheduler_cadence, 'interval');
|
||||
} finally {
|
||||
rmSync(root, { recursive: true, force: true });
|
||||
rmSync(home, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
|
||||
test('daysSinceLastPoll — Infinity when report missing or last_poll absent/invalid', () => {
|
||||
const now = Date.UTC(2026, 5, 21);
|
||||
assert.equal(daysSinceLastPoll(null, now), Infinity);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue