open/portfolio-optimiser
1
0
Fork 0
Code Issues Releases 3 Activity

feat(validator): anchor the deterministic gate to the project's real cost baseline (S4.0)

Browse source 
Every stage of validate_proposal reasoned only about numbers the proposal itself
supplied, so an internally-consistent hallucination cleared the whole gate (F3).
A new stage 0 reconciles each affected_item against the project's CostBaseline
before the CBC solve: an unknown cost code is rejected, and a real code carrying
a quantity/unit_cost outside the configured tolerance (5% default, relative to
the baseline value) is rejected. Validation, never repair.

The baseline argument is OPTIONAL (None = pre-S4.0 behaviour), but both run
paths set it: the road path projects project.cost_items, the bundle path loads
cost-baseline.json when the bundle ships one. Bundles written before the
amendment stay un-anchored, so the commons-owned goldens run byte-identically;
a baseline that exists but is malformed still raises on both loaders.

F8: the method-specific cap now comes from the METHOD_CAPS registry (measure
type -> fraction, injectable) instead of an energy_efficiency string comparison.

The baseline format and tolerance semantics were decided locally — the commons
amendment (D-A pt. 2) never arrived, exactly as in S3.2. D7 mirroring stays open.

Three portfolio fixtures quoted cost codes belonging to OTHER projects; the new
gate caught them. They now quote each project's own lines, and the two copied
REPLIES tables import the single source instead of drifting from it.

Load-bearing measured (tests/test_s40_cost_baseline_loadbearing.py), six
mutations all red: detach the reconciliation stage; detach the magnitude
tolerance; detach the road wiring; detach the bundle wiring; ignore the injected
cap registry; make the optional loader tolerant of malformed content. Control:
with the road wiring detached the repaired portfolio fixtures still pass, so
they are not masking the seam. 597 -> 612 tests.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JdwK7bQ4BZkWH4t8MRDKb4
This commit is contained in:
Kjell Tore Guttormsen 2026-08-03 17:19:31 +02:00
commit 126807aee7
16 changed files with 645 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/portfolio_optimiser/ir.py
View file

@ -24,6 +24,31 @@ class AffectedItem(BaseModel):
return self.quantity * self.unit_cost
class CostBaselineLine(BaseModel):
"""One line of a project's ACTUAL cost baseline: the quantity and unit cost a proposal's
``AffectedItem`` for that code must reconcile against (S4.0, F3)."""
quantity: float = Field(ge=0)
unit_cost: float = Field(gt=0)
class CostBaseline(BaseModel):
"""A project's cost baseline, keyed by cost code — the ground truth the deterministic
validator anchors ``affected_items`` to, so the gate cannot be fed hallucinated cost lines.
Deliberately a typed IR contract (not a loader-private shape): both sources project INTO
it — an OKF bundle's ``cost-baseline.json`` (``okf.load_cost_baseline``) and the road
reference domain's ``cost_items`` (``validator.baseline_from_project``) — so the validator
sees ONE representation regardless of path, and the Claude-SDK sibling can mirror it (D7).
The projection/tolerance semantics were decided HERE: the commons amendment specifying
``cost-baseline.json`` never arrived, exactly as in S3.2. D7 mirroring stays OPEN.
"""
project_id: str
items: dict[str, CostBaselineLine]
class SavingsProposal(BaseModel):
"""Typed IR for a candidate cost-saving measure (B1)."""