open/portfolio-optimiser
1
0
Fork 0
Code Issues Releases 3 Activity

docs(major2): remedieringsfoot under den sporede trekreview-kopien

Browse source 
Tallene foer/etter, ett commit per funn, og mutasjonssignaturene - der
reviewen selv bor, saa de to kan ikke drive fra hverandre.

1364 passed / 5 skipped -> 1367 / 5 (collect 1369 -> 1372, strengt supersett,
0 fjernet). mypy + ruff rene. Golden BYTE-UENDRET (shasum -a 1 av INNHOLDET =
ea8c534773acdbe41ae68f2c55724d69aaf8be4f).

Header-notatet er justert: artefaktet er fortsatt byte-identisk, footeren
ligger UNDER det og er repoets egen.

Uttalt i footeren, ikke stilltiende: reviewens fokuspunkt 4 (hosting.py:144
literal vs `_REFUSED_BY_NAME` - verifisert fortsatt sann ved HEAD) er UTENFOR
ordren og staar som kandidat, det samme gjoer de tre restene under fokuspunkt
1. Og hvert kriterium reviewen kalte UMAALT mot levende modell (SC1s
utfall-halvdel, SC4, SC8, SC13-premisset) er fortsatt umaalt - ingenting her
er kjoert mot en modell.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-09-05 22:31:06 +02:00
commit 15ff7a82d7
1 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

29
docs/2026-09-05-major2-trekreview.md
View file

@ -1,4 +1,4 @@
<!-- Tracked archive of the Voyage /trekreview artefact `.claude/projects/2026-09-04-major2-proposal-review-door/review.md` (local-only, gitignored like brief.md and plan.md). Byte-identical copy at commit time; `/trekplan --brief` consumes the local-only original. Order 20260905T191506Z-9345814922-from-.claude. --> <!-- Tracked archive of the Voyage /trekreview artefact `.claude/projects/2026-09-04-major2-proposal-review-door/review.md` (local-only, gitignored like brief.md and plan.md). Byte-identical copy of the artefact at commit time (the REMEDIATION footer below it is this repo's own addition, appended after the artefact ends); `/trekplan --brief` consumes the local-only original. Order 20260905T191506Z-9345814922-from-.claude. -->
--- ---
type: trekreview type: trekreview
review_version: "1.0" review_version: "1.0"
@ -219,3 +219,30 @@ If running `/trekplan --brief review.md`, the planner will consume the BLOCKER +
] ]
} }
``` ```
---
## REMEDIATION (order `20260905T195046Z-3378824829-from-.claude`, økt 91) — not part of the artefact above
All five findings addressed, one commit each except the two that share a witness by construction.
Suite **1364 passed / 5 skipped → 1367 passed / 5 skipped** (collected 1369 → 1372, strict
superset, **0 removed**); `mypy src` clean (36 files), `ruff check src tests` clean; golden
`tests/golden/demo-transcript.stdout` BYTE-UNCHANGED (`shasum -a 1` of the CONTENTS =
`ea8c534773acdbe41ae68f2c55724d69aaf8be4f`, never the git blob id).
| Finding | Severity | Commit | Mutations, all against the WHOLE suite |
|---|---|---|---|
| `ada5f264` CLAUDE.md:1843 | BLOCKER | `9ed458c` | docs; verified by grep INSIDE the row's own lines (1842..1969): «announce», «offered, never consulted», M33, M37 |
| `02159d21` run.py:2738 + `da485928` tests:1344 | MAJOR ×2 | `c81a90c` | the rewritten arm measured RED against the unchanged guard (`calls == []`, stderr carried the very refusal that recommends the path); park refusal (M39) stays green |
| `5935d942` tests:820 | MAJOR | `d4a0220` | MA classifier constant-empty → 2 red (the two paired arms); MB filter dropped → 2 red. Control 1364/5 |
| `d71a5d72` run.py:1202 | MINOR | `257f44f` | MC guard detached → 2 red (both in-flight arms); MD swallow unconditionally → 1 red (the CONTROL arm alone). Control 1367/5 |
**Out of scope by the order, stated:** the review's operator-focus point 4 (`hosting.py:144` uses the
literal `"proposal_review"` while `_REFUSED_BY_NAME` is defined at :109 — two copies of one fact,
kø-(p)) is NOT fixed here and stands as a candidate. The three residuals under focus point 1
(T2b's docstring repeating the falsified M29 prediction; § 1 vs § 4 of the measurement doc
disagreeing about the `generate.py` comment; the F4 traceback asymmetry) are likewise untouched.
**Unchanged by this remediation:** every criterion the review listed as UNMEASURED against a live
model — SC1's outcome-differs half, SC4, SC8, SC13's model-follows-feedback premise — is still
unmeasured. Nothing here was run against a model.