test(budget): defend the third field of the stop event — observed (kø-y)
BudgetExceeded carries kind/limit/observed as ONE structured stop event, but only `observed` was undefended. Measured against the whole suite before writing anything: four of five raise sites (TokenMeter.charge, tick_round, and BOTH arms of exhausted()) could report any value at all without a single one of 621 tests noticing. Only PortfolioMeter.check was covered. What hid it: spikes/_harness.py carries its OWN copy of BudgetExceeded/TokenMeter, so the spike suite's `observed` assert never touched the shipped module — the production tick_round had no direct test whatsoever. exhausted() is the only site that CHOOSES a ledger (the S3.4 pre-call guard), so a refusal naming portfolio_tokens while reporting the run's own spend would misdirect every reader of it. Both arms are pinned with observed != limit on purpose: at exactly-exhausted the two coincide, and a test written there would pass on an implementation that echoed the cap back as the spend. No defect in the values themselves (unlike kø-x and kø-p) — the triple was coherent at all five sites; the gap was purely coverage. Load-bearing MEASURED: nine mutations, all red — five observed mutations (including the control) and four echo mutations. 621 -> 623 tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LW749xcXQmVEgdipB6KNm4
This commit is contained in:
parent
756e8f8259
commit
3748011d35
2 changed files with 60 additions and 0 deletions
14
CLAUDE.md
14
CLAUDE.md
|
|
@ -181,6 +181,20 @@ Python ≥3.10. MAF (`agent-framework-core` 1.9.0). Pakkehåndtering: `uv`. To b
|
|||
Load-bearing MÅLT (`tests/test_portfolio_budget_loadbearing.py` + `tests/test_budget.py`), seks
|
||||
mutasjoner alle røde: detach wave-sjekken · detach pre-call-guarden · detach bølge-reservasjonen ·
|
||||
sjekk run-taket før global kreditering · detach oppstartsnekten · gjør `read_spend` tolerant.
|
||||
- **`BudgetExceeded`s tre felt beskriver ÉN og samme ledger (kø-(y)):** `kind`/`limit`/`observed`
|
||||
er ett strukturert stopp-event, og `observed` var det udefenderte tredje feltet — MÅLT: fire av
|
||||
fem raise-steder (`TokenMeter.charge`, `tick_round`, og BEGGE armene i `exhausted()`) kunne
|
||||
rapportere hvilken som helst verdi uten at 621 tester merket det; bare `PortfolioMeter.check`
|
||||
var dekket. **Fellen som skjulte det:** `spikes/_harness.py:41` har sin EGEN kopi av
|
||||
`BudgetExceeded`/`TokenMeter`, så `spikes/test_harness.py`s `observed`-assert dekker IKKE den
|
||||
shippede modulen — produksjonens `tick_round` hadde null direkte test. `exhausted()` er det
|
||||
ENESTE stedet som VELGER ledger (S3.4-guarden), så en refusal som sier `portfolio_tokens` mens
|
||||
den rapporterer runets eget forbruk ville villedet enhver leser. **Testene bygges med
|
||||
`observed != limit`**: ved nøyaktig-uttømt sammenfaller de to, og en test skrevet der kan ikke
|
||||
skille dem — den ville passert på en implementasjon som ekkoet taket tilbake som forbruket.
|
||||
Ingen defekt funnet i verdiene selv (kontrast (x)/(p)): trippelen var koherent alle fem steder,
|
||||
gapet var rent dekning. Load-bearing MÅLT (`tests/test_budget.py`), ni mutasjoner alle røde:
|
||||
fem `observed`-mutasjoner (inkl. kontrollen) + fire ekko-mutasjoner.
|
||||
- **Pengetall kvantiseres i ÉN orden, fra ÉN kilde (kø-(p)):** `ledger.to_ore` er rammeverkets ENE
|
||||
NOK→øre-konvertering (Decimal, ROUND_HALF_UP), og den brukes **per pengebeløp — deretter summeres
|
||||
HELTALL**. `run.py` importerer den; aldri en egen kopi (to kopier av en penge-konvertering drifter,
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue