open/portfolio-optimiser
1
0
Fork 0
Code Issues Releases 1 Activity

fix(s54): reject non-array/non-object ledger JSON in SavingsLedger.load

Browse source 
S5.4 review MINOR (SC5 fail-fast hole, run.py:740). A valid-JSON but
wrong-shape savings ledger escaped the --report fail-fast refusal:
  - top-level {} iterated zero keys -> entries=[] -> rc 0 "0,00 kr"
    (a malformed file masquerading as a real zero-savings result)
  - a bare scalar / object-with-keys / list-of-non-objects raised an
    uncaught TypeError -> traceback (violates SC5 "rc 1, no traceback")

Fix at the fail-fast boundary, not the run.py except tuple: the review's
first option (add TypeError to run.py:740) leaves the {} masquerade
because {} is an empty iteration, not a TypeError. SavingsLedger.load now
raises ValueError for a non-array top-level and a non-object row, caught
by run.py:740's existing ValueError arm. Hardens both callers
(run.py:740 report + run.py:785 portfolio).

RED-first: 6 unit cases (test_ledger) + 2 CLI rc-1 cases (test_run_cli).
452 passed; ruff + mypy clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KNNiJRk1sSwxgVLS5AobT1
This commit is contained in:
Kjell Tore Guttormsen 2026-07-24 19:52:52 +02:00
commit 7dab2dfb78
3 changed files with 65 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

26
tests/test_run_cli.py
View file

@ -356,6 +356,32 @@ def test_report_malformed_ledger_rc1(tmp_path, capsys) -> None:
assert "refused" in capsys.readouterr().err.lower()
def test_report_empty_dict_ledger_rc1(tmp_path, capsys) -> None:
"""SC5 masquerade guard: a valid-JSON ``{}`` ledger must NOT load as an empty ledger and print a
misleading ``0,00 kr`` at rc 0 — a malformed file masquerading as a real zero-savings result is
the exact failure SC5's fail-fast refusal exists to prevent."""
bad = tmp_path / "empty-obj.json"
bad.write_text("{}", encoding="utf-8")
rc = run.main(["--report", "--ledger", str(bad)])
cap = capsys.readouterr()
assert rc == 1
assert "refused" in cap.err.lower()
assert cap.out == "" # no table, no "0,00 kr"
def test_report_nonlist_ledger_rc1_no_traceback(tmp_path, capsys) -> None:
"""SC5: a valid-JSON but wrong-shape ledger (bare scalar / object-with-keys) -> rc 1 refusal, NOT
an uncaught ``TypeError`` traceback ('rc 1, no traceback')."""
bad = tmp_path / "scalar.json"
bad.write_text("42", encoding="utf-8")
rc = run.main(["--report", "--ledger", str(bad)])
cap = capsys.readouterr()
assert rc == 1
assert "refused" in cap.err.lower()
assert "Traceback" not in cap.err
assert cap.out == ""
def test_report_without_ledger_rc1_no_traceback(capsys) -> None:
"""Major-#1 guard: ``--report`` with no ``--ledger`` -> rc 1 with a 'requires --ledger' message
and no traceback (guards ``SavingsLedger.load(None)`` -> ``Path(None)`` TypeError)."""