open/portfolio-optimiser
1
0
Fork 0
Code Issues Releases 3 Activity

fix(hosting): _run_kwargs reads _REFUSED_BY_NAME instead of a hardcoded literal

Browse source 
MAJOR-2 review, fokuspunkt 4: `_REFUSED_BY_NAME = ("proposal_review",)` was
documented as the tuple the door reads, but the `if "proposal_review" in
payload` refusal never consulted it — two copies of one fact, free to drift.

Måling FØR bygging: `grep -rn 'no terminal to answer' tests/` gave 0 treff,
men `grep -rn proposal_review tests/ | grep -i hosting` fant
`test_proposal_review_loop_loadbearing.py:1677` (T21) — so half of the fact
(refusing `proposal_review` itself, with the exact CLI-pointing message) WAS
already pinned. The unpinned half was the second name: any OTHER entry added
to `_REFUSED_BY_NAME` fell through to the generic `unknown field(s)` check
instead of being refused by name before it.

Fix: `_run_kwargs` now iterates `_REFUSED_BY_NAME`; `proposal_review` keeps
its verbatim message, any other name gets a message naming the field.

New test `test_the_named_refusal_reads_the_constant_not_a_literal`
(tests/test_hosting_loadbearing.py) is unit-level against `_run_kwargs`
directly: confirms an unlisted name is refused generically (control), then
monkeypatches `_REFUSED_BY_NAME` wider and confirms the SAME payload is now
refused by name, before the generic check.

Mutation check (done and reverted): setting `_REFUSED_BY_NAME = ()`
temporarily turns the EXISTING T21 test red — proving the constant is now
load-bearing. Verified against pre-fix code that the same mutation left T21
green (the old literal-based `if` never consulted the constant at all), so
the fix closes the exact drift the review flagged.

Suite: 1368 passed / 5 skipped (was 1367/5 on 17998af), 0 regressions.
ruff + mypy clean. Golden demo-transcript.stdout byte-unchanged
(shasum -a 1 = ea8c534773acdbe41ae68f2c55724d69aaf8be4f).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-09-06 07:21:04 +02:00
commit a790ce3ae1
2 changed files with 40 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/portfolio_optimiser/hosting.py
View file

@ -141,13 +141,16 @@ def _run_kwargs(payload: Any) -> tuple[str, dict[str, Any], dict[str, Any]]:
raise InvocationRefused("body must be a JSON object")
# AFTER the object guard (a non-object body must keep its 400 rather than become a 500) and
# BEFORE the generic unknown-field check, which would otherwise answer this one first.
if "proposal_review" in payload:
raise InvocationRefused(
"proposal_review: this surface has no terminal to answer a proposal review — the "
"synchronous door would block the request on nobody, and would block the event loop "
"that answers /readiness while doing it. The operator door is the CLI's "
"--proposal-review"
)
for name in _REFUSED_BY_NAME:
if name in payload:
if name == "proposal_review":
raise InvocationRefused(
"proposal_review: this surface has no terminal to answer a proposal review "
"— the synchronous door would block the request on nobody, and would block "
"the event loop that answers /readiness while doing it. The operator door is "
"the CLI's --proposal-review"
)
raise InvocationRefused(f"{name}: this field is refused by name on this surface")
unknown = sorted(set(payload) - _ALLOWED_FIELDS)
if unknown:
raise InvocationRefused(f"unknown field(s): {', '.join(unknown)}")