open/portfolio-optimiser
1
0
Fork 0
Code Issues Releases 4 Activity

fix(okf): close the inert ingest-stamp guard, then land okf 0.8.5 -- and read the block sources form all four bases actually write

Browse source 
P13 measured this lift and REFUSED it, because okf >=0.8.5 emits the ownership
stamp as the V1 flow mapping `generated: { by: process:okf-ingest, at: ... }`
where 0.3.2 emitted `true`, and `_carries_complete_ingest_stamp` read the new
form as NOT a stamp -- write_concept_file's forgery refusal would have shipped
DISARMED with the whole fail-closed suite green. That blocker is closed first,
red-first, and then the pin moves.

ROW 1, THE SECURITY HALF. `_claims_ingest_ownership` widens the predicate from
"reads as boolean True" to "claims ingest ownership", of which the boolean is
the pre-V1 spelling. The recogniser for the new half is `decode_flow_value` --
the module's ONE flow decoder, the same argument write_concept_file already
makes for `verified`: the writer refuses exactly what the reader can read. A
value the decoder REFUSES is therefore not an ownership claim and writes
through, which is what keeps this from collapsing into "any non-empty
generated". Two arms red before the fix; no YAML library introduced.

THE PIN. okf v0.3.2 -> v0.8.5, guard v0.3.4 -> v1.4.0 spelled `tag =`, not
`rev =`, and not the declared floor 1.2.0 -- both P13 premises hold and the
reason now lives next to the pin in pyproject.toml. The ":40" comment is
corrected: okf has ONE runtime dependency, the guard, and that is what binds
the two lines together. 27/27 imported names resolve across five modules.

THE GOLDENS, REGENERATED AS A DECISION. Seven concept files across four
examples/ingest-golden-* bundles, one line each. Two were regenerated by the
REAL materializer; the other five are derived (http/sql/mcp cannot materialize
outside the tests' stubs) and then MEASURED -- all four golden suites compare
byte for byte against what the stubs produce, and all four are green. The four
`generated == "true"` asserts now read ONE source, conftest.
expected_generated_stamp: four literals for one emitter fact are four places a
later release can leave half-corrected, which is exactly how the pre-V1 form
survived until P13 measured it. tests/test_okf.py keeps its literal on purpose
-- that one round-trips a CURATED half-stamp through our own writer.

THE BLOCK READER. Measured with the full denominator: all four delivered
knowledge bases write `sources` as a BLOCK sequence and none in flow form
(n100 446/446, n200 1133/1133, n500 270/270, r761 2756/2756 = 4605/4605), and
`evidence_for` reported `unreadable` on 4605 of 4605 -- the falsification layer
had no address for any document in any base. `okf.decode_block_mappings` is the
second CARRIER of one grammar, never a second grammar: colon-SPACE separator,
unquote_scalar, duplicate keys refused, SPEC 5.2's actor rule applied. okf's
consume.read_sources was READ for the form and not called; po calls no okf
reader, which is measured and deliberate. After: 4605 present / 4605 entries.
Reading is not a licence to WRITE -- the emitter is untouched and both writers
still refuse what decode_flow_value refuses.

THREE FINDINGS. (1) The first block reader INVENTED data on `- { k: v }` items
-- SPEC-canonical, and the shape tests/golden/block-form-provenance writes for
`verified` -- decoding it as `{'{ id': '...'}`. No arm caught it: the 5.2 actor
rule shielded the fixture by accident. Closed with a flow-decoder branch and
four new arms. (2) One of my own arms was VACUOUS, found by my own mutation M5:
it claimed to prove the colon-SPACE rule and stayed green under first-colon,
because the two rules agree on every delivered value. Renamed, labelled, and
the claim moved to the arm that actually witnesses it. (3) OPEN, and it needs
the operator: the commons-owned worked example declares its second concept
`unreadable`/`block-sequence`, which is now false for po. `shared/` is
pull-only, so closing it needs a commons amendment; the test asserts the
divergence instead of skipping it, keeping the discriminating half (the example
says two entries were seen and the reader returns exactly two).

NINE EXISTING ARMS REWRITTEN, NONE WEAKENED. All nine pinned "the block form is
unreadable" -- the behaviour this order changes. Each keeps its claim on a
specimen that is still unreadable for a reason of its own (5.2: an entry naming
no actor), or pins the REVERSED direction where the old arm stood so the change
cannot be silent. Two got STRONGER: multi-verified.md was authored for "a reader
keeping the last entry reports machine-confirmed for a concept a human signed",
and that could not be tested while the form was unreadable. Three node ids were
renamed; nothing was removed in substance.

Suite 1582 -> 1606 passed / 5 skipped. Both demo goldens byte-unchanged
(ea8c534... / ede3e2f..., shasum -a 1 of the CONTENT, never the git blob id).
ruff check / ruff format / mypy green. shared/ untouched.

Six mutations, all red against the WHOLE suite, each with its own signature:
row 1 detached (2) / block reader detached (17) / flow-item branch detached (7)
/ a stray indented line folds into an INVENTED entry (4) / separator becomes the
first colon (1 -- and that is finding 2) / the stamp expectation reverts to
"true" (4).

Order: 20260912T195112Z-995611104-from-.claude
Record: docs/2026-09-12-p13b-okf-bump.md

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-09-12 23:02:38 +02:00
commit fed69790ac
25 changed files with 964 additions and 89 deletions
Download patch file Download diff file Expand all files Collapse all files

30
tests/test_falsification_skill_loadbearing.py
View file

@ -132,15 +132,29 @@ def test_the_worked_example_round_trips_through_the_real_readers(tmp_path: Path)
# because ``FalsificationEvidence.tier`` is only meaningful for the ONE key SPEC §5.3
# tiers. Branching on the primitive's own documented three-way return is test-level
# dispatch, not a second copy of production logic.
# P13b: the example's UNREADABLE concept is now READ, and that is a live divergence
# between this repo and the commons-owned artefact rather than a defect on either side.
# The example declares `state: unreadable, reason: block-sequence, items_seen: 2` for a
# SPEC §5.1 block sequence; po widened its reader to that carrier because all four
# delivered knowledge bases write it and nothing else (measured 2026-09-12: n100 446/446,
# n200 1133/1133, n500 270/270, r761 2756/2756 = 4605/4605, 0 in flow form). `shared/` is a
# PULL-ONLY subtree, so the declaration cannot be corrected from here: closing this needs a
# commons amendment, and the divergence is asserted rather than skipped so it cannot sit
# unnoticed until someone reads the prose.
#
# What still round-trips is the COUNT, and that is the discriminating half: the example
# says two entries were seen and po's reader returns exactly two, so a reader that lost an
# entry, kept one, or invented a key that is not a key still fails here.
result = okf.read_provenance(path, "sources")
assert isinstance(result, tuple), concept.concept_id
assert len(result) == concept.items_seen, concept.concept_id
if concept.state == "present":
assert isinstance(result, tuple), concept.concept_id
assert len(result) == concept.items_seen, concept.concept_id
assert concept.reason is None, concept.concept_id
else:
assert isinstance(result, okf.UnreadableProvenance), concept.concept_id
assert result.reason == concept.reason, concept.concept_id
assert result.items_seen == concept.items_seen, concept.concept_id
assert concept.reason == "block-sequence", (
"the only DECLARED-unreadable shape po now reads is the block sequence; any other "
f"reason is a real regression, got {concept.reason!r} for {concept.concept_id}"
)
# The verified half goes through the SHIPPED ``evidence_for`` on its DEFAULT key — the
# path where the tier derivation is the one §5.3 defines.
@ -150,6 +164,8 @@ def test_the_worked_example_round_trips_through_the_real_readers(tmp_path: Path)
seen_states.add(concept.state)
assert seen_states == {"present", "unreadable"}, (
"the example must exercise BOTH a readable and an unreadable concept -- one of each is what "
f"makes the round trip discriminating, got {sorted(seen_states)}"
"the example must DECLARE both a readable and an unreadable concept -- one of each is what "
f"makes the round trip discriminating, got {sorted(seen_states)}. Since P13b po READS both "
"(the declared-unreadable one is a SPEC 5.1 block sequence); the declaration is the "
"commons artefact's and can only be corrected there, see the comment above"
)