open/repo-mailbox
1
0
Fork 0
Code Issues Pull requests Releases Activity

feat(engine): harden mailbox CLIs for v0.2.0

Browse source 
- Atomic delivery: create the temp file inside the destination dir
  (dot-prefixed, invisible to the inbox glob) so the final rename never
  crosses filesystems and readers never see a half-written message.
- Reject . and .. explicitly in the --reply-to and coord-done name
  guards instead of relying on downstream failure.
- Add -h/--help to coord-inbox.sh (uniform across the three CLIs).
- Close selftest gaps: default mailbox path via HOME fallback, malformed
  frontmatter on the read path, read-only destination dir. 48 -> 64
  checks, all green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fduZz8otpU3W3rhfoPD6t
This commit is contained in:
Kjell Tore Guttormsen 2026-07-24 19:57:40 +02:00
commit 0a79e786fc
9 changed files with 80 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

55
scripts/coord-selftest.sh
View file

@ -152,6 +152,61 @@ hf="$(ls "$CLAUDE_COORD_DIR"/hygiene/inbox/*.md 2>/dev/null | head -1)"
grep -q '^subject: legit from: attacker --- INJECTED$' "$hf" 2>/dev/null; check "subject newlines collapse to spaces, content kept" $?
grep -q '^from: bad from$' "$hf" 2>/dev/null; check "from newlines collapse to spaces, content kept" $?
# 12. Uniform -h: every CLI prints its usage header and exits 0.
h1="$("$SEND" -h 2>/dev/null)"; rc=$?
[ "$rc" -eq 0 ] && printf '%s' "$h1" | grep -q 'Usage:'; check "send: -h prints usage and exits 0" $?
h2="$("$DONE" -h 2>/dev/null)"; rc=$?
[ "$rc" -eq 0 ] && printf '%s' "$h2" | grep -q 'Usage:'; check "done: -h prints usage and exits 0" $?
h3="$("$INBOX" -h 2>/dev/null)"; rc=$?
[ "$rc" -eq 0 ] && printf '%s' "$h3" | grep -q 'Usage:'; check "inbox: -h prints usage and exits 0" $?
# 13. Explicit . / .. rejection: dot names must be refused up front as invalid,
# never resolved against the filesystem (inbox/.. is the repo dir itself).
"$SEND" --to dot-repo --from dotter --subject s --message m >/dev/null
e1="$("$SEND" --from dot-repo --reply-to . --message y 2>&1)"; rc=$?
[ "$rc" -eq 2 ] && printf '%s' "$e1" | grep -q 'invalid --reply-to'; check "send: --reply-to . rejected as invalid name" $?
e2="$("$SEND" --from dot-repo --reply-to .. --message y 2>&1)"; rc=$?
[ "$rc" -eq 2 ] && printf '%s' "$e2" | grep -q 'invalid --reply-to'; check "send: --reply-to .. rejected as invalid name" $?
e3="$("$DONE" --repo dot-repo . 2>&1)"
printf '%s' "$e3" | grep -q 'invalid name'; check "done: . rejected as invalid name" $?
e4="$("$DONE" --repo dot-repo .. 2>&1)"
printf '%s' "$e4" | grep -q 'invalid name'; check "done: .. rejected as invalid name" $?
[ -n "$(ls "$CLAUDE_COORD_DIR"/dot-repo/inbox/*.md 2>/dev/null)" ]; check "dot-name attempts leave the inbox intact" $?
# 14. Atomic delivery: the temp file lives inside the destination dir, so the
# final rename never crosses filesystems. Pinned two ways: (a) an unwritable
# destination must fail at temp creation (proves the temp targets the dest
# dir, not TMPDIR), (b) normal delivery leaves no stray temp files behind.
env TMPDIR="$CLAUDE_COORD_DIR/nonexistent-tmpdir" "$SEND" --to atomic-repo --from at --subject s --message "atomic body" >/dev/null 2>&1
af="$(ls "$CLAUDE_COORD_DIR"/atomic-repo/inbox/*.md 2>/dev/null | head -1)"
[ -n "$af" ] && grep -q '^atomic body$' "$af" 2>/dev/null; check "send: delivery independent of TMPDIR" $?
stray="$(ls -A "$CLAUDE_COORD_DIR/atomic-repo/inbox" 2>/dev/null | grep -cv '\.md$')"
[ "$stray" -eq 0 ]; check "send: no stray temp files left in dest dir" $?
mkdir -p "$CLAUDE_COORD_DIR/ro-repo/inbox"
chmod 555 "$CLAUDE_COORD_DIR/ro-repo/inbox"
ro="$("$SEND" --to ro-repo --from x --subject s --message m 2>&1)"; rc=$?
[ "$rc" -eq 2 ] && printf '%s' "$ro" | grep -q 'cannot create temp'; check "send: temp file is created inside the destination dir" $?
chmod 755 "$CLAUDE_COORD_DIR/ro-repo/inbox"
# 15. Default mailbox path: empty/unset CLAUDE_COORD_DIR falls back to
# ~/.claude/coord (tested against a fake HOME, never the real mailbox).
FAKE_HOME="$CLAUDE_COORD_DIR/fake-home"
mkdir -p "$FAKE_HOME"
CLAUDE_COORD_DIR= HOME="$FAKE_HOME" "$SEND" --to def-repo --from defsender --subject s --message "default path body" >/dev/null 2>&1
df="$(ls "$FAKE_HOME"/.claude/coord/def-repo/inbox/*.md 2>/dev/null | head -1)"
[ -n "$df" ]; check "send: empty CLAUDE_COORD_DIR falls back to HOME/.claude/coord" $?
dout="$(CLAUDE_COORD_DIR= HOME="$FAKE_HOME" "$INBOX" --repo def-repo)"
printf '%s' "$dout" | grep -q "default path body"; check "inbox: default mailbox path read works" $?
# 16. Malformed frontmatter on the read path: no crash, unknown sender
# fallback, body still quoted as untrusted data.
mkdir -p "$CLAUDE_COORD_DIR/mal-repo/inbox"
printf 'no frontmatter here\njust text\n' > "$CLAUDE_COORD_DIR/mal-repo/inbox/20990101T000000Z-1-from-x.md"
mout="$("$INBOX" --repo mal-repo)"; rc=$?
[ "$rc" -eq 0 ]; check "inbox: malformed frontmatter does not crash the read path" $?
printf '%s' "$mout" | grep -q '(from unknown)'; check "inbox: missing from: falls back to unknown" $?
printf '%s' "$mout" | grep -q '^> no frontmatter here'; check "inbox: malformed body still quoted as untrusted data" $?
echo "----"
echo "PASS=$PASS FAIL=$FAIL"
[ "$FAIL" -eq 0 ]