open/repo-mailbox
1
0
Fork 0
Code Issues Releases 1 Activity

test(board): make the no-commit check fail when the row is missing

Browse source 
The check read a row that was not there and passed: an absent `repo-c` leaves
the captured line empty, and an empty string contains no day count, so the
assertion succeeded by finding nothing rather than by reading the column. Every
other new check had a real red state; this one's was "column absent", which is
a different failure than the one it claims to guard.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QS6gYYgYgJAz7VjcFHEzbb
This commit is contained in:
Kjell Tore Guttormsen 2026-07-31 11:07:35 +02:00
commit 261a75bd7b
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
scripts/board-selftest.sh
View file

@ -281,9 +281,12 @@ check "old STATE.md + fresh commit: the two ages read independently" $?
# A repo with no commits has no last commit to report. A day count there would
# be a fabricated reading, and the pre-existing -1d was exactly that.
# The -n guard is load-bearing: an absent row would leave crow empty, and an
# empty string trivially contains no day count - the check would pass by
# finding nothing rather than by reading the row.
crow="$(printf '%s\n' "$OUT" | grep '^repo-c ')"
printf '%s' "$crow" | grep -qE '[0-9]+d'; [ $? -ne 0 ]
check "repo with no commits reports no day count in either age column" $?
if [ -n "$crow" ] && ! printf '%s' "$crow" | grep -qE '[0-9]+d'; then rc=0; else rc=1; fi
check "repo with no commits reports no day count in either age column" "$rc"
# The four ranking rules stay four: SISTE is evidence the operator reads, never
# an input to the order. If it had become the sort key, repo-old (400d) would