open/repo-mailbox
1
0
Fork 0
Code Issues Releases 2 Activity

fix(coord-send): stop rejecting dot-prefixed repo names

Browse source 
coord-send.sh:154 guarded the --to target with a `.*` case arm, which
rejects every leading-dot name instead of just `.` and `..`. A
dot-prefixed name is a real repo identity (basename of a git toplevel
under a hidden directory, e.g. ~/.claude) and was reported unreachable
by morning-driver via coord message 20260809T103138Z. Narrowed the
guard to reject exactly `.` and `..`, matching the equivalent guards
already used elsewhere in this file and in coord-done.sh.

coord-count.sh and coord-sweep.sh both enumerate the mailbox root with
a bare "$COORD"/* glob, which by construction never matches a
dot-prefixed directory - confirmed empirically before this change.
Fixing only the send-side guard would have let a dot-prefixed mailbox
receive mail that neither script could ever report or close on its
grace window. Both now also glob "$COORD"/.[!.]* to reach hidden
mailboxes without matching "." or "..".

coord-selftest.sh: 183 -> 191 checks, section 30 covers the fix and
both enumeration paths. Doc counts (README badge, CLAUDE.md) updated
to match; the catalog's mirrored badge is untouched pending release.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CHmf1VfCvaYXamJxe5y6Vt
This commit is contained in:
Kjell Tore Guttormsen 2026-08-09 21:09:23 +02:00
commit f425a11311
6 changed files with 57 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

38
scripts/coord-selftest.sh
View file

@ -821,6 +821,44 @@ CLAUDE_COORD_DIR="$EDIR" "$SWEEP" --days 2>/dev/null; [ $? -eq 2 ]
check "sweep: --days without a value is a usage error, not a silent default" $?
/bin/rm -rf "$SDIR" "$EDIR" 2>/dev/null
# 30. Dot-prefixed repo names are real repos - basename of a git toplevel under
# a hidden directory, e.g. ~/.claude - and coord-send.sh's target guard used to
# reject every leading-dot name via a bare `.*` case arm, not just the `.` and
# `..` it was written to stop (reported by morning-driver 2026-08-09: ~/.claude
# could not be addressed at all). The read side never had this bug -
# coord-inbox.sh and coord-done.sh both take --repo directly, no directory
# glob - but coord-count.sh and coord-sweep.sh enumerate the mailbox root with
# a bare "$COORD"/* glob, which by construction never matches a dot-prefixed
# directory. Fixing only the send-side guard would let .dotrepo receive mail
# that coord-count.sh could never report and coord-sweep.sh could never close
# on its grace window - worse than today's clean refusal.
DDIR="$(mktemp -d)"
CLAUDE_COORD_DIR="$DDIR" "$SEND" --to .dotrepo --from d1 --subject "dot test" --message "DOT-BODY" >/dev/null
[ -n "$(ls "$DDIR/.dotrepo/inbox"/*.md 2>/dev/null)" ]; check "send: dot-prefixed repo name accepted" $?
CLAUDE_COORD_DIR="$DDIR" "$SEND" --to . --from d1 --subject x --message y >/dev/null 2>&1
[ $? -eq 2 ]; check "send: bare . target still rejected" $?
CLAUDE_COORD_DIR="$DDIR" "$SEND" --to .. --from d1 --subject x --message y >/dev/null 2>&1
[ $? -eq 2 ]; check "send: bare .. target still rejected" $?
CLAUDE_COORD_DIR="$DDIR" "$SEND" --to "../evil" --from d1 --subject x --message y >/dev/null 2>&1
[ $? -eq 2 ]; check "send: path-traversal through a dot prefix still rejected" $?
dout="$(CLAUDE_COORD_DIR="$DDIR" "$COUNT" 2>/dev/null)"
printf '%s\n' "$dout" | grep -q "^\.dotrepo${TAB}1${TAB}1$"
check "count: sees a dot-prefixed mailbox instead of skipping it" $?
# sweep uses the same enumeration as coord-count.sh, so an aged FYI inside a
# dot-prefixed mailbox has to be reachable too.
CLAUDE_COORD_DIR="$DDIR" "$SEND" --to .dotrepo --from d2 --fyi --subject "dot fyi" --message "DOT-FYI" >/dev/null
age_it "$DDIR" .dotrepo DOT-FYI 20200101T000000Z
check "sweep fixture: dot-repo fyi aged" $?
CLAUDE_COORD_DIR="$DDIR" "$SWEEP" --write >/dev/null 2>&1
grep -rq '^DOT-FYI$' "$DDIR/.dotrepo/archive" 2>/dev/null
check "sweep: closes an aged fyi inside a dot-prefixed mailbox" $?
CLAUDE_COORD_DIR="$DDIR" "$DONE" --repo .dotrepo --all >/dev/null
[ -z "$(ls "$DDIR/.dotrepo/inbox"/*.md 2>/dev/null)" ]; check "done: drains a dot-prefixed repo's inbox directly (unaffected by the bug)" $?
/bin/rm -rf "$DDIR" 2>/dev/null
echo "----"
echo "PASS=$PASS FAIL=$FAIL"
[ "$FAIL" -eq 0 ]