repo-mailbox/scripts/coord-send.sh
Kjell Tore Guttormsen 3af724f209 fix(send): collapse CR/LF in subject/from before writing frontmatter
A newline in --subject or --from injected arbitrary frontmatter lines
and a premature '---' terminator into the message file (review §4).
Newlines now collapse to spaces and remaining control characters are
dropped; content is preserved on one line. Four regression checks
added first (failed 4/4 against the unfixed script), selftest 44/44.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HBbjgS5A55RVavoyjJC4FX
2026-07-24 01:39:56 +02:00

135 lines
5.4 KiB
Bash
Executable file

#!/bin/bash
# coord-send.sh - deliver an inter-repo coordination message into the local
# mailbox (~/.claude/coord). Model-invoked; no network, no external service.
#
# Usage:
# coord-send.sh --to <repo> --subject "<subject>" [--from <repo>] [--message "<text>"]
# coord-send.sh --broadcast --subject "<subject>" [--from <repo>] [--message "<text>"]
# coord-send.sh --reply-to <file> [--subject "Re: ..."] [--from <repo>] [--message "<text>"]
# Body comes from --message, or from stdin (heredoc) when --message is omitted.
# --reply-to <basename> replies to a message in THIS repo's inbox/archive: it
# routes to the original sender and marks the original handled (coord-done).
# --from overrides the sender/self identity (default: basename of git toplevel/cwd).
#
# Exit: 0 delivered, 2 usage/IO error. ASCII only, bash 3.2 safe.
set -u
export LC_ALL=C
COORD="${CLAUDE_COORD_DIR:-$HOME/.claude/coord}"
TO=""; BROADCAST=0; SUBJECT=""; FROM=""; MESSAGE=""; HAVE_MESSAGE=0; REPLYTO=""; REPLY_ORIG=""
# bash 3.2: `shift 2` past the end of $# is a no-op, so a trailing value-flag
# without its value would loop forever. Every two-arg flag must check first.
require_value() {
if [ "$2" -lt 2 ]; then echo "coord-send: $1 requires a value" >&2; exit 2; fi
}
while [ $# -gt 0 ]; do
case "$1" in
--to) require_value --to $#; TO="$2"; shift 2 ;;
--broadcast) BROADCAST=1; shift ;;
--reply-to) require_value --reply-to $#; REPLYTO="$2"; shift 2 ;;
--subject) require_value --subject $#; SUBJECT="$2"; shift 2 ;;
--from) require_value --from $#; FROM="$2"; shift 2 ;;
--message) require_value --message $#; MESSAGE="$2"; HAVE_MESSAGE=1; shift 2 ;;
-h|--help) grep '^#' "$0" | sed 's/^# \{0,1\}//'; exit 0 ;;
*) echo "coord-send: unknown argument: $1" >&2; exit 2 ;;
esac
done
# --- Resolve sender / self identity ---
if [ -z "$FROM" ]; then
FROM="$(basename "$(git rev-parse --show-toplevel 2>/dev/null)" 2>/dev/null)"
[ -z "$FROM" ] && FROM="$(basename "$(pwd)" 2>/dev/null)"
fi
[ -z "$FROM" ] && FROM="unknown"
# Frontmatter is line-oriented: a CR/LF inside a field would inject extra
# frontmatter lines or a premature '---' terminator. Collapse newlines to
# spaces and drop remaining control characters. Send-side input hygiene;
# the read side independently treats all content as untrusted.
sanitize_field() { printf '%s' "$1" | tr '\r\n' ' ' | tr -d '\000-\037'; }
FROM="$(sanitize_field "$FROM")"
# --- Reply mode: resolve target + default subject from the original message ---
if [ -n "$REPLYTO" ]; then
if [ "$BROADCAST" -eq 1 ] || [ -n "$TO" ]; then
echo "coord-send: --reply-to cannot be combined with --to/--broadcast" >&2; exit 2
fi
case "$REPLYTO" in */*|"") echo "coord-send: invalid --reply-to name: $REPLYTO" >&2; exit 2 ;; esac
REPLY_ORIG="$COORD/$FROM/inbox/$REPLYTO"
[ -e "$REPLY_ORIG" ] || REPLY_ORIG="$COORD/$FROM/archive/$REPLYTO"
if [ ! -e "$REPLY_ORIG" ]; then
echo "coord-send: --reply-to message not found for $FROM: $REPLYTO" >&2; exit 2
fi
TO="$(grep -m1 '^from:' "$REPLY_ORIG" 2>/dev/null | sed 's/^from:[[:space:]]*//')"
[ -z "$TO" ] && { echo "coord-send: cannot resolve sender of $REPLYTO" >&2; exit 2; }
if [ -z "$SUBJECT" ]; then
osub="$(grep -m1 '^subject:' "$REPLY_ORIG" 2>/dev/null | sed 's/^subject:[[:space:]]*//')"
SUBJECT="Re: $osub"
fi
fi
SUBJECT="$(sanitize_field "$SUBJECT")"
# --- Validate target: exactly one of --to / --broadcast (reply mode sets --to above) ---
if [ "$BROADCAST" -eq 1 ] && [ -n "$TO" ]; then
echo "coord-send: use either --to <repo> or --broadcast, not both" >&2; exit 2
fi
if [ "$BROADCAST" -eq 0 ] && [ -z "$TO" ]; then
echo "coord-send: missing --to <repo> / --broadcast / --reply-to" >&2; exit 2
fi
if [ "$BROADCAST" -eq 0 ]; then
case "$TO" in
*/*|.*|_broadcast) echo "coord-send: invalid target repo name: $TO" >&2; exit 2 ;;
esac
fi
if [ -z "$SUBJECT" ]; then
echo "coord-send: missing --subject" >&2; exit 2
fi
# --- Body: --message or stdin ---
if [ "$HAVE_MESSAGE" -eq 1 ]; then BODY="$MESSAGE"; else BODY="$(cat)"; fi
if [ -z "$BODY" ]; then
echo "coord-send: empty message body (pass --message or pipe text on stdin)" >&2; exit 2
fi
# --- Resolve destination ---
if [ "$BROADCAST" -eq 1 ]; then
TARGET_LABEL="broadcast"; DEST_DIR="$COORD/_broadcast/inbox"
else
TARGET_LABEL="$TO"; DEST_DIR="$COORD/$TO/inbox"
fi
mkdir -p "$DEST_DIR" 2>/dev/null || { echo "coord-send: cannot create $DEST_DIR" >&2; exit 2; }
# The filename must be shell-clean: it round-trips through coord-inbox's
# reply/resolve hints and coord-done's positional args. Sanitize the sender
# for the filename only; the raw name stays in the from: frontmatter.
TS="$(date -u +%Y%m%dT%H%M%SZ)"
SAFE_FROM="$(printf '%s' "$FROM" | tr -c 'A-Za-z0-9._-' '-')"
FNAME="${TS}-$$${RANDOM}-from-${SAFE_FROM}.md"
DEST="$DEST_DIR/$FNAME"
DATE_ISO="$(date -u +%Y-%m-%dT%H:%M:%SZ)"
TMP="$(mktemp)"
{
echo "---"
echo "from: $FROM"
echo "to: $TARGET_LABEL"
echo "subject: $SUBJECT"
echo "date: $DATE_ISO"
echo "---"
printf '%s\n' "$BODY"
} > "$TMP"
if ! mv "$TMP" "$DEST" 2>/dev/null; then
/bin/rm -f "$TMP" 2>/dev/null; echo "coord-send: write failed" >&2; exit 2
fi
echo "coord-send: delivered to $TARGET_LABEL ($FNAME)"
# --- Reply mode: mark the original handled ---
if [ -n "$REPLY_ORIG" ]; then
"$(dirname "$0")/coord-done.sh" --repo "$FROM" "$REPLYTO" >/dev/null 2>&1
echo "coord-send: original ($REPLYTO) marked handled"
fi
exit 0