repo-mailbox/scripts/coord-order-done.sh
Kjell Tore Guttormsen c519ab4994 feat(orders): order queue channel with atomic claim, board ORDRE column
ORDRE 59. A dispatched order used to live only in a scratch prompt file
passed through argv, so it died with the pane it was typed into. Measured
2026-08-17: one order was dispatched three times over 90 minutes before it
was worked, because the first two tabs ran something else and the order
left no trace in the receiving repo at all.

New channel `~/.claude/coord/<repo>/orders/`, beside `inbox/` and never
merged with it. The axis is authorization: inbox content is untrusted
cross-repo data that may never instruct a session (Rule 6), a dispatch
order is operator-authorized work by construction. One channel carrying
both classes would mean either mail that can instruct or orders that
cannot, so the infrastructure is reused and the channel is not.

Four one-verb engines: coord-order-send.sh (write), coord-order-inbox.sh
(read, writes nothing at all), coord-order-claim.sh (atomic claim),
coord-order-done.sh (executed with a commit pointer / --no-commit with a
reason / --return with a reason).

The claim is a rename with no check-then-act step, so of N racing sessions
exactly one finds the source and the rest get ENOENT. The test that proves
it spawns 20 claimers BARRIERED on a start flag - unbarriered children do
not race at all - and runs the identical harness against a deliberately
racy `[ -e src ] && cp && rm` as a known-negative control, which must
produce many winners. Without that control, "exactly one winner" is
indistinguishable from "the race never happened".

Channel separation is pinned structurally, not only behaviourally: no mail
script may contain the string `orders`, with a known-positive control
proving the grep can find. coord-done cannot archive an order and
coord-order-claim cannot claim a message.

board gains an ORDRE column beside INN, counted with the identical idiom
and never summed with it: INN is "others are waiting on YOU", ORDRE is
"work is waiting on this REPO". Claimed orders are excluded - the column
answers what a session can pick up. board.sh --dispatch --order-id emits a
thin starter carrying only the id and the four steps, so the order text has
exactly one home; the id is validated shell-clean and must be pending in
the target's queue.

SessionStart injects the queue as its own block below the mailbox block.
Two channels, two blocks, mail first: it carries Rule 7, and the queue
order is mail -> orders -> STATE's NESTE.

Also folds in dde392d (board prefix-match fix), which landed after the
0.26.0 bump and before any tag. v0.26.0 was never tagged, so 0.27.0 is the
release that carries all of it.

Suites: coord 220, board 237, route 69, orders 97, guard 40; npm test 11/11.
Antakelse 4 (atomic claim) and antakelse 6 (morning --plan-file --dry-run
reports 1 of 1 for the thin starter) both measured, not assumed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134iB7ipXGgEpv9imYoVmr2
2026-08-17 21:17:17 +02:00

119 lines
5.4 KiB
Bash
Executable file

#!/bin/bash
# coord-order-done.sh - drive a CLAIMED order to a terminal state. ASCII only,
# bash 3.2 safe.
#
# Usage:
# coord-order-done.sh [--repo <name>] <order-id> --commit <hash>
# coord-order-done.sh [--repo <name>] <order-id> --no-commit --reason "<why>"
# coord-order-done.sh [--repo <name>] <order-id> --return --reason "<why>"
#
# Three modes, mutually exclusive, one of them required:
# --commit <hash> executed. Archived with a RESULT POINTER - the hash is
# what makes "done" checkable by someone who was not there.
# --no-commit executed with nothing to commit (a measurement, a
# verification). Costs a stated --reason precisely so it
# cannot quietly become the default way to close an order.
# --return not executed. Goes BACK to pending with the reason
# recorded IN the order, so whoever picks it up next sees
# why the last session put it down. Never a silent drop.
#
# Only ever looks in orders/claimed/. It cannot touch the coordination inbox,
# and coord-done.sh cannot touch an order: the two channels have separate
# verbs on purpose, and orders-selftest.sh section 4 pins both directions.
#
# Exit: 0 closed, 1 no such claimed order (nothing written), 2 usage error.
set -u
export LC_ALL=C
COORD="${CLAUDE_COORD_DIR:-$HOME/.claude/coord}"
REPO=""; ORDER_ID=""; COMMIT=""; REASON=""; MODE=""
set_mode() {
if [ -n "$MODE" ] && [ "$MODE" != "$1" ]; then
echo "coord-order-done: --commit, --no-commit and --return are mutually exclusive" >&2; exit 2
fi
MODE="$1"
}
while [ $# -gt 0 ]; do
case "$1" in
# bash 3.2: `shift 2` past the end of $# is a no-op -> would loop forever.
--repo) [ $# -ge 2 ] || { echo "coord-order-done: --repo requires a value" >&2; exit 2; }
REPO="$2"; shift 2 ;;
--commit) [ $# -ge 2 ] || { echo "coord-order-done: --commit requires a value" >&2; exit 2; }
set_mode executed; COMMIT="$2"; shift 2 ;;
--no-commit) set_mode no-commit; shift ;;
--return) set_mode returned; shift ;;
--reason) [ $# -ge 2 ] || { echo "coord-order-done: --reason requires a value" >&2; exit 2; }
REASON="$2"; shift 2 ;;
-h|--help) grep '^#' "$0" | sed 's/^# \{0,1\}//'; exit 0 ;;
-*) echo "coord-order-done: unknown argument: $1" >&2; exit 2 ;;
*) [ -n "$ORDER_ID" ] && { echo "coord-order-done: one order id at a time" >&2; exit 2; }
ORDER_ID="$1"; shift ;;
esac
done
if [ -z "$REPO" ]; then
REPO="$(basename "$(git rev-parse --show-toplevel 2>/dev/null)" 2>/dev/null)"
fi
[ -z "$REPO" ] && { echo "coord-order-done: cannot resolve repo (not inside a git repo); pass --repo <repo>" >&2; exit 2; }
case "$REPO" in
_*) echo "coord-order-done: $REPO is a reserved engine namespace, not a repo" >&2; exit 2 ;;
esac
[ -n "$ORDER_ID" ] || { echo "coord-order-done: order id required" >&2; exit 2; }
ORDER_ID="$(printf '%s' "$ORDER_ID" | sed 's/\.md$//')"
case "$ORDER_ID" in
*/*|.|..|"") echo "coord-order-done: invalid order id: $ORDER_ID" >&2; exit 2 ;;
esac
case "$MODE" in
"") echo "coord-order-done: one of --commit <hash> / --no-commit --reason <why> / --return --reason <why> is required" >&2; exit 2 ;;
executed) [ -n "$COMMIT" ] || { echo "coord-order-done: --commit requires a hash" >&2; exit 2; } ;;
# A reason is the whole content of these two states. Without it "returned"
# is a silent drop with extra steps, and --no-commit is "trust me".
no-commit) [ -n "$REASON" ] || { echo "coord-order-done: --no-commit requires --reason \"<why there is nothing to commit>\"" >&2; exit 2; } ;;
returned) [ -n "$REASON" ] || { echo "coord-order-done: --return requires --reason \"<why you are putting it back>\"" >&2; exit 2; } ;;
esac
# Same line-orientation rule as the send side: the trailer is one line, and a
# newline inside it would forge a second one.
sanitize_field() { printf '%s' "$1" | tr '\r\n' ' ' | tr -d '\000-\037'; }
COMMIT="$(sanitize_field "$COMMIT")"
REASON="$(sanitize_field "$REASON")"
# The trailer is an HTML comment, so a '-->' inside a reason would close it
# early and leave the rest as body prose.
REASON="$(printf '%s' "$REASON" | sed 's/--*>/-->/g; s/-->/ /g')"
ORDERS="$COORD/$REPO/orders"
CLAIMED="$ORDERS/claimed"
ARCHIVE="$ORDERS/archive"
SRC="$CLAIMED/$ORDER_ID.md"
[ -e "$SRC" ] || { echo "coord-order-done: no claimed order $ORDER_ID for $REPO (already closed, never claimed, or the wrong id)" >&2; exit 1; }
STAMP="$(date -u +%Y-%m-%dT%H:%M:%SZ)"
if [ "$MODE" = "returned" ]; then
printf '\n<!-- order-returned: at=%s; by=%s; reason=%s -->\n' "$STAMP" "$REPO" "$REASON" >> "$SRC"
DEST="$ORDERS/$ORDER_ID.md"
WORD="returned to the queue"
else
if [ "$MODE" = "executed" ]; then
printf '\n<!-- order-result: executed; commit=%s; at=%s -->\n' "$COMMIT" "$STAMP" >> "$SRC"
else
printf '\n<!-- order-result: executed; commit=none; at=%s; why=%s -->\n' "$STAMP" "$REASON" >> "$SRC"
fi
mkdir -p "$ARCHIVE" 2>/dev/null || { echo "coord-order-done: cannot create $ARCHIVE" >&2; exit 2; }
DEST="$ARCHIVE/$ORDER_ID.md"
WORD="archived"
fi
if ! mv "$SRC" "$DEST" 2>/dev/null; then
echo "coord-order-done: could not move $ORDER_ID to $DEST" >&2; exit 2
fi
# The claim marker is delivery state, not history: once the order has left
# orders/claimed/ a marker there would make a closed order look in flight.
/bin/rm -f "$CLAIMED/$ORDER_ID.claim" 2>/dev/null
echo "coord-order-done: $ORDER_ID $WORD for $REPO"
exit 0