open/repo-standard
1
0
Fork 0
Code Issues Releases 7 Activity

fix(gate): the reader sets a link's level, and a repo's name is its remote

Browse source 
Two defects that only org-wide measurement exposes. Both were found by running
the gate against seventeen repositories, not by reading the code.

Link level follows the reader. 30 of 43 LINK-INTERNAL-MISSING findings sat in
`shared/`, `docs/plan/` and `.claude/` -- session plans, agent working files,
and path-traversal fixtures whose targets are invalid on purpose. All 30 were
ERRORs. portfolio-optimiser scored 19 ERRORs and 15 of them were noise. A gate
that wrong gets switched off, so root documents stay ERROR and everything below
becomes WARN. Only the level moves; the finding keeps its file and line.

The OK line had to move with it: it asserted "every resolvable relative link
resolves" whenever no ERROR was present, which would have printed it beside a
pile of WARNs saying the opposite.

The repo name comes from `git remote get-url origin`. `catalog/` is the working
directory of `ktg-plugin-marketplace`; the basename left it REPO-UNREGISTERED
with zero checks run -- against the one repo every catalog rule depends on. The
scp form is handled because the forge's clone button hands it out, and a bare
host is not a repo name (that test caught a real bug: `https://host/` parsed as
a repo named after the host).

Re-measured: portfolio-optimiser 19 ERROR -> 4, all four genuine. catalog now
reports as `ktg-plugin-marketplace [catalog]` and runs its full rule set.

Still v0.1.0: nothing is pushed, no tag exists, no consumer has seen it.

77 -> 84 tests.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EeNsGsWukggfmLQ926WZPx
This commit is contained in:
Kjell Tore Guttormsen 2026-08-03 19:53:57 +02:00
commit 9fcceb7522
5 changed files with 143 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

42
scripts/repo-standard-check.mjs
View file

@ -562,6 +562,17 @@ export function resolveRelative(fromFile, target) {
return out.join('/');
}
// Who the reader is decides the level. A dead link in a root document — README,
// CHANGELOG, SECURITY — is in the shop window and blocks a stranger. The same
// link three directories down is in a session plan, an agent working file, or a
// test fixture whose target is invalid ON PURPOSE. Measured across the org: 30
// of 43 findings sat below the root, and every one of them was an ERROR. A gate
// that is wrong that often gets switched off, so the level moves — and only the
// level. The finding is still reported, with its file and line.
function linkLevelFor(path) {
return String(path).includes('/') ? 'WARN' : 'ERROR';
}
// Relative file links only. Anchor resolution depends on per-renderer heading
// slug rules and is a rabbit hole; external URLs need the network. Both are
// deliberately out — a check that is sometimes wrong teaches people to ignore it.
@ -591,7 +602,7 @@ export function checkInternalLinks({ files, present }) {
}
if (!have.has(resolved)) {
findings.push({
level: 'ERROR',
level: linkLevelFor(path),
code: 'LINK-INTERNAL-MISSING',
bucket: 'broken',
msg: `${path}:${i + 1} — link points at \`${clean}\` (${resolved}), which is not a tracked file`,
@ -600,7 +611,9 @@ export function checkInternalLinks({ files, present }) {
}
});
}
if (!findings.some((f) => f.level === 'ERROR')) {
// The OK line asserts that every link resolved. Keying it on ERROR alone would
// have printed it beside a pile of WARN findings saying the opposite.
if (!findings.some((f) => f.code === 'LINK-INTERNAL-MISSING')) {
findings.push({ level: 'OK', code: 'LINKS-INTERNAL', msg: 'every resolvable relative link resolves' });
}
return findings;
@ -706,7 +719,32 @@ function gitFiles(dir) {
}
}
// The remote is ground truth for what a repo is CALLED; the directory is only
// where it happens to sit. `catalog/` is the working directory of the repo named
// `ktg-plugin-marketplace`, and deriving the name from the basename left it
// REPO-UNREGISTERED — zero checks run against the one repo the catalog rule
// depends on. Handles the scp form too: the forge's clone button hands it out.
export function parseRepoNameFromRemote(url) {
const raw = String(url ?? '').trim();
if (!raw) return null;
const path = raw.includes('://') ? raw.split('://')[1] : raw;
const segments = path.replace(/\/+$/, '').split(/[/:]/).filter(Boolean);
// A bare host is not a repository. Without this, `https://the-forge/` parsed
// as a repo named after the host and every class rule matched the wrong thing.
if (segments.length < 2) return null;
const name = segments.pop().replace(/\.git$/, '');
return name || null;
}
function repoNameFrom(dir) {
try {
const remote = execFileSync('git', ['-C', dir, 'remote', 'get-url', 'origin'], {
encoding: 'utf8',
stdio: ['ignore', 'pipe', 'ignore'],
});
const fromRemote = parseRepoNameFromRemote(remote);
if (fromRemote) return fromRemote;
} catch { /* no remote yet — a repo before its first push is the ordinary case */ }
try {
return basename(execFileSync('git', ['-C', dir, 'rev-parse', '--show-toplevel'], { encoding: 'utf8' }).trim());
} catch {