fix(engine): the affirmative TAGS-SIGNED was suppressed by its own exemption OK
Gated on `findings.length === 0`, so a TAG-SIGNED-PREPOLICY OK silenced it — and every repo in the org has pre-policy tags, which made the affirmative verdict near-unreachable in practice. Caught by dogfooding v0.11.0: this repo signed the first tag the check ever judged, and the gate did not say so. Status was green either way, which is exactly why it was worth fixing — a reader could not tell "signed its new tag" from "has cut no tag since the policy". Two different facts wearing one silence, which is the defect this engine already refuses to ship one check over, where an exemption nobody can see reads like a check that stopped running. Keys the affirmative on the JUDGED findings only. Measured after: 18 repos emit both codes, 3 NONE, still 0 ERROR / 0 WARN. 243 tests, from 241. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XsPsVsvhrSaejK3cLPmnN2
This commit is contained in:
parent
e6cd8983ca
commit
f422b63bb3
7 changed files with 63 additions and 9 deletions
20
CHANGELOG.md
20
CHANGELOG.md
|
|
@ -6,6 +6,26 @@ versioning is [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
|
|||
|
||||
## [Unreleased]
|
||||
|
||||
## [0.11.1] — 2026-08-13
|
||||
|
||||
### Fixed
|
||||
|
||||
- **`TAGS-SIGNED`, the affirmative verdict, was near-unreachable.** It was gated
|
||||
on `findings.length === 0`, so the presence of a `TAG-SIGNED-PREPOLICY` `OK`
|
||||
suppressed it — and every repo in the org has pre-policy tags. Caught by
|
||||
dogfooding the v0.11.0 release: this repo signed the first tag the check ever
|
||||
judged, and the gate did not say so.
|
||||
|
||||
The status was green either way, which is what made it worth fixing rather
|
||||
than shrugging at: a reader could not tell *this repo signed its new tag* from
|
||||
*this repo has cut no tag since the policy*. Two different facts wearing one
|
||||
silence — the same defect as an exemption nobody can see, which this engine
|
||||
already refuses to ship one check over. The gate now keys the affirmative on
|
||||
the JUDGED findings only, and the two cases carry different sentences.
|
||||
|
||||
Measured after: 18 repos emit both `TAGS-SIGNED` and `TAG-SIGNED-PREPOLICY`,
|
||||
3 `TAG-SIGNED-NONE`, still 0 ERROR and 0 WARN. 243 tests, from 241.
|
||||
|
||||
## [0.11.0] — 2026-08-13
|
||||
|
||||
### Added
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue