test(red-proof): fix round 4.5b part 3 red proof and regression run

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/fix-round-4-5b-part-3-mutations.mjs

@@ -0,0 +1,10 @@
+// tests/fix-round-4-5b-part-3-mutations.mjs
+// The mutations of fix round 4-5b, part 3, for the shared red script
+// (tests/helpers/red-round.sh, through tests/helpers/red-mutate.mjs). The
+// round has none: every part-3 id (CQW, PQO, KI3) has tests that fail on an
+// assertion at the round's start point ce98f62, on that id's own code or
+// text, so no id needs a mutation to be proven red. red-mutate.mjs list
+// accepts the empty array, and the red script then reports 0 mutation(s).
+// Data only; never matched by `npm test`.
+
+export const MUTATIONS = [];

tests/fix-round-4-5b-part-3-red.sh

@@ -0,0 +1,49 @@
+#!/usr/bin/env bash
+# tests/fix-round-4-5b-part-3-red.sh
+# The red proof of fix round 4-5b, part 3 (plan
+# .claude/projects/2026-10-28-fix-round-4-5b-part-3), as a wrapper over the
+# shared red script tests/helpers/red-round.sh. Every id of the round has
+# tests whose names start with "[id]"; each of them must fail on an assertion
+# at the round's start point ce98f62.
+# This wrapper passes the shared script:
+#   --base BASE, --ids IDS (the round's 3 ids), the round's FILES;
+#   --other-ids: the ids of fix round 4-5a, of 4-5b part 1 and of 4-5b
+#     part 2, read with sed from the IDS= lines of tests/fix-round-4-5a-red.sh,
+#     tests/fix-round-4-5b-red.sh and tests/fix-round-4-5b-part-2-red.sh and
+#     passed as ONE value, in that order (the shared script keeps only the
+#     last --other-ids it is given); a tag on that list is not judged;
+#   --mutations tests/fix-round-4-5b-part-3-mutations.mjs (empty: every id is
+#     red at the start point on its own code or text).
+# No --require-sha256: the round has no SHA-256 test.
+# Exit 0 all red, 1 a rule broken (the judge names it), 2 a setup failure
+# (also: no ids on one of the three older IDS= lines); never 0 on a setup
+# failure.
+# bash 3.2 compatible, ASCII only, no arrays.
+
+set -u
+set -f
+
+cd "$(dirname "$0")/.." || { echo "red script: setup failure: cannot cd to the repo root" >&2; exit 2; }
+ROOT="$(pwd -P)"
+
+BASE=ce98f62e82af1e2c5c33cbe63808b7ec52cac000
+IDS='CQW PQO KI3'
+FILES='tests/lib/arg-parser-closing-quote.test.mjs tests/hooks/bash-guard-opener-word.test.mjs tests/lib/fix-round-4-5b-part-3-prose.test.mjs'
+
+OTHER_A=$(sed -n "s/^IDS='\(.*\)'\$/\1/p" "$ROOT/tests/fix-round-4-5a-red.sh")
+if [ -z "$OTHER_A" ]; then
+  echo "red script: setup failure: no ids on the IDS= line of $ROOT/tests/fix-round-4-5a-red.sh" >&2
+  exit 2
+fi
+OTHER_B=$(sed -n "s/^IDS='\(.*\)'\$/\1/p" "$ROOT/tests/fix-round-4-5b-red.sh")
+if [ -z "$OTHER_B" ]; then
+  echo "red script: setup failure: no ids on the IDS= line of $ROOT/tests/fix-round-4-5b-red.sh" >&2
+  exit 2
+fi
+OTHER_C=$(sed -n "s/^IDS='\(.*\)'\$/\1/p" "$ROOT/tests/fix-round-4-5b-part-2-red.sh")
+if [ -z "$OTHER_C" ]; then
+  echo "red script: setup failure: no ids on the IDS= line of $ROOT/tests/fix-round-4-5b-part-2-red.sh" >&2
+  exit 2
+fi
+
+exec /bin/bash "$ROOT/tests/helpers/red-round.sh" --base "$BASE" --ids "$IDS" --other-ids "$OTHER_A $OTHER_B $OTHER_C" --mutations "$ROOT/tests/fix-round-4-5b-part-3-mutations.mjs" $FILES

tests/fix-round-4-5b-part-3-regression.sh

@@ -0,0 +1,40 @@
+#!/usr/bin/env bash
+# tests/fix-round-4-5b-part-3-regression.sh
+# The Regression: of fix round 4-5b, part 3: the whole suite (npm test),
+# part 2's end to end (tests/e2e-fix-round-4-5b-part-2.sh, which drives the
+# arg parser and the args-heredoc guard, both changed by part 3), part 1's
+# end to end (tests/e2e-fix-round-4-5b.sh, which drives the arg parser) and
+# part 3's red proof (tests/fix-round-4-5b-part-3-red.sh). The 4-5a, part-1
+# and part-2 red proofs are not run here: one Regression command has the
+# criteria runner's 15-minute cap; they run as their own Verification lines.
+# All four run; the script prints each exit and exits with the first non-zero
+# status, or 0 when all four exit 0.
+# bash 3.2 compatible, ASCII only, no arrays.
+
+set -u
+
+cd "$(dirname "$0")/.." || { echo "regression: cannot cd to the repo root" >&2; exit 2; }
+
+FIRST=0
+
+npm test
+rc=$?
+echo "regression: npm test exited $rc"
+[ "$FIRST" -eq 0 ] && FIRST=$rc
+
+/bin/bash tests/e2e-fix-round-4-5b-part-2.sh
+rc=$?
+echo "regression: tests/e2e-fix-round-4-5b-part-2.sh exited $rc"
+[ "$FIRST" -eq 0 ] && FIRST=$rc
+
+/bin/bash tests/e2e-fix-round-4-5b.sh
+rc=$?
+echo "regression: tests/e2e-fix-round-4-5b.sh exited $rc"
+[ "$FIRST" -eq 0 ] && FIRST=$rc
+
+/bin/bash tests/fix-round-4-5b-part-3-red.sh
+rc=$?
+echo "regression: tests/fix-round-4-5b-part-3-red.sh exited $rc"
+[ "$FIRST" -eq 0 ] && FIRST=$rc
+
+exit "$FIRST"

tests/lib/fix-round-4-5b-part-3-scripts.test.mjs

@@ -0,0 +1,124 @@
+// tests/lib/fix-round-4-5b-part-3-scripts.test.mjs
+// The form of fix round 4-5b part 3's three shell scripts (plan
+// .claude/projects/2026-10-28-fix-round-4-5b-part-3, Step 4c): the red
+// wrapper, the regression script and the end-to-end run. Untagged on purpose
+// and listed in no red wrapper's FILES: these checks are not a part-3 fix.
+//   - each script exists, is ASCII only, passes /bin/bash -n and uses no
+//     bash 4 form;
+//   - the red wrapper hands the shared red script exactly one --other-ids,
+//     whose words are the 4-5a IDS= words, then part 1's, then part 2's, and
+//     --ids CQW PQO KI3 (run from a temp root next to a stub red-round.sh
+//     that prints its arguments, the method of tests/lib/red-script.test.mjs);
+//   - with the 4-5a, the part-1 or the part-2 wrapper lacking its IDS= line,
+//     the red wrapper exits 2 with a setup failure and never runs the shared
+//     script.
+
+import { test } from 'node:test';
+import { strict as assert } from 'node:assert';
+import { spawnSync } from 'node:child_process';
+import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { childEnv } from '../helpers/child-env.mjs';
+
+const ROOT = join(dirname(fileURLToPath(import.meta.url)), '..', '..');
+
+const RED = 'tests/fix-round-4-5b-part-3-red.sh';
+const REGRESSION = 'tests/fix-round-4-5b-part-3-regression.sh';
+const E2E = 'tests/e2e-fix-round-4-5b-part-3.sh';
+const WRAP_A = 'tests/fix-round-4-5a-red.sh';
+const WRAP_B = 'tests/fix-round-4-5b-red.sh';
+const WRAP_C = 'tests/fix-round-4-5b-part-2-red.sh';
+const PART3_IDS = ['CQW', 'PQO', 'KI3'];
+
+/** A repo file's bytes; the file must exist. */
+function bytes(rel) {
+  assert.ok(existsSync(join(ROOT, rel)), `missing file ${rel}`);
+  return readFileSync(join(ROOT, rel));
+}
+
+/** The words of a wrapper's one IDS='...' line. */
+function idsOf(rel) {
+  const lines = bytes(rel).toString('utf8').split('\n').filter((l) => l.startsWith('IDS='));
+  assert.equal(lines.length, 1, `expected one IDS= line in ${rel}; found ${lines.length}`);
+  const m = lines[0].match(/^IDS='([^']*)'$/);
+  assert.ok(m, `the IDS= line of ${rel} is not one single-quoted list: ${lines[0]}`);
+  return m[1].split(/\s+/).filter(Boolean);
+}
+
+test('part-3 scripts: each exists, is ASCII only, passes /bin/bash -n and uses no bash 4 form', () => {
+  for (const rel of [RED, REGRESSION, E2E]) {
+    const buf = bytes(rel);
+    assert.equal(buf.findIndex((b) => b > 127), -1, `${rel} is not ASCII only`);
+    const r = spawnSync('/bin/bash', ['-n', join(ROOT, rel)], { encoding: 'utf8', env: childEnv() });
+    assert.equal(r.status, 0, `${rel} does not pass /bin/bash -n: ${r.stderr}`);
+    const text = buf.toString('utf8');
+    for (const bash4 of [/\bdeclare -A\b/, /\bmapfile\b/, /\breadarray\b/, /\|&/, /^\s*[A-Za-z_]+=\(/m,
+      /\$\{[A-Za-z_]+,,\}/, /\$\{[A-Za-z_]+\^\^\}/]) {
+      assert.doesNotMatch(text, bash4, `${rel} uses ${bash4}, which bash 3.2 lacks`);
+    }
+  }
+});
+
+/** A stand-in for the shared script: one ARG: line per argument, exit 0. */
+const STUB = `#!/bin/bash
+for a in "$@"; do printf 'ARG:%s\\n' "$a"; done
+exit 0
+`;
+
+/** A temp root with the part-3 wrapper, the three older wrappers and the stub as tests/helpers/red-round.sh. */
+function stubRoot(base) {
+  const dir = join(base, 'root');
+  mkdirSync(join(dir, 'tests', 'helpers'), { recursive: true });
+  for (const rel of [RED, WRAP_A, WRAP_B, WRAP_C]) writeFileSync(join(dir, rel), bytes(rel));
+  writeFileSync(join(dir, 'tests', 'helpers', 'red-round.sh'), STUB, { mode: 0o755 });
+  return dir;
+}
+
+/** The part-3 wrapper run from a temp root: status, output and the arguments the stub saw. */
+function runWrapper(dir) {
+  const r = spawnSync('/bin/bash', [join(dir, RED)], { cwd: tmpdir(), encoding: 'utf8', timeout: 30000, env: childEnv() });
+  const argv = (r.stdout || '').split('\n').filter((l) => l.startsWith('ARG:')).map((l) => l.slice(4));
+  return { status: r.status, out: `${r.stdout}${r.stderr}`, stderr: r.stderr || '', argv };
+}
+
+test('part-3 scripts: the red wrapper passes one --other-ids, the 4-5a, part-1 and part-2 ids in order, and its own three ids', () => {
+  const text = bytes(RED).toString('utf8');
+  const execLines = text.split('\n').filter((l) => /^exec /.test(l));
+  assert.equal(execLines.length, 1, `${RED} must hold one exec line; found ${execLines.length}`);
+  assert.equal(execLines[0].split('--other-ids').length - 1, 1, `${RED}: the exec line must pass --other-ids exactly once: ${execLines[0]}`);
+
+  const base = mkdtempSync(join(tmpdir(), 'part3-red-wrap-'));
+  try {
+    const r = runWrapper(stubRoot(base));
+    assert.equal(r.status, 0, `${RED} did not run the shared script:\n${r.out}`);
+    const at = r.argv.map((a, i) => (a === '--other-ids' ? i : -1)).filter((i) => i >= 0);
+    assert.equal(at.length, 1, `${RED} handed the shared script --other-ids ${at.length} times:\n${r.out}`);
+    const other = (r.argv[at[0] + 1] || '').split(/\s+/).filter(Boolean);
+    assert.deepEqual(other, [...idsOf(WRAP_A), ...idsOf(WRAP_B), ...idsOf(WRAP_C)],
+      `${RED}: --other-ids is not the IDS= words of ${WRAP_A}, then ${WRAP_B}, then ${WRAP_C}\n${r.out}`);
+    const idsAt = r.argv.indexOf('--ids');
+    assert.ok(idsAt >= 0, `${RED} passed no --ids:\n${r.out}`);
+    assert.deepEqual(r.argv[idsAt + 1].split(/\s+/).filter(Boolean), PART3_IDS, `${RED}: --ids is not ${PART3_IDS.join(' ')}\n${r.out}`);
+  } finally {
+    rmSync(base, { recursive: true, force: true });
+  }
+});
+
+test('part-3 scripts: the red wrapper exits 2 with a setup failure when an older wrapper has no IDS= line', () => {
+  for (const missing of [WRAP_A, WRAP_B, WRAP_C]) {
+    const base = mkdtempSync(join(tmpdir(), 'part3-red-noids-'));
+    try {
+      const dir = stubRoot(base);
+      const text = bytes(missing).toString('utf8');
+      writeFileSync(join(dir, missing), text.split('\n').filter((l) => !l.startsWith('IDS=')).join('\n'));
+      const r = runWrapper(dir);
+      assert.equal(r.status, 2, `${RED}: ${missing} without an IDS= line is not exit 2\n${r.out}`);
+      assert.match(r.stderr, /setup failure/, `${RED}: no setup failure line when ${missing} has no IDS= line\n${r.out}`);
+      assert.deepEqual(r.argv, [], `${RED} ran the shared script though ${missing} has no IDS= line\n${r.out}`);
+    } finally {
+      rmSync(base, { recursive: true, force: true });
+    }
+  }
+});