fix: round 3 of the release review of 6.3.0
Round 3 (v6.2.0..96cb977, BLOCK: 1 BLOCKER, 8 MAJOR, 2 MINOR), each fixed behind a test that failed first. - Every allowlisted runner, not only git, takes plain words and a short list of options that only read: an option that writes a file or loads code (--test-reporter-destination, --outputFile, --junitxml, --basetemp, --import, --config, -p, -o, -exec, a reporter path) is on no list; after `npm test --` only paths follow; `make test` takes no VAR=value. A built-in node test reporter (tap, spec, dot, junit, lcov) stays allowed. - /trekexecute: a restore the guard refuses (destructive git, in the mode that shows no prompts) or the operator declines is never recorded as reverted: simplify = "revert-refused" and the run stops before review; a refused step revert is reported with its paths. - stepTestsOnly: a fixture document under tests/ is a test file, "e.g." is not a path, ./ is dropped; the plan-file sweep reads Files: with the same reader (fieldPaths); the validator hands its parsed fields over. - plan-validator --steps-from asks for Verify: on a 1.8 plan too. - skill frontmatter: a value starting with # is a hazard; a quote after an escaped backslash closes the value. Routing reads kind tags with hasOwn. - release-check reads scope_sha_end as written (an all-digit sha keeps its leading zero), and Voyage's own artifacts under .claude/projects/ and .claude/voyage/ committed after the review do not count as unreviewed. Suite 2170 (2168/0/2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
96cb977856
commit
0e612c88ac
14 changed files with 284 additions and 40 deletions
|
|
@ -1863,6 +1863,12 @@ directly (Sub-step B).
|
|||
```
|
||||
The new files stay on disk, untracked, and `step-{N}-upward.md` names them —
|
||||
nothing the step made is deleted, and none of it is left registered.
|
||||
When the guard refuses the restore (it is destructive git: in the permission
|
||||
mode that shows no prompts the guard refuses it, exit 2, "no one to ask"), or
|
||||
the operator declines it, nothing was restored: write in `step-{N}-upward.md`
|
||||
and the final report that the step's changes are still in the working tree,
|
||||
with the paths, and that the operator restores them by hand. Never call the
|
||||
step reverted.
|
||||
Record failure. **Do NOT proceed to next step.** Jump to Phase 7.5 (Phase 7
|
||||
runs only when every step passed).
|
||||
|
||||
|
|
@ -2177,6 +2183,14 @@ never typed by the operator, in this order (Cherny's):
|
|||
`refactor: simplify pass (trekexecute)`; `simplify = "applied"`. Exit 1 or
|
||||
2 → restore every path it changed as above, `simplify = "reverted"`, and
|
||||
say why in the report: the cleanup broke the verification.
|
||||
- **A restore did not run** (the guard refused it — `git checkout --` is
|
||||
destructive git, refused in the permission mode that shows no prompts —
|
||||
or the operator declined it): the paths are still changed.
|
||||
`simplify = "revert-refused"`, never `"reverted"`. When the cleanup broke
|
||||
the verification, stop here: the run is `partial`, no review runs over a
|
||||
tree that failed it, and the report lists the paths for the operator to
|
||||
restore by hand. Paths outside the run's files that were not restored are
|
||||
listed too.
|
||||
- **It could not start** (the Skill tool refused, the skill is not there):
|
||||
`simplify = "not-run"`, with the reason. Not a stop: `/simplify` is a
|
||||
cleanup pass, not a gate. Continue.
|
||||
|
|
@ -2855,7 +2869,7 @@ To continue (multi-session waves): re-run the same /trekexecute command (not --r
|
|||
"steps_check_not_measured": 0,
|
||||
"arch_rules": "{pass | violation | not-measured | n/a}",
|
||||
"scope_sweep": "{pass | deviation | not-measured | n/a}",
|
||||
"simplify": "{applied | clean | reverted | not-run | n/a}",
|
||||
"simplify": "{applied | clean | reverted | revert-refused | not-run | n/a}",
|
||||
"review_verdict": "{ALLOW | WARN | BLOCK | none}",
|
||||
"review_gate_exit": "{0 | 1 | 2}",
|
||||
"main_merge": "{merged | nothing-to-merge | closed | declined | n/a}"
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue