chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command

The four profiles, the resolver, the profile validator and docs/profiles.md go;
/trekbrief Phase 3.5 and the brief's phase_signals checks go (an older brief's
key is ignored); MANIFEST_PROFILE_DRIFT and profile_used go. Every Profile,
Composition rule, Sequencing gate and High-effort section leaves the commands.
Decision 209: /trekresearch runs the full swarm with contrarian-researcher as
wave 2 every run; /trekreview and the coordinator run all four passes with no
high-effort normalization. Voyage agents are spawned with no model (their own
model: opus applies); the two built-in spawns pass model "opus". --profile
stays in the parser as a retired flag that swallows its value. §Model & effort
moves to docs/architecture.md; the sequencing-gate eval case goes.

Files removed: 44 (43 from the R3 list + tests/commands/trekreview.test.mjs,
whose every test pinned removed text). Files edited: 43.
Tests: 2467 (2466 pass / 0 fail / 1 skipped) before, 2309 (2309 pass / 0 fail /
0 skipped) after. Durable check: all three groups green, none pending.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

tests/validators/brief-validator.test.mjs

@@ -157,127 +157,10 @@ test('validateBrief — wrong-type error message includes accepted set', () => {
   assert.ok(/trekreview/.test(wrongType.message));
 });
 
-// --- v5.1 — phase_signals additive field + sequencing gate ---
-
-const SIGNALS_BLOCK = `phase_signals:
-  - phase: research
-    effort: standard
-  - phase: plan
-    effort: high
-    model: opus
-  - phase: execute
-    effort: low
-    model: sonnet
-  - phase: review
-    effort: standard
-`;
-
-test('validateBrief — v5.1 well-formed phase_signals accepted', () => {
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', `source: interview\n${SIGNALS_BLOCK}`);
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, true, JSON.stringify(r.errors));
-});
-
-test('validateBrief — pre-v5.1 brief without phase_signals accepted (backward-compat)', () => {
-  const r = validateBriefContent(GOOD_BRIEF, { strict: true });
-  assert.equal(r.valid, true, JSON.stringify(r.errors));
-  assert.ok(!r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
-});
-
-test('validateBrief — v5.1+ brief missing phase_signals + partial emits BRIEF_V51_MISSING_SIGNALS', () => {
-  const t = GOOD_BRIEF.replace('brief_version: "2.0"', 'brief_version: "2.1"');
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
-});
-
-test('validateBrief — v5.1+ brief with phase_signals_partial: true accepted', () => {
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', 'source: interview\nphase_signals_partial: true\n');
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, true, JSON.stringify(r.errors));
-});
-
-test('validateBrief — phase_signals + phase_signals_partial both set rejected (mutually exclusive)', () => {
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', `source: interview\nphase_signals_partial: true\n${SIGNALS_BLOCK}`);
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(r.errors.find(e => e.code === 'BRIEF_SIGNALS_MUTUALLY_EXCLUSIVE'));
-});
-
-test('validateBrief — phase_signals with unknown phase rejected', () => {
-  const BAD_SIGNALS = `phase_signals:
-  - phase: nonsense
-    effort: standard
-`;
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', `source: interview\n${BAD_SIGNALS}`);
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(r.errors.find(e => e.code === 'BRIEF_INVALID_PHASE_SIGNAL_PHASE'));
-});
-
-// --- v5.1.1 regression: YAML-number bypass closed ---
-// Findings 3c834097 + df1435a2: v5.1.0 shipped with an unquoted `brief_version: 2.1`
-// template. parseScalar coerces unquoted "2.1" to Number 2.1, and the original gate
-// guarded `typeof === 'string'`, silently bypassing the sequencing check. v5.1.1
-// coerces via String() so both shapes trigger the gate.
-
-test('validateBrief — v5.1.1: UNQUOTED brief_version 2.1 without signals triggers gate', () => {
-  const t = GOOD_BRIEF.replace('brief_version: "2.0"', 'brief_version: 2.1');
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(
-    r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'),
-    `gate must fire for unquoted brief_version: 2.1 (YAML Number); errors=${JSON.stringify(r.errors)}`,
-  );
-});
-
-test('validateBrief — v5.1.1: QUOTED brief_version "2.1" without signals triggers gate (regression guard)', () => {
-  const t = GOOD_BRIEF.replace('brief_version: "2.0"', 'brief_version: "2.1"');
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
-});
-
-test('validateBrief — v5.1.1: UNQUOTED brief_version 2.1 WITH phase_signals is valid (positive case)', () => {
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: 2.1')
-    .replace('source: interview\n', `source: interview\n${SIGNALS_BLOCK}`);
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, true, JSON.stringify(r.errors));
-  assert.ok(!r.errors.find(e => e.code === 'BRIEF_V51_MISSING_SIGNALS'));
-});
-
-// --- v5.9 — fable model tier (BASE_ALLOWED_MODELS widened to three values) ---
-
-test('validateBrief — v5.9: fable phase_signals fixture accepted (no BRIEF_INVALID_MODEL)', () => {
-  const t = readFileSync(new URL('../fixtures/brief-effort-fable.md', import.meta.url), 'utf-8');
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, true, JSON.stringify(r.errors));
-  assert.ok(!r.errors.find(e => e.code === 'BRIEF_INVALID_MODEL'));
-});
-
-test('validateBrief — v5.9: unknown model gpt5 in phase_signals rejected with BRIEF_INVALID_MODEL', () => {
-  const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', `source: interview\n${SIGNALS_BLOCK.replace('model: opus', 'model: gpt5')}`);
-  const r = validateBriefContent(t, { strict: true });
-  assert.equal(r.valid, false);
-  assert.ok(r.errors.find(e => e.code === 'BRIEF_INVALID_MODEL'),
-    `expected BRIEF_INVALID_MODEL for gpt5, got: ${JSON.stringify(r.errors)}`);
-});
-
 // --- v5.5 — framing enforcement + obligatory TL;DR (gated at brief_version ≥ 2.2) ---
 // Operator decision (S6, option A1): framing + TL;DR are hard BLOCKERs for briefs
-// declaring brief_version ≥ 2.2; existing 2.0/2.1 briefs stay valid (forward-compat,
-// mirroring the phase_signals ≥ 2.1 precedent). The framing ENUM check fires on any
+// declaring brief_version ≥ 2.2; existing 2.0/2.1 briefs stay valid (forward-compat).
+// The framing ENUM check fires on any
 // version when the field is present but malformed.
 
 const GOOD_BRIEF_22 = `---
@@ -293,7 +176,6 @@ auto_research: false
 interview_turns: 5
 source: interview
 framing: new-direction
-phase_signals_partial: true
 ---
 
 # Task: JWT auth
@@ -315,6 +197,18 @@ What success looks like.
 - All tests pass.
 `;
 
+// An older brief may still carry a phase_signals block (removed in cleanup R-b,
+// decision 191): the key is ignored, with no error and no warning.
+
+test('validateBrief — a 2.2 brief that still carries phase_signals validates with no error or warning about it', () => {
+  const t = GOOD_BRIEF_22.replace('framing: new-direction\n',
+    'framing: new-direction\nphase_signals:\n  - phase: plan\n    effort: high\n  - phase: brief\n    effort: xhigh\n');
+  const r = validateBriefContent(t, { strict: true });
+  assert.equal(r.valid, true, JSON.stringify(r.errors));
+  assert.deepEqual(r.errors, []);
+  assert.deepEqual(r.warnings.filter(w => /signal/i.test(w.code + ' ' + w.message)), []);
+});
+
 test('validateBrief — v5.5 well-formed 2.2 brief (framing + TL;DR) accepted', () => {
   const r = validateBriefContent(GOOD_BRIEF_22, { strict: true });
   assert.equal(r.valid, true, JSON.stringify(r.errors));
@@ -367,8 +261,7 @@ test('validateBrief — v5.5 TL;DR exceeding 5 lines emits BRIEF_TLDR_TOO_LONG w
 
 test('validateBrief — v5.5 backward-compat: 2.1 brief without framing/TL;DR stays valid', () => {
   const t = GOOD_BRIEF
-    .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-    .replace('source: interview\n', 'source: interview\nphase_signals_partial: true\n');
+    .replace('brief_version: "2.0"', 'brief_version: "2.1"');
   const r = validateBriefContent(t, { strict: true });
   assert.equal(r.valid, true, JSON.stringify(r.errors));
   assert.ok(!r.errors.find(e => e.code === 'BRIEF_MISSING_FRAMING'));
@@ -385,8 +278,7 @@ test('validateBrief — v5.5 trekreview brief not subject to framing/TL;DR gate'
 // S18 — opt-in --min-brief-version gate. Warns (never blocks) when a brief
 // declares a version below the caller's floor, sidestepping framing enforcement.
 const BRIEF_21 = GOOD_BRIEF
-  .replace('brief_version: "2.0"', 'brief_version: "2.1"')
-  .replace('source: interview\n', 'source: interview\nphase_signals_partial: true\n');
+  .replace('brief_version: "2.0"', 'brief_version: "2.1"');
 
 test('validateBrief — S18 min-version: older brief below floor warns but does not block', () => {
   const r = validateBriefContent(BRIEF_21, { strict: true, minBriefVersion: '2.2' });
@@ -457,7 +349,7 @@ const codes = (list) => list.map((e) => e.code);
 function briefWith(sections) {
   return [
     '---', 'type: trekbrief', 'brief_version: "2.2"', 'task: t', 'slug: s',
-    'research_topics: 0', 'research_status: skipped', 'framing: new-direction', 'phase_signals_partial: true', '---', '',
+    'research_topics: 0', 'research_status: skipped', 'framing: new-direction', '---', '',
     '## TL;DR', '', 'A toy.', '', '## Intent', '', 'Why.', '', '## Goal', '', 'What.', '',
     ...sections,
   ].join('\n');