fix(docs): the order fields stand on all five surfaces (green)
/trekbrief Phase 7 says the writer adds order_id / order_claimed_at / order_reason (never typed by the model) and that the yardstick joins use on order_id; the fixture row lists them in `fields`, EXPORT_DENYLIST names them, and its stale line_ref (657-672) now reads 961-976; the allowlist header names them as dropped; docs/architecture.md Stats explains them. /trekbrief --approve now runs Phase 7 after a successful stamp, with fixed values (mode "approve", 0 turns, brief_quality/research_topics/auto_research from the brief's frontmatter, auto_result "manual", intent_approved true). Valgt fordi PM 04.10 (point 3): fix the code, not the criterion - the approval must leave the trekbrief record. Measured hole: okf-wiki v1-k has brief-approved 04.10 17:12Z and trekplan 17:29Z, but only a 03.10 trekbrief record with intent_approved false. CLAUDE.md, README.md and docs/command-modes.md say so. The manual path is unchanged. npm test 1309 -> 1362 (1360 pass / 0 fail / 2 skip). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
parent
598ef1b694
commit
3f073b7bd7
7 changed files with 32 additions and 10 deletions
|
|
@ -62,8 +62,9 @@ Parse `$ARGUMENTS`:
|
|||
file resolves to itself, whatever its name (a `/trekplan --brief` brief).
|
||||
On exit 1, print its `error` and stop. Otherwise set `BRIEF_PATH`,
|
||||
`PROJECT_DIR` and `PLAN_COMMAND` from `brief_path`, `project_dir` and
|
||||
`plan_command`, jump straight to **Phase 4h**, run it, print its report,
|
||||
and stop. This is the remedy `/trekplan` names when it halts on an
|
||||
`plan_command`, jump straight to **Phase 4h**, run it and print its
|
||||
report; if the stamp printed `stamped: true`, run **Phase 7** with the
|
||||
approve-mode values it names, then stop. This is the remedy `/trekplan` names when it halts on an
|
||||
unapproved or stale intent, on both of its brief modes.
|
||||
|
||||
In every other mode, `BRIEF_PATH = {PROJECT_DIR}/brief.md` and
|
||||
|
|
@ -89,7 +90,7 @@ Examples:
|
|||
|
||||
Report:
|
||||
```
|
||||
Mode: {default | quick}
|
||||
Mode: {default | quick | approve}
|
||||
Task: {task description}
|
||||
```
|
||||
|
||||
|
|
@ -786,7 +787,8 @@ Report:
|
|||
Intent: {approved (sha256:…12 hex) | left unapproved — /trekplan will halt}
|
||||
```
|
||||
|
||||
In `--approve` mode, stop after the report and print the next step:
|
||||
In `--approve` mode, run **Phase 7** (`"mode": "approve"`) when the stamp
|
||||
printed `stamped: true`, then stop and print the next step:
|
||||
`{PLAN_COMMAND}` (only if approved).
|
||||
|
||||
## Phase 5 — Auto-orchestration opt-in (if research_topics > 0)
|
||||
|
|
@ -961,7 +963,7 @@ node ${CLAUDE_PLUGIN_ROOT}/lib/stats/stats-append.mjs trekbrief <<'JSON'
|
|||
"ts": "{ISO-8601}",
|
||||
"task": "{task description (first 100 chars)}",
|
||||
"slug": "{slug}",
|
||||
"mode": "{default | quick}",
|
||||
"mode": "{default | quick | approve}",
|
||||
"interview_turns": {N},
|
||||
"review_iterations": {1..3},
|
||||
"brief_quality": "{complete | partial}",
|
||||
|
|
@ -978,6 +980,18 @@ JSON
|
|||
answered "Approve"). `slug` is the brief's `slug`, the same one the stamp's
|
||||
`brief-approved` record and `/trekplan`'s record carry.
|
||||
|
||||
In `--approve` mode the record carries fixed values: `"mode": "approve"`,
|
||||
`"interview_turns": 0`, `"review_iterations": 0`, `brief_quality`,
|
||||
`research_topics` and `auto_research` from the brief's frontmatter (`complete`,
|
||||
`0`, `false` when absent), `"auto_result": "manual"`, `"intent_approved": true`.
|
||||
|
||||
The writer adds three keys itself: `order_id`, `order_claimed_at` and
|
||||
`order_reason` - the coord-queue order this run is working on, read from the
|
||||
queue's claimed orders (exactly one: its id and claim time; zero or several:
|
||||
`order_id: null` and the reason). Never type them: any `order_*` key in the
|
||||
record is replaced. `scripts/yardstick.mjs` joins its `use` number on
|
||||
`order_id`.
|
||||
|
||||
The writer prints `{"written": true, ...}`. On `"written": false` (exit 1),
|
||||
print its `reason` in one line and continue. A stats failure never blocks the
|
||||
workflow, but it is reported, not skipped silently.
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue