fix(review): the coordinator and orchestrator texts say what the code does on refutation and the brief-conflict exception

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-10-26 15:18:03 +01:00
commit 738efa3e24
Signed by: ktg
SSH key fingerprint: SHA256:JakMjO6FTBBzN0Bhfj9saOoEjaFxlSdYuZQQpM/lF9Q
6 changed files with 70 additions and 7 deletions

View file

@ -136,8 +136,9 @@ Succinctness and Actionability read the finding's *packaging*; neither
examines the claim, so neither can establish the finding is unreal. Accuracy
does: a citation that escapes the repo root, or a negative line, refutes the
finding as a claim about this codebase. A line past the end of the file does
not: the citation is wrong, the claim is unchecked. A line number alone never
refutes a finding, so it goes to `unverified` (`accuracy:line-out-of-range`).
not: the citation is wrong, the claim is unchecked. Any other line number alone
never refutes the finding, so a line past the end of the file sends it to
`unverified` (`accuracy:line-out-of-range`).
**No finding is struck for length** (ordre 5). Before review_version 1.1 an
over-long `detail` sent a finding to `unverified`, and S118's most serious

View file

@ -54,8 +54,8 @@ You will receive a prompt containing:
contract that bounds review scope.
- **Mode** — `default`, `quick`, `validate`, or `dry-run`.
- `default` — run the full pipeline.
- `quick` — skip the coordinator's reasonableness filter; use single
reviewer (code-correctness only) for faster turnaround.
- `quick` — skip the coordinator's reasonableness filter except the
brief-conflict rule; use single reviewer (code-correctness only) for faster turnaround.
- `validate` — schema-only check on existing review.md, no LLM calls.
- `dry-run` — print the discovered scope and triage map; skip writes.
- **Since-ref** (optional) — explicit `--since <ref>` override for the SHA
@ -191,6 +191,9 @@ The coordinator runs a 4-pass process:
`RULE_CATALOGUE` (`unknown-rule_key`) or whose file cannot be checked
(`file-existence:indeterminate`) to `unverified`, which forbids `ALLOW`;
reset a severity that does not match its catalogue tier.
The one exception to the reset is the brief-conflict lowering: a
`/code-review` finding marked `contradicts_brief`, at the MAJOR tier and
at severity MAJOR, drops to MINOR with `brief_lowered_from: MAJOR`.
Skipped at high effort, as in `quick` mode (below); at high effort an
unknown `rule_key` is normalized to `PLAN_EXECUTE_DRIFT` instead
(`agents/review-coordinator.md`, "High-effort normalization"); the