feat(trekexecute): every MAJOR answered before merge, fixed runs the fix loop
This commit is contained in:
parent
635003e8aa
commit
9e7e8d1516
15 changed files with 376 additions and 30 deletions
|
|
@ -370,7 +370,7 @@ After the last step, and with nobody typing anything, the executor runs Cherny's
|
|||
|
||||
| Verdict gate | Merge into main |
|
||||
|---|---|
|
||||
| 0 — ALLOW / WARN | open: the executor runs the merge, and the guard asks you before it runs |
|
||||
| 0 — ALLOW, or WARN with every counting MAJOR answered | open: the executor runs the merge, and the guard asks you before it runs |
|
||||
| 1 — BLOCK | closed. The review's BLOCKERs are added to the plan as new numbered steps, you approve the plan again, and the loop runs: build, check, review — at most 3 reviews, then it is yours |
|
||||
| 2 — could not decide | closed: a review that did not run in full is never green |
|
||||
|
||||
|
|
@ -509,7 +509,7 @@ them and is the part that stops. The verdict is written in `review.md`
|
|||
|
||||
```bash
|
||||
node lib/review/verdict-gate.mjs <dir>/review.md
|
||||
# 0 = ALLOW or WARN · 1 = BLOCK · 2 = could not decide (never green)
|
||||
# 0 = ALLOW, or WARN with every counting MAJOR answered · 1 = BLOCK · 2 = could not decide (never green)
|
||||
```
|
||||
|
||||
A WARN that exists only because a check did not run is a 2, not a 0: a
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue