open/voyage
1
0
Fork 0
Code Issues Releases 13 Activity

fix: the findings of the release review of 6.3.0

Browse source 
The review of v6.2.0..f669b87 (BLOCK: 1 BLOCKER, 12 MAJOR, 1 MINOR), each
fixed behind a test that failed first, or, for the two missing tests, a test
shown to fail on a stub of the branch it covers.

- Review steps appended by /trekexecute Phase 7.2 are held to the step rules
  on any plan version: plan-validator --steps-from <N> (on a plan below 1.8 a
  template review step validated and was executed).
- The guard refuses where no one can be asked also when its rules will not
  load; the wave merge path names that refusal instead of MERGE_REFUSED.
  Tests for the classifier-error refusal and post-approval-log's own check.
- release-check: the version files may change only in their version after
  the review (JSON compared without it), README diff lines are read inside
  hunks only, an unreadable diff is exit 2, and npm test runs without
  NODE_TEST_CONTEXT.
- What counts as a step of only tests: a note in parentheses is not a path,
  and a data file under specs/ is not a test. End-to-end: rides on the last
  step that builds behaviour (validator hint, trekplan, template).
- A removed line is cited as <rev>:<path>:<line> (findings-schema hint,
  trekreview re-ask).
- skill-lint counts a trailing newline as no line; regression-check takes
  commandEnv from lib/util/command-env.mjs; CLAUDE.md names four mode-read
  exemptions.
- /security-review, older than v6.2.0: the criteria runner refuses git
  --output, which writes a file.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-10-10 22:12:12 +02:00
commit bef9c5b3ac
Signed by: ktg
SSH key fingerprint: SHA256:JakMjO6FTBBzN0Bhfj9saOoEjaFxlSdYuZQQpM/lF9Q
18 changed files with 450 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

20
hooks/scripts/pre-bash-executor.mjs
View file

@ -36,7 +36,7 @@ import { readFileSync } from 'node:fs';
// The guard's own modules are loaded so that a broken install cannot crash
// the hook: a crash (exit 1) is a non-blocking error to Claude Code, which
// would let every command through. A module that will not load makes the
// guard ask about every command instead.
// guard ask about every command instead, and refuse it where no one can be asked.
let lib;
let loadError = null;
try {
@ -217,7 +217,22 @@ if (!command || typeof command !== 'string') {
process.exit(0);
}
// In the permission mode where Claude Code shows no prompts, an "ask" reaches
// no one and the call runs unattended (see the refusal below).
const NO_PROMPT_MODE = 'bypassPermissions';
const noOneToAsk = input.permission_mode === NO_PROMPT_MODE;
if (loadError) {
// A guard that cannot read its rules asks about every command; where no one
// can be asked it refuses instead (release review of 6.3.0, 2026-10-10).
if (noOneToAsk) {
process.stderr.write(
`[voyage] BLOCKED: Voyage's Bash guard could not load its rules (${loadError.message}) and there is no one to ask\n` +
' This session runs in the permission mode where Claude Code asks nothing, so the guard cannot ask a person. ' +
'Way forward: reinstall Voyage to restore the guard, or run the command yourself.\n'
);
process.exit(2);
}
process.stdout.write(JSON.stringify({
hookSpecificOutput: {
hookEventName: 'PreToolUse',
@ -280,8 +295,7 @@ try {
// decisions 2026-10-09: first merge and push, then the other two classes).
// /trekexecute relies on this: its main-merge gate is a lock, and this guard's
// question is the one question.
const NO_PROMPT_MODE = 'bypassPermissions';
const unattended = input.permission_mode === NO_PROMPT_MODE ? approvals : [];
const unattended = noOneToAsk ? approvals : [];
if (unattended.length > 0) {
process.stderr.write(
`[voyage] BLOCKED: ${unattended.map((m) => m.name).join(', ')} with no one to ask\n` +