feat(trekresearch): add Phase 4.5 dimension discovery and amend Independence rule

tests/commands/trekresearch.test.mjs

@@ -166,6 +166,76 @@ test('trekresearch — High-effort behavior keeps the standard/low effort senten
   );
 });
 
+// --- Step 8: Phase 4.5 dimension discovery + Independence amendment ---
+
+const ORCHESTRATOR_FILE = join(ROOT, 'agents', 'research-orchestrator.md');
+function readOrchestrator() { return readFileSync(ORCHESTRATOR_FILE, 'utf8'); }
+
+test('trekresearch — Phase 4.5 exists between Phase 4 and Phase 5 with the effort skip-guard', () => {
+  const text = read();
+  const p45 = text.indexOf('## Phase 4.5 —');
+  assert.ok(p45 >= 0, 'Phase 4.5 heading missing');
+  const p4 = text.indexOf('## Phase 4 —');
+  const p5 = text.indexOf('## Phase 5 —');
+  assert.ok(p4 >= 0 && p5 > p45 && p45 > p4, 'Phase 4.5 must sit between Phase 4 and Phase 5');
+
+  const slice = text.slice(p45, p5);
+  assert.match(
+    slice,
+    /\*\*Skip this phase entirely unless `phase_signal_result\.effort == 'high'`\.\*\*/,
+    'Phase 4.5 must carry the bolded skip-guard in the Phase 3.5 form',
+  );
+  assert.match(slice, /query-privacy-gate\.mjs/,
+    'Phase 4.5 must name the privacy gate as its compensating control');
+  assert.match(slice, /maxDimensions: 8|maxDimensions` *: *8/,
+    'Phase 4.5 must augment under the existing maxDimensions ceiling, not raise it');
+});
+
+test('trekresearch — Independence hard rule carries an explicit Phase 4.5 amendment', () => {
+  const text = read();
+  const rulesIdx = text.indexOf('## Hard rules');
+  assert.ok(rulesIdx >= 0, 'Hard rules section missing');
+  const rules = text.slice(rulesIdx);
+  const indIdx = rules.indexOf('**Independence:**');
+  assert.ok(indIdx >= 0, 'Independence hard rule missing');
+  // Bound the rule at the next bullet so the amendment must live inside it.
+  const nextBullet = rules.indexOf('\n- **', indIdx);
+  const independence = nextBullet > indIdx ? rules.slice(indIdx, nextBullet) : rules.slice(indIdx);
+  assert.match(independence, /Amend(ed|ment)/i,
+    'Independence must be explicitly amended, not silently contradicted');
+  assert.match(independence, /Phase 4\.5/, 'the amendment must name Phase 4.5 as the crossing');
+  assert.match(independence, /query-privacy-gate\.mjs/,
+    'the amendment must name the compensating control');
+});
+
+test('trekresearch — orchestrator phase map is correct, has no Phase 9, and carries Phase 4.5', () => {
+  const doc = readOrchestrator();
+  const start = doc.indexOf('<!-- Phase mapping');
+  assert.ok(start >= 0, 'phase mapping comment missing');
+  const end = doc.indexOf('-->', start);
+  assert.ok(end > start, 'phase mapping comment not terminated');
+  const map = doc.slice(start, end);
+
+  assert.doesNotMatch(map, /Command Phase 9/,
+    'the command ends at Phase 8 — a Command Phase 9 row is a fiction');
+
+  // Six orchestrator rows, each pointing at the phase the command actually has.
+  const expected = [
+    [1, '4'],
+    [2, '4'],
+    [3, '5'],
+    [4, '6'],
+    [5, '7'],
+    [6, '8'],
+  ];
+  for (const [orch, cmd] of expected) {
+    const re = new RegExp(`Orchestrator Phase ${orch}\\s+= Command Phase ${cmd.replace('.', '\\.')}\\b`);
+    assert.match(map, re, `map row for Orchestrator Phase ${orch} must point at Command Phase ${cmd}`);
+  }
+
+  assert.match(map, /Command Phase 4\.5/, 'the map must carry the new Phase 4.5 row');
+});
+
 // --- v5.1.1 runtime SC4 + SC7 ---
 
 test('trekresearch — SC4: low-effort fixture → resolver returns {effort: low, model: sonnet}', () => {