open/voyage
1
0
Fork 0
Code Issues Releases 13 Activity

feat(skills): reviewing-adversarially, one stance for every reviewer

Browse source 
A new skill, voyage:reviewing-adversarially (contract S4): no praise, no
finding without a source (file:line or a quoted line), no downgrade without
a reason, summary-only said and not judged, a Declined to Judge list, claims
checked against the diff rather than the report, axes kept separate.

Red baseline first: six review runs by helpers without the skill (two
invented fixtures) had no separate Declined to Judge list in 6 of 6, an
unsourced finding in 6 of 6, praise in 2 of 6 and a verdict on something
unmeasured in 4 of 6. With the skill: 6 of 6, 0, 0 and 0.

- brief-conformance-reviewer, code-correctness-reviewer, review-coordinator
  and scope-guardian preload it through skills:; the 21-line "Interaction
  Awareness - MANDATORY OVERRIDE" block copied into three of them is gone.
  Each agent keeps its own role.
- The two reviewers and scope-guardian end with their own Declined to Judge
  list; /trekreview names the skill at spawn and passes the reviewers'
  lines to the coordinator, which copies them into review.md as prose
  (the JSON declined_to_judge array and the verdict are unchanged).
- Eval cases 3 / 2 / 1; pins in tests/lib/skills-review-prose-pins.test.mjs.
- tests/fixtures/jsonl-schemas.md: the trekreview-stats line_ref moves with
  Phase 8 (636-686).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-10-17 07:34:08 +02:00
commit f906ec9252
Signed by: ktg
SSH key fingerprint: SHA256:JakMjO6FTBBzN0Bhfj9saOoEjaFxlSdYuZQQpM/lF9Q
26 changed files with 601 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

5
evals/skill-reviewing-adversarially-fires-1/graders/skill-fired.md Normal file
View file

@ -0,0 +1,5 @@
---
type: tool_used
tool: Skill
input_match: '"skill"\s*:\s*"(?:voyage:)?reviewing-adversarially"'
---

10
evals/skill-reviewing-adversarially-fires-1/prompt.md Normal file
View file

@ -0,0 +1,10 @@
---
description: "Routing case: the reviewing-adversarially skill should fire on this request (the reserve path outside the pipeline)."
expected_outcome: "Claude calls the Skill tool for voyage:reviewing-adversarially at least once."
tags: [skill-trigger, skill=reviewing-adversarially, from=baseline-ra-report-claim]
runs: 3
max_turns: 4
allowed_tools: [Read, Glob, Grep, Skill]
---
The helper says the step is done and all tests pass. Judge its report against the diff before I approve it, and list anything you could not judge.