refactor(cleanup): simplify pass on R-b

The retired --profile is one list the parser drops (with its value, never
an error) instead of a valued flag in six schemas, so the removed-surfaces
check exempts one parser line, not seven; seen red on the old parser.
The empty OPTIONAL_STRING_KEYS machinery, a one-item loop and an unused
plugin-data dir go; the removed-surfaces check reads each file once; the
Phase 8 slice in executor-prose-pins asserts both anchors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Kjell Tore Guttormsen 2026-11-07 21:26:25 +01:00
commit fdb401d0ab
Signed by: ktg
SSH key fingerprint: SHA256:JakMjO6FTBBzN0Bhfj9saOoEjaFxlSdYuZQQpM/lF9Q
9 changed files with 52 additions and 60 deletions

View file

@ -160,8 +160,8 @@ test('validateBrief — wrong-type error message includes accepted set', () => {
// --- v5.5 — framing enforcement + obligatory TL;DR (gated at brief_version ≥ 2.2) ---
// Operator decision (S6, option A1): framing + TL;DR are hard BLOCKERs for briefs
// declaring brief_version ≥ 2.2; existing 2.0/2.1 briefs stay valid (forward-compat).
// The framing ENUM check fires on any
// version when the field is present but malformed.
// The framing ENUM check fires on any version when the field is present but
// malformed.
const GOOD_BRIEF_22 = `---
type: trekbrief

View file

@ -364,18 +364,16 @@ test('M2: /trekbrief --approve <project-dir> still resolves to <dir>/brief.md an
test('M2: the Phase 4h stamp line stamps the resolved brief file, whatever its name', () => {
const dir = tmpDir();
const data = tmpDir();
try {
const p = join(dir, 'x-brief.md');
writeFileSync(p, BRIEF);
const line = commandLine('commands/trekbrief.md', '--stamp');
assert.ok(line.includes('{BRIEF_PATH}'), 'the stamp must take the resolved brief path, not {PROJECT_DIR}/brief.md');
const r = run(line, { '{BRIEF_PATH}': p }, { CLAUDE_PLUGIN_DATA: data });
const r = run(line, { '{BRIEF_PATH}': p });
assert.equal(r.status, 0, r.stdout + r.stderr);
assert.equal(gate(p).status, 0);
} finally {
rmSync(dir, { recursive: true, force: true });
rmSync(data, { recursive: true, force: true });
}
});