voyage

open/voyage

Fork 0

Commit graph

Author	SHA1	Message	Date
Kjell Tore Guttormsen	7cfce2b996	fix(voyage): S26 — parse plan_version prose form (S22 defect #2/#3) The plan template (templates/plan-template.md:21) emits plan_version ONLY in the prose blockquote metadata line: > Generated by trekplan v{version} on {YYYY-MM-DD} — `plan_version: 1.7` It carries no frontmatter plan_version (the frontmatter block is trekreview-only and holds source_findings). But PLAN_VERSION_REGEX in lib/parsers/plan-schema.mjs was `^`-anchored (/m), matching ONLY line-start (frontmatter). The backtick- wrapped prose form never matched → extractPlanVersion returned null → every real generated plan got a spurious PLAN_NO_VERSION warning from plan-validator. Not caught earlier because no test ran the parser against the actual template; the synthetic fixtures all carry frontmatter plan_version and parse fine. Internal source contradiction surfaced: the parser comment documents intent "frontmatter OR doc body", planning-orchestrator.md:228 + the template place it in the prose line, while HANDOVER-CONTRACTS.md calls it a frontmatter field. Operator-chosen fix (parser, not template): relax the regex to `/(?:^\|`)plan_version:.../m` so it matches line-start (frontmatter) OR the backtick-prefixed prose form. Honors the parser's own documented contract, fixes all existing + future plans, changes no plan output, touches one code file — vs the template-fix which would alter every plan's shape, contradict planning-orchestrator.md, and force a 3-file doc reconciliation (scope creep). TDD (red first): added prose-form + canonical-template regression pins in plan-schema.test.mjs and a no-PLAN_NO_VERSION pin in plan-validator.test.mjs; all 3 red on the `^`-anchored regex, green after the relax. The template pin ties the parser directly to the real generated artifact. S22 defect closed in docs/S22-happy-path-dogfood.md (§Pipeline defects + log). Tests: 728 (726 pass / 2 skip / 0 fail; live `node --test`, = 725 baseline +3). plugin validate passes (1 accepted CLAUDE.md-at-root warning). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LqBYc8Ltrk7LipyJmGxXiB	2026-06-19 21:59:31 +02:00
Kjell Tore Guttormsen	f68cd950dd	feat(ultraplan-local): Spor 1 wave 2 — 5 validators + doc-consistency, 108 tests grønn [skip-docs] 5 nye validator-moduler (alle m/ CLI-shim for invokering fra commands): - brief-validator.mjs — frontmatter (type, brief_version, task, slug, research_topics, research_status), state machine (research_topics > 0 + skipped requires brief_quality: partial), body sections (Intent/Goal/Success Criteria) - research-validator.mjs — type=ultraresearch-brief, confidence ∈ [0,1], dimensions ≥ 1, body sections, --dir mode for batch validering - plan-validator.mjs — wrapper over plan-schema + manifest-yaml; håndhever step-count == manifest-count, plan_version=1.7 - progress-validator.mjs — schema_version, status enum, current_step in range, step shape, checkResumeReadiness - architecture-discovery.mjs — EKSTERN KONTRAKT: drift-WARN ikke drift-FAIL; tolererer non-canonical filnavn, surfacer loose files som warnings Doc-consistency-test pinning prose vs source-of-truth: - agents/.md count == CLAUDE.md agent-tabell rader - commands/.md mentioned i CLAUDE.md - command frontmatter.name == filnavn - templates/plan-template.md plan_version 1.7 invariant - settings.json kun kjente scopes (ultraplan, ultraresearch) - settings.json ingen exploration eller agentTeam (vestigial guard etter Spor 0) - CLAUDE.md refererer alle 4 pipeline-commands Wave 1 + Wave 2 = 108 tester grønn. [skip-docs]: Test-infrastrukturen er ikke user-facing før Spor 1 wiring lander; README/CLAUDE.md oppdateres når commands faktisk endrer atferd (neste commit). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-01 05:39:47 +02:00

Author

SHA1

Message

Date

Kjell Tore Guttormsen

7cfce2b996

fix(voyage): S26 — parse plan_version prose form (S22 defect #2/#3)

The plan template (templates/plan-template.md:21) emits plan_version ONLY in
the prose blockquote metadata line:

  > Generated by trekplan v{version} on {YYYY-MM-DD} — `plan_version: 1.7`

It carries no frontmatter plan_version (the frontmatter block is trekreview-only
and holds source_findings). But PLAN_VERSION_REGEX in lib/parsers/plan-schema.mjs
was `^`-anchored (/m), matching ONLY line-start (frontmatter). The backtick-
wrapped prose form never matched → extractPlanVersion returned null → every real
generated plan got a spurious PLAN_NO_VERSION warning from plan-validator.

Not caught earlier because no test ran the parser against the actual template;
the synthetic fixtures all carry frontmatter plan_version and parse fine.

Internal source contradiction surfaced: the parser comment documents intent
"frontmatter OR doc body", planning-orchestrator.md:228 + the template place it
in the prose line, while HANDOVER-CONTRACTS.md calls it a frontmatter field.

Operator-chosen fix (parser, not template): relax the regex to
`/(?:^|`)plan_version:.../m` so it matches line-start (frontmatter) OR the
backtick-prefixed prose form. Honors the parser's own documented contract,
fixes all existing + future plans, changes no plan output, touches one code
file — vs the template-fix which would alter every plan's shape, contradict
planning-orchestrator.md, and force a 3-file doc reconciliation (scope creep).

TDD (red first): added prose-form + canonical-template regression pins in
plan-schema.test.mjs and a no-PLAN_NO_VERSION pin in plan-validator.test.mjs;
all 3 red on the `^`-anchored regex, green after the relax. The template pin
ties the parser directly to the real generated artifact.

S22 defect closed in docs/S22-happy-path-dogfood.md (§Pipeline defects + log).

Tests: 728 (726 pass / 2 skip / 0 fail; live `node --test`, = 725 baseline +3).
plugin validate passes (1 accepted CLAUDE.md-at-root warning).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LqBYc8Ltrk7LipyJmGxXiB

2026-06-19 21:59:31 +02:00

Kjell Tore Guttormsen

f68cd950dd

feat(ultraplan-local): Spor 1 wave 2 — 5 validators + doc-consistency, 108 tests grønn [skip-docs]

5 nye validator-moduler (alle m/ CLI-shim for invokering fra commands):
- brief-validator.mjs — frontmatter (type, brief_version, task, slug, research_topics, research_status), state machine (research_topics > 0 + skipped requires brief_quality: partial), body sections (Intent/Goal/Success Criteria)
- research-validator.mjs — type=ultraresearch-brief, confidence ∈ [0,1], dimensions ≥ 1, body sections, --dir mode for batch validering
- plan-validator.mjs — wrapper over plan-schema + manifest-yaml; håndhever step-count == manifest-count, plan_version=1.7
- progress-validator.mjs — schema_version, status enum, current_step in range, step shape, checkResumeReadiness
- architecture-discovery.mjs — EKSTERN KONTRAKT: drift-WARN ikke drift-FAIL; tolererer non-canonical filnavn, surfacer loose files som warnings

Doc-consistency-test pinning prose vs source-of-truth:
- agents/*.md count == CLAUDE.md agent-tabell rader
- commands/*.md mentioned i CLAUDE.md
- command frontmatter.name == filnavn
- templates/plan-template.md plan_version 1.7 invariant
- settings.json kun kjente scopes (ultraplan, ultraresearch)
- settings.json ingen exploration eller agentTeam (vestigial guard etter Spor 0)
- CLAUDE.md refererer alle 4 pipeline-commands

Wave 1 + Wave 2 = 108 tester grønn.

[skip-docs]: Test-infrastrukturen er ikke user-facing før Spor 1 wiring lander; README/CLAUDE.md oppdateres når commands faktisk endrer atferd (neste commit).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

2026-05-01 05:39:47 +02:00

2 commits