event-emit returned {written:false, reason:'CLAUDE_PLUGIN_DATA unset'} whenever the harness did not export the variable - the normal case for the Bash tool - so /trekexecute's Phase 8 events never landed. It now resolves the directory through stats-append's resolveStatsDir (one resolver; opts.path still wins, so intent-approval is unchanged). The CLI uses the realpath isMain() guard (the file:// guard was a silent no-op under a symlink or a path with a space) and exits 1 on every written:false - usage error, payload-not-json, failed write - instead of always 0. KNOWN_EVENTS gains main-merge-approved, main-merge-declined and gates_mode_flag_override, which /trekexecute emits by design. Header, intent-approval docstring (comment only), docs/operations.md and the README autonomy sentence (wrong state names, 'records each transition') updated.
Red: 10 of 20 tests fail on the pre-fix code - 7 new (CLI lands with CLAUDE_PLUGIN_DATA empty / absent, unwritable target exit 1, usage error exit 1, symlink, space path, known events) and 3 inverted contracts. Regression guards (green on arrival): never throws when unwritable; no second copy of the fallback directory name.
Inverted (the contract this changes, not deleted): emit with no CLAUDE_PLUGIN_DATA (silent skip) -> lands under a pinned HOME; never throws when unwritable -> a genuinely unwritable target (env {} now resolves to the real home); resolveStatsPath({}) === null -> the fallback path; malformed --payload exit 0 -> exit 1.
Readers checked: otel-export keys on 'event', yardstick counts only user_input, cache-analyzer and research-loop-cap name event-emit only in comments. Verify 268/268 (stats-event-emit, intent-approval, doc-consistency, otel-export-validators, yardstick). Suite 1376 (1374/0/2); non-hook lines in the real trekexecute-stats.jsonl 60 before and after.
Voyage order 20261005T104513Z-1250514346, plan step 2/5.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
137 lines
4.9 KiB
JavaScript
137 lines
4.9 KiB
JavaScript
// lib/stats/event-emit.mjs
|
|
// Atomic JSONL append for autonomy-lifecycle events (plan-v2 Step 6).
|
|
//
|
|
// Writes one line per event to <data dir>/trekexecute-stats.jsonl, where the data
|
|
// dir is resolved by stats-append.mjs's resolveStatsDir: CLAUDE_PLUGIN_DATA when
|
|
// the harness provides it, else the plugin's directory under ~/.claude/plugins/data/,
|
|
// the one scripts/yardstick.mjs reads (one resolver, no second copy here). The Bash tool env carries no
|
|
// CLAUDE_PLUGIN_DATA, so the old "unset -> silent skip" dropped every event the
|
|
// command prose emitted. A failed write is REPORTED ({written:false, reason}),
|
|
// never thrown: stats still never block the workflow.
|
|
//
|
|
// Every emission carries:
|
|
// - ts : ISO-8601 timestamp (REQUIRED per SC4 contract)
|
|
// - event : the requested event name
|
|
// - known_event : true for recognized events, false otherwise
|
|
// - payload : caller-supplied object (may be {})
|
|
//
|
|
// Recognized events: brief-approved, main-merge-gate, main-merge-approved,
|
|
// main-merge-declined, gates_mode_flag_override, user_input. Unknown event names
|
|
// are still emitted (with known_event: false) so that the audit trail is
|
|
// complete; downstream consumers filter as needed.
|
|
//
|
|
// CLI shim:
|
|
// node lib/stats/event-emit.mjs --event brief-approved --payload '{...}'
|
|
// → prints {"written":true,"path":...} exit 0 | {"written":false,"reason":...} exit 1
|
|
// (usage error, payload-not-json and a failed write alike). The command prose
|
|
// prints the reason and continues.
|
|
//
|
|
// Import direction: event-emit imports stats-append; stats-append must never
|
|
// import event-emit (that would be a cycle).
|
|
|
|
import { appendFileSync, existsSync, mkdirSync, realpathSync } from 'node:fs';
|
|
import { dirname, join } from 'node:path';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { resolveStatsDir } from './stats-append.mjs';
|
|
|
|
export const KNOWN_EVENTS = Object.freeze(new Set([
|
|
'brief-approved',
|
|
'main-merge-gate',
|
|
'main-merge-approved',
|
|
'main-merge-declined',
|
|
'gates_mode_flag_override',
|
|
'user_input',
|
|
]));
|
|
|
|
const STATS_FILENAME = 'trekexecute-stats.jsonl';
|
|
|
|
/**
|
|
* Resolve the stats file path: CLAUDE_PLUGIN_DATA when set, else the directory
|
|
* stats-append.mjs and scripts/yardstick.mjs use. Never null.
|
|
*/
|
|
export function resolveStatsPath(env = process.env) {
|
|
return join(resolveStatsDir(env), STATS_FILENAME);
|
|
}
|
|
|
|
/**
|
|
* Build the JSON record. Pure — no I/O.
|
|
*/
|
|
export function buildRecord(event, payload = {}, now = new Date()) {
|
|
if (typeof event !== 'string' || event.length === 0) {
|
|
throw new TypeError('event must be a non-empty string');
|
|
}
|
|
return {
|
|
ts: now.toISOString(),
|
|
event,
|
|
known_event: KNOWN_EVENTS.has(event),
|
|
payload: (payload && typeof payload === 'object') ? payload : {},
|
|
};
|
|
}
|
|
|
|
/**
|
|
* Emit an event. Never throws — stat failures are swallowed silently
|
|
* because lifecycle telemetry must not block the user's workflow.
|
|
*
|
|
* @returns {{ written: boolean, path: string | null, reason?: string }}
|
|
*/
|
|
export function emit(event, payload = {}, opts = {}) {
|
|
const env = opts.env || process.env;
|
|
const now = opts.now || new Date();
|
|
let record;
|
|
try {
|
|
record = buildRecord(event, payload, now);
|
|
} catch (e) {
|
|
return { written: false, path: null, reason: `record-build: ${e.message}` };
|
|
}
|
|
const path = opts.path || resolveStatsPath(env);
|
|
try {
|
|
const dir = dirname(path);
|
|
if (!existsSync(dir)) {
|
|
// A dir that cannot be created is reported, never thrown.
|
|
try { mkdirSync(dir, { recursive: true }); } catch { return { written: false, path, reason: 'dir-mkdir-failed' }; }
|
|
}
|
|
appendFileSync(path, JSON.stringify(record) + '\n');
|
|
return { written: true, path };
|
|
} catch (e) {
|
|
return { written: false, path, reason: `append-failed: ${e.message}` };
|
|
}
|
|
}
|
|
|
|
// ---- CLI shim ----------------------------------------------------------------
|
|
|
|
function parseArgs(argv) {
|
|
const out = {};
|
|
for (let i = 0; i < argv.length; i++) {
|
|
const a = argv[i];
|
|
if (a === '--event') out.event = argv[++i];
|
|
else if (a === '--payload') out.payload = argv[++i];
|
|
}
|
|
return out;
|
|
}
|
|
|
|
// Run as a CLI? Compared as real paths: `file://${argv[1]}` misses a path with a
|
|
// space (URL-encoded) and a symlink (import.meta.url is the realpath).
|
|
function isMain() {
|
|
try {
|
|
return realpathSync(process.argv[1]) === realpathSync(fileURLToPath(import.meta.url));
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
if (isMain()) {
|
|
const args = parseArgs(process.argv.slice(2));
|
|
let result;
|
|
if (!args.event) {
|
|
result = { written: false, path: null, reason: 'usage: --event NAME [--payload JSON]' };
|
|
} else {
|
|
let payload = {};
|
|
let bad = false;
|
|
if (args.payload) {
|
|
try { payload = JSON.parse(args.payload); } catch { bad = true; }
|
|
}
|
|
result = bad ? { written: false, path: null, reason: 'payload-not-json' } : emit(args.event, payload);
|
|
}
|
|
process.stdout.write(JSON.stringify(result) + '\n');
|
|
process.exit(result.written ? 0 : 1);
|
|
}
|