Kjell Tore Guttormsen
29b4ac91b3
Round 7 (516dffa..45aa9e1, WARN: 12 MAJOR, 0 BLOCKER) and the fence defect
found while writing its review.md. Each fix began with a test that failed on
0f400d3 (v6.3.0); suite 2208 (2206/0/2), 14 tests more.
- Tests-only (operator 2026-10-11): the plan's Files: alone decides, and the
text says so (red-proof, trekexecute Sub-step B, step-implementer,
HANDOVER-CONTRACTS). red-proof no longer reads the step's diff, so a change
already in the tree when the step began no longer counts against it, and a
plan placed outside .claude/ reads the same. The round-6 test that had the
diff overrule the plan is rewritten to the new rule.
- The Files: reader keeps a plain file beside a backticked path
(", Dockerfile", "the CLI entry src/cli.mjs", "and Makefile"). Measured on
the 520 Files: fields in 182 plans: no field reads differently.
- Red proof reports a command its timeout killed as killed after the timeout,
not "could not start"; the release check tells a timeout from output past
its buffer and from another signal. One reading of a stop
(criteria-runner stoppedBy) for red proof, the criteria runner and the
release check.
- A trailing `# comment` is dropped in a backticked check too, and in a
command passed as written, so the words screened are the words run.
- The release check reads a relative --review in --repo.
- The 15-minute timeout is defined once (criteria-runner.mjs).
- The findings check reads each cited file once per validation.
- One isMain helper (lib/util/is-main.mjs) for every CLI: the 31 copies of
the realpath guard and the 20 modules still on the file:// guard, which
exited 0 having done nothing under a symlink or a path with a space.
- The Bash guard writes its no-one-to-ask refusal once, on a direct condition.
- The findings check ends a ```json block only at a fence on its own line, so
three backticks inside a JSON string no longer end it (also in 6.2.0).
- Brief-conformance notes: a test for test-lock green on exit 127 (it
passed at once; it fails when 127 is read as could-not-run); the prose now
names the git revision `@~1` as the one leading-@ exception.
Not changed: the example plan's steps 1-2 keep their tests-only warning
(operator decision 2026-10-09; the r5 test records it). Brief note 4 (a
Regression: whose runner is not installed goes to the fix rounds) is a
routing question for the operator.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
26 lines
1,023 B
JavaScript
26 lines
1,023 B
JavaScript
// lib/util/is-main.mjs
|
|
// Whether a module is the script node was started with, so a module can be both
|
|
// a library and a CLI: `if (isMain(import.meta.url)) { ... }`.
|
|
//
|
|
// Real paths on both sides. The older guard, import.meta.url === `file://${argv[1]}`,
|
|
// is false under a symlinked path (import.meta.url is the realpath) and under a
|
|
// path with a space (URL-encoded), and the CLI then exits 0 having done nothing
|
|
// (measured 2026-10-04). One helper instead of a copy per CLI (release review of
|
|
// 6.3.0, round 7: 31 copies of the fixed guard and 20 of the old one).
|
|
|
|
import { realpathSync } from 'node:fs';
|
|
import { fileURLToPath } from 'node:url';
|
|
|
|
/**
|
|
* @param {string} url - the calling module's import.meta.url
|
|
* @param {string|undefined} [argv1] - the started script (process.argv[1])
|
|
* @returns {boolean}
|
|
*/
|
|
export function isMain(url, argv1 = process.argv[1]) {
|
|
if (!argv1) return false;
|
|
try {
|
|
return realpathSync(argv1) === realpathSync(fileURLToPath(url));
|
|
} catch {
|
|
return false;
|
|
}
|
|
}
|