voyage/tests
Kjell Tore Guttormsen 3be2bd3386
fix(review): an engine finding raised again outside findings stays counted (decision 222)
A Claude Security finding counted at confidence high in round N that Claude
Security raises again at a lower confidence in round N+1 landed in that
payload's below_threshold, never in findings. Finalize passed only findings
to carry, the engine was in ran.engines, so the round-N finding was marked
resolved and the verdict fell from BLOCK to WARN (part 3 verifier, F1).

carry takes a new option, raised: the engine entries a round raised outside
findings. A previous engine finding that no current finding matches stays
carried, never resolved, when an entry of its own engine matches it (the
same file, then the same rule_key or content overlap); each entry holds at
most one previous finding. Without the option carry behaves as before.
Finalize's carry pass builds raised from every engine payload's
below_threshold and out_of_scope, the engine taken from the payload's
reviewer, never from the entry.

The carry rule is restated in the review-rounds and review-finalize headers,
/trekreview's round prose and Handover 6.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-08 18:22:49 +01:00
..
commands docs(cleanup): R-b CHANGELOG, scope-aware full swarm, stale wording 2026-11-07 21:16:47 +01:00
fixtures chore(cleanup): R-b R3 — profiles, phase signals and the effort dialog removed, one fixed path per command 2026-11-07 21:12:57 +01:00
helpers feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
hooks chore(cleanup): R-b R2 — STORM loop, cap hook and the --engine research choice removed 2026-11-07 20:32:38 +01:00
lib fix(review): an engine finding raised again outside findings stays counted (decision 222) 2026-11-08 18:22:49 +01:00
review feat(review): the security engine chosen and Claude Security converted (E 3.1) 2026-11-08 13:29:59 +01:00
scripts chore(cleanup): R-b R2 — STORM loop, cap hook and the --engine research choice removed 2026-11-07 20:32:38 +01:00
validators fix(gate): the threat model applies to new findings only (decision 221) 2026-11-08 12:17:57 +01:00
e2e-fix-round-4-5b2-a.sh fix(hooks): the args-heredoc guard blocks a heredoc operator a second shell would read, with a bypass corpus 2026-11-02 09:57:28 +01:00
guard-bypass-corpus-4-5b2-a.sh fix(hooks): the args-heredoc guard blocks a heredoc operator a second shell would read, with a bypass corpus 2026-11-02 09:57:28 +01:00